From: James Clark <james.clark@linaro.org>
To: irogers@google.com, linux-perf-users@vger.kernel.org,
kan.liang@linux.intel.com, ak@linux.intel.com,
namhyung@kernel.org
Cc: James Clark <james.clark@linaro.org>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Leo Yan <leo.yan@linux.dev>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Weilin Wang <weilin.wang@intel.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Colin Ian King <colin.i.king@gmail.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
Yang Jihong <yangjihong@bytedance.com>,
Howard Chu <howardchu95@gmail.com>, Ze Gao <zegao2021@gmail.com>,
Yanteng Si <siyanteng@loongson.cn>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Sun Haiyong <sunhaiyong@loongson.cn>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v7 6/7] perf test: Make stat test work on DT devices
Date: Tue, 10 Sep 2024 16:16:24 +0100 [thread overview]
Message-ID: <20240910151640.907359-7-james.clark@linaro.org> (raw)
In-Reply-To: <20240910151640.907359-1-james.clark@linaro.org>
PMUs aren't listed in /sys/devices/ on DT devices, so change the search
directory to /sys/bus/event_source/devices which works everywhere. Also
add armv8_cortex_* as a known PMU type to search for to make the test
run on more devices.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: James Clark <james.clark@linaro.org>
---
tools/perf/tests/shell/stat.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tools/perf/tests/shell/stat.sh b/tools/perf/tests/shell/stat.sh
index 3f1e67795490..525d0c44fdc6 100755
--- a/tools/perf/tests/shell/stat.sh
+++ b/tools/perf/tests/shell/stat.sh
@@ -117,16 +117,18 @@ test_cputype() {
# Find a known PMU for cputype.
pmu=""
- for i in cpu cpu_atom armv8_pmuv3_0
+ devs="/sys/bus/event_source/devices"
+ for i in $devs/cpu $devs/cpu_atom $devs/armv8_pmuv3_0 $devs/armv8_cortex_*
do
- if test -d "/sys/devices/$i"
+ i_base=$(basename "$i")
+ if test -d "$i"
then
- pmu="$i"
+ pmu="$i_base"
break
fi
- if perf stat -e "$i/instructions/" true > /dev/null 2>&1
+ if perf stat -e "$i_base/instructions/" true > /dev/null 2>&1
then
- pmu="$i"
+ pmu="$i_base"
break
fi
done
--
2.34.1
next prev parent reply other threads:[~2024-09-10 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 15:16 [PATCH v7 0/7] Event parsing fixes James Clark
2024-09-10 15:16 ` [PATCH v7 1/7] perf evsel: Add alternate_hw_config and use in evsel__match James Clark
2024-09-10 15:16 ` [PATCH v7 2/7] perf stat: Uniquify event name improvements James Clark
2024-09-10 15:16 ` [PATCH v7 3/7] perf stat: Remove evlist__add_default_attrs use strings James Clark
2024-09-10 15:16 ` [PATCH v7 4/7] perf evsel x86: Make evsel__has_perf_metrics work for legacy events James Clark
2024-09-10 15:16 ` [PATCH v7 5/7] perf evsel: Remove pmu_name James Clark
2024-09-10 15:16 ` James Clark [this message]
2024-09-10 15:16 ` [PATCH v7 7/7] perf test: Add a test for default perf stat command James Clark
2024-09-10 16:19 ` [PATCH v7 0/7] Event parsing fixes Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910151640.907359-7-james.clark@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=colin.i.king@gmail.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=siyanteng@loongson.cn \
--cc=sunhaiyong@loongson.cn \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
--cc=yangjihong@bytedance.com \
--cc=yangyicong@hisilicon.com \
--cc=zegao2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).