* [PATCH] perf evsel: display dmesg command of showing a hardcoded path
@ 2024-09-22 11:22 Masum Reza
0 siblings, 0 replies; 3+ messages in thread
From: Masum Reza @ 2024-09-22 11:22 UTC (permalink / raw)
Cc: masumrezarock100, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Ze Gao, Yang Jihong, John Titor, linux-perf-users,
linux-kernel
In non-FHS compliant distros like NixOS, nothing resides in `/bin`
and `/usr/bin`. Instead dynamically symlinked into
`/run/current-system/sw/bin/`, the executable resides in `/nix/store`.
With this patch,`/bin` prefix from the dmesg command in the error
message is stripped.
Link: https://github.com/NixOS/nixpkgs/pull/258027
---
tools/perf/util/evsel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index bc603193c477..7a06b7cfdc7e 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3342,7 +3342,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
return scnprintf(msg, size,
"The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
- "/bin/dmesg | grep -i perf may provide additional information.\n",
+ "\"dmesg | grep -i perf\" may provide additional information.\n",
err, str_error_r(err, sbuf, sizeof(sbuf)), evsel__name(evsel));
}
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] perf evsel: display dmesg command of showing a hardcoded path
@ 2024-09-22 11:26 Masum Reza
2024-09-25 22:41 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: Masum Reza @ 2024-09-22 11:26 UTC (permalink / raw)
Cc: masumrezarock100, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Liang, Kan, Ze Gao, Yang Jihong, Yunseong Kim, linux-perf-users,
linux-kernel
In non-FHS compliant distros like NixOS, nothing resides in `/bin`
and `/usr/bin`. Instead dynamically symlinked into
`/run/current-system/sw/bin/`, the executable resides in `/nix/store`.
With this patch,`/bin` prefix from the dmesg command in the error
message is stripped.
Link: https://github.com/NixOS/nixpkgs/pull/258027
Signed-off-by: Masum Reza <masumrezarock100@gmail.com>
---
tools/perf/util/evsel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index bc603193c477..7a06b7cfdc7e 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -3342,7 +3342,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,
return scnprintf(msg, size,
"The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
- "/bin/dmesg | grep -i perf may provide additional information.\n",
+ "\"dmesg | grep -i perf\" may provide additional information.\n",
err, str_error_r(err, sbuf, sizeof(sbuf)), evsel__name(evsel));
}
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf evsel: display dmesg command of showing a hardcoded path
2024-09-22 11:26 Masum Reza
@ 2024-09-25 22:41 ` Namhyung Kim
0 siblings, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2024-09-25 22:41 UTC (permalink / raw)
To: Masum Reza
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, Liang, Kan, Ze Gao, Yang Jihong, Yunseong Kim,
linux-perf-users, linux-kernel
On Sun, 22 Sep 2024 16:56:16 +0530, Masum Reza wrote:
> In non-FHS compliant distros like NixOS, nothing resides in `/bin`
> and `/usr/bin`. Instead dynamically symlinked into
> `/run/current-system/sw/bin/`, the executable resides in `/nix/store`.
>
> With this patch,`/bin` prefix from the dmesg command in the error
> message is stripped.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-25 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-22 11:22 [PATCH] perf evsel: display dmesg command of showing a hardcoded path Masum Reza
-- strict thread matches above, loose matches on Subject: below --
2024-09-22 11:26 Masum Reza
2024-09-25 22:41 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).