From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6149C29A2 for ; Thu, 10 Oct 2024 00:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728518850; cv=none; b=Zfm/a7ppOFHsCgiy7SdDYaqQmDb1/7D0xnR7d2qxBoxIojcWWFB1T3MlcZT3sn9J2+UJkE2zrDh997pHSvO124N0x1ngT2bko3ojs3Wgq9LxW56rW701vilheGQSg3Nde56vqsyjvhhu0ZaOwcgCK5TPGC9wIowjwoBFkxjzaBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728518850; c=relaxed/simple; bh=873TCTNElKQX0bZntabxvE87Xk82g/cv1CuRKgs9g7A=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=gpeW8Qv0dZXSWapHBrD9mkOrWXwJBWm/X5Ql3ymcJUjynVZauastlbj6LoU0iPgy91QejQ2479VdffmLV6dIWna2n6InXp/xdw+jMhTr2MgeqwmEsD8PoRvQjtS1GUyKgHbyNsylkdniu2tnAaroP/HEiX3pdi/dGXkqKekq494= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=u6IdLcU2; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u6IdLcU2" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e0b8fa94718so557279276.0 for ; Wed, 09 Oct 2024 17:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728518848; x=1729123648; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=wxLrGOjIUYrXf1Xm3RquDNZNVmQNpQ36swJ9i1PVT94=; b=u6IdLcU2hdjgN7+Oqe0z977Qlk27hVrT4cX+8S5FxMQZEVuIOGScZmQA0Y6i6y21tT MNePSAFbmEeB5l1qCzAZtZ2P7jnf5yzmrAraht6IMYAzTjfScB1rt2+VxKDuLh7UfBO0 WfeZM+tnO1/lX4Nmdgs8tcCuq4Fdoxz9foJ6pCwIqGJuK/+rKXJRBHBDU20BVbmCYB/S TUq4Ms1LKAQWbDyAT3GuNDCzk0n9vc/DcRS6g4hDOvWM2a3wW3asKYSw1LYnyFx45tzs SISUg5pFSaM5j+ewq6VzsFIPkOMZADaHZh27qfdyNMxTL8dRQeqQnRThAG+mgLHulB3p wrcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728518848; x=1729123648; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wxLrGOjIUYrXf1Xm3RquDNZNVmQNpQ36swJ9i1PVT94=; b=AMCtVccSCxWRHsbzLToJNqXS+etCHQOjtQd85RrSm0MnYRFC3DdH9GVbDPxQ9R2mJp bZpmYifX62LbjuFeAF+H7nol6uLcSGb9bmgcY1NLsQPXc2/jkTEe/h1m9MBNgblUjh0T +G+q9gXJbLW2pJelaWnaur3C3Adh5l4qww3MGL/oHJGVkYOQNFwezJV/CKOGU9qyt6+K O0SVnQzijIE5pGRr5tQ95qNSrvcg3xswWCcaAzl4sDKJVthIxNV8vMGhBtKOJ3NXTd1I 4ZhX3TRa+gLiHtsHccgGnXx+MYGlfsPJKd8IJXEtzlwblHBvd1LGz44CBZmSc6bfjvby eYOw== X-Forwarded-Encrypted: i=1; AJvYcCWmpBBLPqZlbDvsaaM/5aaxNeDVCZA+aL1NMTF03qV0MkV6g2QegwfqoJr/Hx3b8/WWTryr6911GUpIeisZaTSx@vger.kernel.org X-Gm-Message-State: AOJu0Yz7DhB3txJ2JAjej6HXfp2S3ytxcI9TADhydQlLSaXGuo5vULx9 BR6QfE+Krgy3kLE8uWyevOD8UNu1+1k2qrSXL12vO8PLNl4LBxKg40+lN5W6kBDNmSzp3h2vbp0 NI2e/WQ== X-Google-Smtp-Source: AGHT+IFay/ECMcmFAcUljtg9lOQdarFfE1jnU6vii9GYoXo19lPJtQcJUKrBTdhSQDmFgfSly7DwKWWJ7dIF X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:6c8b:1170:a0ca:9d72]) (user=irogers job=sendgmr) by 2002:a25:ab6d:0:b0:e28:f8e6:f4c6 with SMTP id 3f1490d57ef6-e28fe465652mr32303276.2.1728518848391; Wed, 09 Oct 2024 17:07:28 -0700 (PDT) Date: Wed, 9 Oct 2024 17:07:13 -0700 Message-Id: <20241010000719.1172854-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.0.rc1.288.g06298d1525-goog Subject: [PATCH v2 0/6] CSV/JSON metric thresholds, fix printf modifiers From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Weilin Wang , Tim Chen , Thomas Richter , Sumanth Korikkar , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Metric thresholds are being computed for CSV and JSON output but not displayed. Rename the color that encodes the threshold as enum values and use to generate string constants in a CSV column or json dictionary value. Add printf attribute to functions in color.h that could support it. Fix bad printf format strings that this detected. v2. Don't display metric-value for json output if there is no unit. Ian Rogers (6): perf color: Add printf format checking and resolve issues perf stat: Fix/add parameter names for print_metric perf stat: Display "none" for NaN with metric only json perf stat: Drop metric-unit if unit is NULL perf stat: Change color to threshold in print_metric perf stat: Display metric threshold value in CSV output tools/perf/Documentation/perf-stat.txt | 1 + tools/perf/arch/x86/util/iostat.c | 2 +- tools/perf/builtin-sched.c | 2 +- tools/perf/builtin-script.c | 6 +- tools/perf/builtin-trace.c | 2 +- tools/perf/tests/shell/stat+csv_output.sh | 24 ++-- tools/perf/util/arm-spe.c | 2 +- tools/perf/util/color.h | 9 +- tools/perf/util/intel-bts.c | 2 +- tools/perf/util/intel-pt.c | 2 +- tools/perf/util/s390-cpumsf.c | 2 +- tools/perf/util/s390-sample-raw.c | 6 +- tools/perf/util/stat-display.c | 80 ++++++++++---- tools/perf/util/stat-shadow.c | 128 ++++++++++++---------- tools/perf/util/stat.h | 16 ++- 15 files changed, 174 insertions(+), 110 deletions(-) -- 2.47.0.rc1.288.g06298d1525-goog