From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
Liao Chang <liaochang1@huawei.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] uprobes: Remove redundant spinlock in uprobe_deny_signal
Date: Tue, 22 Oct 2024 12:45:01 +0900 [thread overview]
Message-ID: <20241022124501.5a6875f4d1725e2864cdcc48@kernel.org> (raw)
In-Reply-To: <20241022112222.1edeeac3aee13714a53c217c@kernel.org>
On Tue, 22 Oct 2024 11:22:22 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> On Wed, 31 Jul 2024 16:12:32 +0200
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > On 07/31, Liao Chang wrote:
> > >
> > > --- a/kernel/events/uprobes.c
> > > +++ b/kernel/events/uprobes.c
> > > @@ -1979,9 +1979,7 @@ bool uprobe_deny_signal(void)
> > > WARN_ON_ONCE(utask->state != UTASK_SSTEP);
> > >
> > > if (task_sigpending(t)) {
> > > - spin_lock_irq(&t->sighand->siglock);
> > > clear_tsk_thread_flag(t, TIF_SIGPENDING);
> > > - spin_unlock_irq(&t->sighand->siglock);
> >
> > Agreed, in this case ->siglock buys nothing, another signal can come
> > right after spin_unlock().
> >
> > Acked-by: Oleg Nesterov <oleg@redhat.com>
> >
> >
>
> Looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Peter, can you pick this?
Oops, there is v3.
https://lore.kernel.org/linux-trace-kernel/20240815014629.2685155-2-liaochang1@huawei.com/
>
> Thanks,
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2024-10-22 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 9:50 [PATCH] uprobes: Remove redundant spinlock in uprobe_deny_signal Liao Chang
2024-07-31 14:12 ` Oleg Nesterov
2024-10-22 2:22 ` Masami Hiramatsu
2024-10-22 3:45 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022124501.5a6875f4d1725e2864cdcc48@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).