From: "Frank Ch. Eigler" <fche@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Francesco Nigro <fnigro@redhat.com>,
Aaron Merey <amerey@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1 perf-tools-next] perf probe: Fix retrieval of source files from a debuginfod server
Date: Mon, 28 Oct 2024 17:48:33 -0400 [thread overview]
Message-ID: <20241028214833.GB25044@redhat.com> (raw)
In-Reply-To: <ZyACsIFUETsr7-09@x1>
Hi -
> - if (!get_source_from_debuginfod(raw_path, sbuild_id, new_path))
> + char prefixed_raw_path[PATH_MAX];
> +
> + path__join(prefixed_raw_path, sizeof(prefixed_raw_path), comp_dir, raw_path);
> +
> + if (!get_source_from_debuginfod(prefixed_raw_path, sbuild_id, n
ew_path))
lgtm!
- FChE
next prev parent reply other threads:[~2024-10-28 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 21:31 [PATCH 1/1 perf-tools-next] perf probe: Fix retrieval of source files from a debuginfod server Arnaldo Carvalho de Melo
2024-10-28 21:48 ` Frank Ch. Eigler [this message]
2024-10-30 21:30 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028214833.GB25044@redhat.com \
--to=fche@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=amerey@redhat.com \
--cc=fnigro@redhat.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox