From: James Clark <james.clark@linaro.org>
To: linux-perf-users@vger.kernel.org, acme@kernel.org,
namhyung@kernel.org, irogers@google.com,
tim.c.chen@linux.intel.com
Cc: James Clark <james.clark@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] perf stat: Fix trailing comma when there is no metric unit
Date: Wed, 30 Oct 2024 11:39:43 +0000 [thread overview]
Message-ID: <20241030113946.229361-1-james.clark@linaro.org> (raw)
The first commit is failing on Arm and I think the fix should stop more
trailing comma issues which keep happening.
The second one I just noticed when looking at it. I don't feel strongly
about it so not sure if we should do it or not, but seems like the empty
metric-units exclusion from the JSON should be consistent if we're going
to have it at all.
Changes since v1:
* Don't skip printing when the metric-unit string is empty but pass
NULL instead of an empty string.
James Clark (2):
perf stat: Fix trailing comma when there is no metric unit
perf stat: Also hide metric-units from JSON when event didn't run
.../tests/shell/lib/perf_json_output_lint.py | 14 +-
tools/perf/util/stat-display.c | 182 ++++++++++--------
2 files changed, 107 insertions(+), 89 deletions(-)
--
2.34.1
next reply other threads:[~2024-10-30 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:39 James Clark [this message]
2024-10-30 11:39 ` [PATCH v2 1/2] perf stat: Fix trailing comma when there is no metric unit James Clark
2024-10-31 4:17 ` Ian Rogers
2024-11-01 11:09 ` James Clark
2024-10-30 11:39 ` [PATCH v2 2/2] perf stat: Also hide metric-units from JSON when event didn't run James Clark
2024-10-31 4:17 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030113946.229361-1-james.clark@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tim.c.chen@linux.intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).