From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0FC017C69 for ; Fri, 1 Nov 2024 00:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730422433; cv=none; b=a61SU/HXpj7/5UIDVFzYeTayTSD37q+yC8oW2nb/5wTV4MG63miNOrp+5BCIlXzVXtZQWk62HsyDD0sSgDc/TxfZBpJnlyWGkiVTsh9jlVPMRZwkJhfL+celdGC9ri9uf3f7IxJK2DyUDyyvxNXXvN5O76UDrVyu2kbdGapDUzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730422433; c=relaxed/simple; bh=Fd53hf4/RzRbOlaIQTaXnXLpx98XHo0+e+k+4mKzGzw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cm14z6duJmBF9CjW12c4V/uSldxvN9kE0G3IvAdrFYkQXesTR3s6v18I6mXE2YaBYR7dSaKMB+Gu38auBzIgczJgI4CamJQKs2k5ym2gCbxhA+STw3X/ZrbyndhJGCvR/5tG3vApSrb3rzB/ZbzCCeU2h3aOGZEdzcV+AiO0/3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=engflow.com; spf=pass smtp.mailfrom=engflow.com; dkim=pass (1024-bit key) header.d=engflow.com header.i=@engflow.com header.b=SjNkMqEy; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=engflow.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=engflow.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=engflow.com header.i=@engflow.com header.b="SjNkMqEy" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-83ac05206f6so56076539f.2 for ; Thu, 31 Oct 2024 17:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=engflow.com; s=google; t=1730422425; x=1731027225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PIqo+wi9i5UZ//zk2SA7F2V2ncICcbOru3HSWAU6eM0=; b=SjNkMqEyAOzIxGYMpLCGk9aOkq6bT0lv4rsT/JneFQ5/vCtK0jCEsHzhdMKvraRafw zfFcZ3lgt+ClXH9QE2jDIHWU2i03ZEC2rPgtdYzpuWXXZGm/aop1YISwNqs3w5FZ4b4N c69Oryt5YP11KHqXlEDarzVWXTmuE5U62DLIo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730422425; x=1731027225; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PIqo+wi9i5UZ//zk2SA7F2V2ncICcbOru3HSWAU6eM0=; b=poT2YE/uCFmF/TWSzzMpvj6kPuZ5GnsHmOBFqqmrDWlOeWxaOc0VkE1+HwVjrZrNFh nlFlefWMo3I08RugrB33OYW697/ZBFA+Afyy/xRpm4Np2x8mxYTnNHJFvYgYy9WnTRI+ vY3el4iYsXZOdnFBkxBhN/eDpYhKSoy8+zj05hbLkn195XA1AtF7uARTmPlyHXF4QOXd HLANA9pCTEmBs57F8xz3FHWgcCSwPPY+qg4wJzS6AGrvcabyerCO3PMrE7hnQXfgy+Bp Q5gJXE/fM5EQbwv/wGmtNaGCUtB0ibjy6BafPq/j9c/O5pFOopkyrFbIyHxtVgFy1dq9 Pt9A== X-Forwarded-Encrypted: i=1; AJvYcCWFh63/d3iCtNiUqboG0FqsiNsJ8OggsrpW4n18VVb8mzj+prL48r6AQgZ4+3qf/6j4OONdLJKx1gA4TRTgv4SV@vger.kernel.org X-Gm-Message-State: AOJu0YzLkI+jrOM+7Zq1cVXSxaHWvm/rxWMpbL2GnkmELCpUCHC6q1iy 9lDYmbLnhfYrh9gNUMoXLBkUA/GcqijsZmJhBfgYDmajT2da12yXq2j4fUwdJt8= X-Google-Smtp-Source: AGHT+IGLaH5ZkQIPqx3YrpCB9KbvsM5vvwGg8SFqNHbOVbWsBbXePi3eicUjv0FUyngZnJqQ+I7T2A== X-Received: by 2002:a05:6602:2cd0:b0:83b:2b89:a14e with SMTP id ca18e2360f4ac-83b65057c06mr557876139f.13.1730422424906; Thu, 31 Oct 2024 17:53:44 -0700 (PDT) Received: from benjamin-test-build-vm.us-central1-a.c.engflow-remote-execution.internal (160.244.56.34.bc.googleusercontent.com. [34.56.244.160]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4de04977934sm523548173.97.2024.10.31.17.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 17:53:43 -0700 (PDT) From: Benjamin Peterson To: Cc: Benjamin Peterson , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , linux-perf-users@vger.kernel.org (open list:PERFORMANCE EVENTS SUBSYSTEM), linux-kernel@vger.kernel.org (open list:PERFORMANCE EVENTS SUBSYSTEM) Subject: [PATCH] perf trace: avoid garbage when not printing an trace event's arguments Date: Fri, 1 Nov 2024 00:53:37 +0000 Message-Id: <20241101005338.5846-1-benjamin@engflow.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit trace__fprintf_tp_fields may not print any tracepoint arguments. E.g., if the argument values are all zero. Previously, this would result in a totally uninitialized buffer being passed to fprintf, which could lead to garbage on the console. Fix the problem by passing the number of initialized bytes fprintf. Remove the return value of trace__fprintf_tp_fields, since it was meaningless and ignored. Fixes: f11b2803bb88 ("perf trace: Allow choosing how to augment the tracepoint arguments") Signed-off-by: Benjamin Peterson --- tools/perf/builtin-trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index d3f11b90d025..e93f795e680f 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -3021,7 +3021,7 @@ static void bpf_output__fprintf(struct trace *trace, ++trace->nr_events_printed; } -static size_t trace__fprintf_tp_fields(struct trace *trace, struct evsel *evsel, struct perf_sample *sample, +static void trace__fprintf_tp_fields(struct trace *trace, struct evsel *evsel, struct perf_sample *sample, struct thread *thread, void *augmented_args, int augmented_args_size) { char bf[2048]; @@ -3087,7 +3087,7 @@ static size_t trace__fprintf_tp_fields(struct trace *trace, struct evsel *evsel, printed += syscall_arg_fmt__scnprintf_val(arg, bf + printed, size - printed, &syscall_arg, val); } - return printed + fprintf(trace->output, "%s", bf); + fprintf(trace->output, "%.*s", printed, bf); } static int trace__event_handler(struct trace *trace, struct evsel *evsel, -- 2.39.5