From: Leo Yan <leo.yan@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Liang, Kan" <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Leo Yan <leo.yan@arm.com>
Subject: [PATCH v2 0/3] perf cpumap: Refactor perf_cpu_map__merge()
Date: Thu, 7 Nov 2024 12:53:05 +0000 [thread overview]
Message-ID: <20241107125308.41226-1-leo.yan@arm.com> (raw)
perf_cpu_map__merge() has two arguments, 'orig' and 'other'. The
function definition might cause confusion as it could give
the impression that the CPU maps in the two arguments are copied into a
new allocated structure, which is then returned as the result.
This patch series refactors perf_cpu_map__merge(), makes that the first
argument 'orig' as a pointer to pointer, the merged result will be
updated into 'orig' rather than returning a pointer. This can be clear
for the semantics that it merges 'other' into 'orig'.
The perf test has been updated for covering more cases for CPU map
merging. Tested result is:
# ./perf test 41
41: CPU map :
41.1: Synthesize cpu map : Ok
41.2: Print cpu map : Ok
41.3: Merge cpu map : Ok
41.4: Intersect cpu map : Ok
41.5: Equal cpu map : Ok
Leo Yan (3):
libperf cpumap: Refactor perf_cpu_map__merge()
perf cpumap: Add more tests for CPU map merging
perf cpumap: Add checking for reference counter
tools/lib/perf/cpumap.c | 49 +++++++++++++------------
tools/lib/perf/evlist.c | 2 +-
tools/lib/perf/include/perf/cpumap.h | 4 +--
tools/perf/tests/cpumap.c | 54 ++++++++++++++++++++++------
tools/perf/util/mem-events.c | 5 ++-
5 files changed, 77 insertions(+), 37 deletions(-)
--
2.34.1
next reply other threads:[~2024-11-07 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 12:53 Leo Yan [this message]
2024-11-07 12:53 ` [PATCH v2 1/3] libperf cpumap: Refactor perf_cpu_map__merge() Leo Yan
2024-11-15 8:38 ` Adrian Hunter
2024-11-07 12:53 ` [PATCH v2 2/3] perf cpumap: Add more tests for CPU map merging Leo Yan
2024-11-15 8:44 ` Adrian Hunter
2024-11-07 12:53 ` [PATCH v2 3/3] perf cpumap: Add checking for reference counter Leo Yan
2024-11-15 8:49 ` Adrian Hunter
2024-12-09 15:02 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107125308.41226-1-leo.yan@arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).