linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Howard Chu <howardchu95@gmail.com>
To: acme@kernel.org, peterz@infradead.org
Cc: namhyung@kernel.org, irogers@google.com, mingo@redhat.com,
	mark.rutland@arm.com, james.clark@linaro.org,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	adrian.hunter@intel.com, kan.liang@linux.intel.com,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Howard Chu <howardchu95@gmail.com>
Subject: [PATCH v7 04/10] perf record --off-cpu: Preparation of off-cpu BPF program
Date: Fri,  8 Nov 2024 12:41:31 -0800	[thread overview]
Message-ID: <20241108204137.2444151-5-howardchu95@gmail.com> (raw)
In-Reply-To: <20241108204137.2444151-1-howardchu95@gmail.com>

Set the perf_event map in BPF for dumping off-cpu samples.

Set the offcpu_thresh to specify the threshold.

Signed-off-by: Howard Chu <howardchu95@gmail.com>
---
 tools/perf/util/bpf_off_cpu.c          | 20 ++++++++++++++++++++
 tools/perf/util/bpf_skel/off_cpu.bpf.c |  2 ++
 2 files changed, 22 insertions(+)

diff --git a/tools/perf/util/bpf_off_cpu.c b/tools/perf/util/bpf_off_cpu.c
index 558c5e5c2dc3..cfe5b17393e9 100644
--- a/tools/perf/util/bpf_off_cpu.c
+++ b/tools/perf/util/bpf_off_cpu.c
@@ -13,6 +13,7 @@
 #include "util/cgroup.h"
 #include "util/strlist.h"
 #include <bpf/bpf.h>
+#include <internal/xyarray.h>
 
 #include "bpf_skel/off_cpu.skel.h"
 
@@ -73,6 +74,23 @@ static void off_cpu_start(void *arg)
 		bpf_map_update_elem(fd, &pid, &val, BPF_ANY);
 	}
 
+	/* update BPF perf_event map */
+	evsel = evlist__find_evsel_by_str(evlist, OFFCPU_EVENT);
+	if (evsel == NULL) {
+		pr_err("%s evsel not found\n", OFFCPU_EVENT);
+		return;
+	}
+
+	perf_cpu_map__for_each_cpu(pcpu, i, evsel->core.cpus) {
+		err = bpf_map__update_elem(skel->maps.offcpu_output, &pcpu.cpu, sizeof(__u32),
+					   xyarray__entry(evsel->core.fd, i, 0),
+					   sizeof(__u32), BPF_ANY);
+		if (err) {
+			pr_err("Failed to update perf event map for direct off-cpu dumping\n");
+			return;
+		}
+	}
+
 	skel->bss->enabled = 1;
 }
 
@@ -261,6 +279,8 @@ int off_cpu_prepare(struct evlist *evlist, struct target *target,
 		}
 	}
 
+	skel->bss->offcpu_thresh = opts->off_cpu_thresh * 1000;
+
 	err = off_cpu_bpf__attach(skel);
 	if (err) {
 		pr_err("Failed to attach off-cpu BPF skeleton\n");
diff --git a/tools/perf/util/bpf_skel/off_cpu.bpf.c b/tools/perf/util/bpf_skel/off_cpu.bpf.c
index c152116df72f..dc6acafb9353 100644
--- a/tools/perf/util/bpf_skel/off_cpu.bpf.c
+++ b/tools/perf/util/bpf_skel/off_cpu.bpf.c
@@ -97,6 +97,8 @@ const volatile bool uses_cgroup_v1 = false;
 
 int perf_subsys_id = -1;
 
+__u64 offcpu_thresh;
+
 /*
  * Old kernel used to call it task_struct->state and now it's '__state'.
  * Use BPF CO-RE "ignored suffix rule" to deal with it like below:
-- 
2.43.0


  parent reply	other threads:[~2024-11-08 20:41 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 20:41 [PATCH v7 00/10] perf record --off-cpu: Dump off-cpu samples directly Howard Chu
2024-11-08 20:41 ` [PATCH v7 01/10] perf record --off-cpu: Add --off-cpu-thresh option Howard Chu
2024-11-11 17:40   ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 02/10] perf evsel: Expose evsel__is_offcpu_event() for future use Howard Chu
2024-11-11 17:41   ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 03/10] perf record --off-cpu: Parse off-cpu event Howard Chu
2024-11-11 17:45   ` Ian Rogers
2024-11-11 18:10     ` Howard Chu
2024-11-08 20:41 ` Howard Chu [this message]
2024-11-11 17:47   ` [PATCH v7 04/10] perf record --off-cpu: Preparation of off-cpu BPF program Ian Rogers
2024-11-11 18:08     ` Howard Chu
2024-11-12 20:52     ` Howard Chu
2024-11-08 20:41 ` [PATCH v7 05/10] perf record --off-cpu: Dump off-cpu samples in BPF Howard Chu
2024-11-11 17:54   ` Ian Rogers
2024-11-11 18:05     ` Howard Chu
2024-11-11 18:11       ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 06/10] perf evsel: Assemble offcpu samples Howard Chu
2024-11-11 17:55   ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 07/10] perf record --off-cpu: Disable perf_event's callchain collection Howard Chu
2024-11-08 20:41 ` [PATCH v7 08/10] perf script: Display off-cpu samples correctly Howard Chu
2024-11-11 17:56   ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 09/10] perf record --off-cpu: Dump the remaining samples in BPF's stack trace map Howard Chu
2024-11-11 18:06   ` Ian Rogers
2024-11-12 21:40     ` Howard Chu
2024-11-08 20:41 ` [PATCH v7 10/10] perf test: Add direct off-cpu test Howard Chu
2024-11-11 18:08   ` Ian Rogers
2024-11-12 18:39 ` [PATCH v7 00/10] perf record --off-cpu: Dump off-cpu samples directly Arnaldo Carvalho de Melo
2024-11-12 18:59   ` Ian Rogers
2024-11-12 19:17   ` Arnaldo Carvalho de Melo
2024-11-12 19:18     ` Arnaldo Carvalho de Melo
2024-11-12 19:18       ` Arnaldo Carvalho de Melo
2024-11-12 19:32         ` Arnaldo Carvalho de Melo
2024-11-12 19:56     ` Arnaldo Carvalho de Melo
2024-11-12 20:03       ` Howard Chu
2024-11-16 14:42       ` Howard Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241108204137.2444151-5-howardchu95@gmail.com \
    --to=howardchu95@gmail.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).