From: Howard Chu <howardchu95@gmail.com>
To: acme@kernel.org, peterz@infradead.org
Cc: namhyung@kernel.org, irogers@google.com, mingo@redhat.com,
mark.rutland@arm.com, james.clark@linaro.org,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, kan.liang@linux.intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Howard Chu <howardchu95@gmail.com>
Subject: [PATCH v7 08/10] perf script: Display off-cpu samples correctly
Date: Fri, 8 Nov 2024 12:41:35 -0800 [thread overview]
Message-ID: <20241108204137.2444151-9-howardchu95@gmail.com> (raw)
In-Reply-To: <20241108204137.2444151-1-howardchu95@gmail.com>
No PERF_SAMPLE_CALLCHAIN in sample_type, but I need perf script to
display a callchain, have to specify manually.
Also, prefer displaying a callchain:
gvfs-afc-volume 2267 [001] 3829232.955656: 1001115340 offcpu-time:
77f05292603f __pselect+0xbf (/usr/lib/x86_64-linux-gnu/libc.so.6)
77f052a1801c [unknown] (/usr/lib/x86_64-linux-gnu/libusbmuxd-2.0.so.6.0.0)
77f052a18d45 [unknown] (/usr/lib/x86_64-linux-gnu/libusbmuxd-2.0.so.6.0.0)
77f05289ca94 start_thread+0x384 (/usr/lib/x86_64-linux-gnu/libc.so.6)
77f052929c3c clone3+0x2c (/usr/lib/x86_64-linux-gnu/libc.so.6)
to a raw binary BPF output:
BPF output: 0000: dd 08 00 00 db 08 00 00 <DD>...<DB>...
0008: cc ce ab 3b 00 00 00 00 <CC>Ϋ;....
0010: 06 00 00 00 00 00 00 00 ........
0018: 00 fe ff ff ff ff ff ff .<FE><FF><FF><FF><FF><FF><FF>
0020: 3f 60 92 52 f0 77 00 00 ?`.R<F0>w..
0028: 1c 80 a1 52 f0 77 00 00 ..<A1>R<F0>w..
0030: 45 8d a1 52 f0 77 00 00 E.<A1>R<F0>w..
0038: 94 ca 89 52 f0 77 00 00 .<CA>.R<F0>w..
0040: 3c 9c 92 52 f0 77 00 00 <..R<F0>w..
0048: 00 00 00 00 00 00 00 00 ........
0050: 00 00 00 00 ....
Signed-off-by: Howard Chu <howardchu95@gmail.com>
---
tools/perf/builtin-script.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 6b6d4472db6e..1893d2117aab 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -662,7 +662,7 @@ static int perf_session__check_output_opt(struct perf_session *session)
evlist__for_each_entry(session->evlist, evsel) {
not_pipe = true;
- if (evsel__has_callchain(evsel)) {
+ if (evsel__has_callchain(evsel) || evsel__is_offcpu_event(evsel)) {
use_callchain = true;
break;
}
@@ -2353,7 +2353,7 @@ static void process_event(struct perf_script *script,
else if (PRINT_FIELD(BRSTACKOFF))
perf_sample__fprintf_brstackoff(sample, thread, attr, fp);
- if (evsel__is_bpf_output(evsel) && PRINT_FIELD(BPF_OUTPUT))
+ if (evsel__is_bpf_output(evsel) && !evsel__is_offcpu_event(evsel) && PRINT_FIELD(BPF_OUTPUT))
perf_sample__fprintf_bpf_output(sample, fp);
perf_sample__fprintf_insn(sample, evsel, attr, thread, machine, fp, al);
--
2.43.0
next prev parent reply other threads:[~2024-11-08 20:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 20:41 [PATCH v7 00/10] perf record --off-cpu: Dump off-cpu samples directly Howard Chu
2024-11-08 20:41 ` [PATCH v7 01/10] perf record --off-cpu: Add --off-cpu-thresh option Howard Chu
2024-11-11 17:40 ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 02/10] perf evsel: Expose evsel__is_offcpu_event() for future use Howard Chu
2024-11-11 17:41 ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 03/10] perf record --off-cpu: Parse off-cpu event Howard Chu
2024-11-11 17:45 ` Ian Rogers
2024-11-11 18:10 ` Howard Chu
2024-11-08 20:41 ` [PATCH v7 04/10] perf record --off-cpu: Preparation of off-cpu BPF program Howard Chu
2024-11-11 17:47 ` Ian Rogers
2024-11-11 18:08 ` Howard Chu
2024-11-12 20:52 ` Howard Chu
2024-11-08 20:41 ` [PATCH v7 05/10] perf record --off-cpu: Dump off-cpu samples in BPF Howard Chu
2024-11-11 17:54 ` Ian Rogers
2024-11-11 18:05 ` Howard Chu
2024-11-11 18:11 ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 06/10] perf evsel: Assemble offcpu samples Howard Chu
2024-11-11 17:55 ` Ian Rogers
2024-11-08 20:41 ` [PATCH v7 07/10] perf record --off-cpu: Disable perf_event's callchain collection Howard Chu
2024-11-08 20:41 ` Howard Chu [this message]
2024-11-11 17:56 ` [PATCH v7 08/10] perf script: Display off-cpu samples correctly Ian Rogers
2024-11-08 20:41 ` [PATCH v7 09/10] perf record --off-cpu: Dump the remaining samples in BPF's stack trace map Howard Chu
2024-11-11 18:06 ` Ian Rogers
2024-11-12 21:40 ` Howard Chu
2024-11-08 20:41 ` [PATCH v7 10/10] perf test: Add direct off-cpu test Howard Chu
2024-11-11 18:08 ` Ian Rogers
2024-11-12 18:39 ` [PATCH v7 00/10] perf record --off-cpu: Dump off-cpu samples directly Arnaldo Carvalho de Melo
2024-11-12 18:59 ` Ian Rogers
2024-11-12 19:17 ` Arnaldo Carvalho de Melo
2024-11-12 19:18 ` Arnaldo Carvalho de Melo
2024-11-12 19:18 ` Arnaldo Carvalho de Melo
2024-11-12 19:32 ` Arnaldo Carvalho de Melo
2024-11-12 19:56 ` Arnaldo Carvalho de Melo
2024-11-12 20:03 ` Howard Chu
2024-11-16 14:42 ` Howard Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108204137.2444151-9-howardchu95@gmail.com \
--to=howardchu95@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).