From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E7B08F49 for ; Sat, 9 Nov 2024 00:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731112444; cv=none; b=YlEajMQ68IBQwLNCWRlotHgLw6bOKorfZIf2hkHaiAVEC1GSjyQ87JN6n1KJzqzHKhFz1TR/mxDzSpIj0JYVQI9/jJOHCB+3t/zJ0j57L0au3Os2CelaSCmWYxuqmWXpDHCC57v37+IPtxbAQAy5v+Pr3NQaJcojoj5uYvCvyG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731112444; c=relaxed/simple; bh=V47dQdQkQL22+HC7w9YeCiv6RI21vZ8y6uGJAjPcFqE=; h=Date:Message-Id:Mime-Version:Subject:From:To:Content-Type; b=WOCZGVIBhBiPYt8YgRYhH3bLpApAa6IZcViwEte6VvhlEOBcrgeWdxHnhnPzplDHAbKXFeb7qOF/R0hIYP3NsPgv8dPnir61H7vgq1d9OgBO6s/Md+tCqIPL/sFw/FhCncaBbI/wVC/ai6L8+FYCbOCRKQLtNSVwmeXpg+MjMus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kX1AoFgo; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kX1AoFgo" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e29205f6063so4593304276.1 for ; Fri, 08 Nov 2024 16:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1731112442; x=1731717242; darn=vger.kernel.org; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=2ZEDYkxzsG0qUhyE9JYNgXfUbc0ZpS2I+xfFPhpZ/t0=; b=kX1AoFgo7L1T40YeDmg428jpA0R0DJlMUBBGOLF5yWCw6eG7caYDPL7m5mzC6u+x1b x8gTidsn1lPIdw626uNs/iPwWjC8hZS+bsEUtMfQcPmcCvIFx+Jd5DqmCCWDEvwy2/BV EF0zXH0Tjb9+5Wo5Y5j70SRrNkEap9N3nNKADMWu4G6/3W/1jG++9erqgswiT94nWK/T 8k4aXKWL0eeewwnL4U/6Czg06Uhh9qECHbo5aVCzA1bfrC4xDroYFkY7R6UohUzMktWO MaG6nO6T2ODObYpl56M2tvQSNqfWVUidGy6/q+qpu92UQG7Rfj+7eDyKKuIVLAl9Kann zSyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731112442; x=1731717242; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2ZEDYkxzsG0qUhyE9JYNgXfUbc0ZpS2I+xfFPhpZ/t0=; b=uSaZWcA7uJotMFhs/PGNBiO1BSH8WYuUnBYLEnoCiaPOikPblq0pNxszqrwVriwJhA L4bHmeZ0I17hJL96Re7/iccJInBITQ8LGXQ622tzncI489vdWx3uAxxXWMMQHnxWfT/b lreZ96qLntTCn2NqJRHiNeFkg7XM6j1N2UC18yXEY8T9vHssOMGeDg+RsZ2fEHC0coua mIqbvtEOHgHhwmqrVZF0Ed3ppH9OTV7k2VhsdYoTu4eA3ebPN9VJiILsDv7GBfV4+ItM wVrPEmKyCEh8zjhNGujrXlhv53r66l6VRCeGRc8CeCV+P3l91DdGP9n5SxrMo47ahA1q 7+zQ== X-Forwarded-Encrypted: i=1; AJvYcCUBIX9nVvDtS3gcoTzdmt8EhpBwD8EIxdQP93rC3eiqxLCC0BDpyW0LMgbdp6EQNLiLkjxLoaXD/xPCJZ2f09cF@vger.kernel.org X-Gm-Message-State: AOJu0Yx4Fb7ordCknKaII5yKIAqXGhnoTmv1RsBuo+EMDfmhPTQWaRrp 1jRDV5lDRQHiMRh/acQQRaI/dMQrcAW0N8e80U02CP0kFJH5AKuq5guX6VK5iiNWvGoAETPyXaW dIK0BZA== X-Google-Smtp-Source: AGHT+IGqdbWcUfasjGel99/viEVPGvhC8W4vacrG9Ai+t4388gVHqj3i/Sz9pa2KAfoWC9PzJ/JUopGKrcH5 X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:6fd2:1e36:6d8c:7c49]) (user=irogers job=sendgmr) by 2002:a25:d8d1:0:b0:e29:1893:f461 with SMTP id 3f1490d57ef6-e337f78051fmr12617276.0.1731112442088; Fri, 08 Nov 2024 16:34:02 -0800 (PST) Date: Fri, 8 Nov 2024 16:33:51 -0800 Message-Id: <20241109003358.461437-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.0.277.g8800431eea-goog Subject: [PATCH v8 0/7] Hwmon PMUs From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Ravi Bangoria , Weilin Wang , Yoshihiro Furudera , James Clark , Athira Jajeev , Howard Chu , Oliver Upton , Changbin Du , Ze Gao , Junhao He , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Following the convention of the tool PMU, create a hwmon PMU that exposes hwmon data for reading. For example, the following shows reading the CPU temperature and 2 fan speeds alongside the uncore frequency: ``` $ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000 1.001153138 52.00 'C temp_cpu 1.001153138 2,588 rpm fan1 1.001153138 2,482 rpm hwmon_thinkpad/fan2/ 1.001153138 8 tool/num_cpus_online/ 1.001153138 1,077,101,397 UNC_CLOCK.SOCKET # 1.08 UNCORE_FREQ 1.001153138 1,012,773,595 duration_time ... ``` Additional data on the hwmon events is in perf list: ``` $ perf list ... hwmon: ... temp_core_0 OR temp2 [Temperature in unit coretemp named Core 0. crit=100'C,max=100'C crit_alarm=0'C. Unit: hwmon_coretemp] ... ``` v8: Fix formatting issues and reduce scope of 2 strings reported by Namhyung. v7: Try to address feedback from Namhyung wrt size/comprehensibility of the hwmon PMU patch. To better explain the config encoding put the parser into a patch ahead of the PMU patch and add a unit test. This shows how a hwmon filename can be moved back-and-forth with a config value as a single patch (two with the test). The hwmon PMU patch is then putting the wrapping around that for the pmus', parse_event's and evsel reading's benefit. The alternate approach of not caring about the mapping, name to config value, and using the evsel->name wasn't followed. In the tool PMU it was made so we can go back-and-forth between event names and a type+config, this removed the tool enum value from the evsel as now tool events were more 1st class and evsel should really just be a wrapper on a perf_event_attr. Using the evsel->name wasn't doing that and so the approach of mapping filenames and configs, as better highlighted in this series was pursued. It is expected future PMUs won't be able to cleanly map fixed strings to config values, in those cases tables would be necessary. Making a hwmon PMU do this and then removing it to follow the parsing/mapping done in patch 2 here, would have been a lot of additional work which then would be removed. v6: Add string.h #include for issue reported by kernel test robot. v5: Fix asan issue in parse_hwmon_filename caught by a TMA metric. v4: Drop merged patches 1 to 10. Separate adding the hwmon_pmu from the update to perf_pmu to use it. Try to make source of literal strings clearer via named #defines. Fix a number of GCC warnings. v3: Rebase, add Namhyung's acked-by to patches 1 to 10. v2: Address Namhyung's review feedback. Rebase dropping 4 patches applied by Arnaldo, fix build breakage reported by Arnaldo. Ian Rogers (7): tools api io: Ensure line_len_out is always initialized perf hwmon_pmu: Add hwmon filename parser perf test: Add hwmon filename parser test perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs perf pmu: Add calls enabling the hwmon_pmu perf test: Add hwmon "PMU" test perf docs: Document tool and hwmon events tools/lib/api/io.h | 1 + tools/perf/Documentation/perf-list.txt | 15 + tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 1 + tools/perf/tests/hwmon_pmu.c | 340 ++++++++++ tools/perf/tests/tests.h | 1 + tools/perf/util/Build | 1 + tools/perf/util/evsel.c | 9 + tools/perf/util/hwmon_pmu.c | 826 +++++++++++++++++++++++++ tools/perf/util/hwmon_pmu.h | 156 +++++ tools/perf/util/pmu.c | 20 + tools/perf/util/pmu.h | 2 + tools/perf/util/pmus.c | 9 + tools/perf/util/pmus.h | 3 + 14 files changed, 1385 insertions(+) create mode 100644 tools/perf/tests/hwmon_pmu.c create mode 100644 tools/perf/util/hwmon_pmu.c create mode 100644 tools/perf/util/hwmon_pmu.h -- 2.47.0.277.g8800431eea-goog