From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Howard Chu <howardchu95@gmail.com>,
Athira Jajeev <atrajeev@linux.vnet.ibm.com>,
Michael Petlan <mpetlan@redhat.com>,
Veronika Molnarova <vmolnaro@redhat.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Colin Ian King <colin.i.king@gmail.com>,
Weilin Wang <weilin.wang@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v6 00/22] Python module cleanup
Date: Fri, 8 Nov 2024 22:17:47 -0800 [thread overview]
Message-ID: <20241109061809.811922-1-irogers@google.com> (raw)
This patch:
- removes workarounds for Python 2 module support due to long
deprecation and challenges in developing new code;
- constifies variables and parameters to functions;
- removes python.c stub code which existed due to missing functions
that are defined in the builtin-* files, in general the builtin-*
code is moved into util;
- remove bench and test perf C code from the python module;
- adds parse_events to the python perf module.
- improves upon some of the existing python perf module functins.
v6. Rebase. When moving find_scripts, separate the switch to using
is_directory_at into a patch before moving the function,
Arnaldo/Namhyung. Add acked/tested tags from Arnaldo and Adrian.
v5. Rebase. Fix NO_LIBBPF and NO_AUXTRACE related build failures
caught by Arnaldo and the build-test. Fix NO_AUXTRACE x86
arch_fetch_insn in the process, which was incorrectly using an
empty weak symbol stub.
v4. Rebase. Fix the parse events evsel to be embedded in a
pyrf_evsel. Add __str__/__repr__ functions to evlist and
evsel. Throw an exception for a bad evlist index.
v3. Move is_directory_at to patch 6 rather than patch 7, respond to
review feedback on the list from Namhyung.
v2. Add the bottom 4 bullet points - 13 more patches.
Ian Rogers (22):
perf python: Remove python 2 scripting support
perf python: Constify variables and parameters
perf python: Remove unused #include
perf script: Move scripting_max_stack out of builtin
perf kvm: Move functions used in util out of builtin
perf script: Use openat for directory iteration
perf script: Move find_scripts to browser/scripts.c
perf stat: Move stat_config into config.c
perf script: Move script_spec code to trace-event-scripting.c
perf script: Move script_fetch_insn to trace-event-scripting.c
perf script: Move perf_sample__sprintf_flags to
trace-event-scripting.c
perf x86: Define arch_fetch_insn in NO_AUXTRACE builds
perf intel-pt: Remove stale build comment
perf env: Move arch errno function to only use in env
perf lock: Move common lock contention code to new file
perf bench: Remove reference to cmd_inject
perf kwork: Make perf_kwork_add_work a callback
perf build: Remove test library from python shared object
perf python: Add parse_events function
perf python: Add __str__ and __repr__ functions to evlist
perf python: Add __str__ and __repr__ functions to evsel
perf python: Correctly throw IndexError
tools/perf/Makefile.perf | 7 +-
tools/perf/arch/x86/util/Build | 2 +-
tools/perf/bench/inject-buildid.c | 13 +-
tools/perf/builtin-kvm.c | 61 ----
tools/perf/builtin-kwork.c | 3 +-
tools/perf/builtin-lock.c | 137 +------
tools/perf/builtin-script.c | 304 +---------------
tools/perf/builtin-stat.c | 27 --
tools/perf/builtin-trace.c | 1 -
tools/perf/builtin.h | 6 -
.../scripts/python/Perf-Trace-Util/Context.c | 20 +-
tools/perf/tests/stat.c | 16 +-
tools/perf/trace/beauty/arch_errno_names.sh | 3 +-
tools/perf/ui/browsers/scripts.c | 177 ++++++++-
tools/perf/util/Build | 4 +-
tools/perf/util/bpf_kwork.c | 2 +-
tools/perf/util/bpf_kwork_top.c | 2 +-
tools/perf/util/bpf_lock_contention.c | 2 +-
tools/perf/util/cgroup.c | 2 +-
tools/perf/util/config.c | 27 ++
tools/perf/util/dlfilter.c | 3 +-
tools/perf/util/env.c | 4 +
tools/perf/util/env.h | 2 -
tools/perf/util/evsel.c | 19 +-
tools/perf/util/evsel.h | 2 +-
tools/perf/util/intel-pt-decoder/Build | 18 +-
.../intel-pt-decoder/intel-pt-insn-decoder.c | 3 -
tools/perf/util/kvm-stat.c | 70 ++++
tools/perf/util/kvm-stat.h | 3 +
tools/perf/util/kwork.h | 6 +-
tools/perf/util/lock-contention.c | 170 +++++++++
tools/perf/util/lock-contention.h | 37 +-
tools/perf/util/path.c | 10 +
tools/perf/util/path.h | 1 +
tools/perf/util/python.c | 341 ++++++++----------
.../scripting-engines/trace-event-python.c | 63 +---
tools/perf/util/stat.h | 3 +-
tools/perf/util/trace-event-scripting.c | 177 +++++++++
tools/perf/util/trace-event.h | 5 +-
39 files changed, 872 insertions(+), 881 deletions(-)
create mode 100644 tools/perf/util/kvm-stat.c
create mode 100644 tools/perf/util/lock-contention.c
--
2.47.0.277.g8800431eea-goog
next reply other threads:[~2024-11-09 6:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 6:17 Ian Rogers [this message]
2024-11-09 6:17 ` [PATCH v6 01/22] perf python: Remove python 2 scripting support Ian Rogers
2024-11-09 6:17 ` [PATCH v6 02/22] perf python: Constify variables and parameters Ian Rogers
2024-11-09 6:17 ` [PATCH v6 03/22] perf python: Remove unused #include Ian Rogers
2024-11-09 6:17 ` [PATCH v6 04/22] perf script: Move scripting_max_stack out of builtin Ian Rogers
2024-11-09 6:17 ` [PATCH v6 05/22] perf kvm: Move functions used in util " Ian Rogers
2024-11-09 6:17 ` [PATCH v6 06/22] perf script: Use openat for directory iteration Ian Rogers
2024-11-19 0:25 ` Namhyung Kim
2024-11-09 6:17 ` [PATCH v6 07/22] perf script: Move find_scripts to browser/scripts.c Ian Rogers
2024-11-19 0:26 ` Namhyung Kim
2024-11-09 6:17 ` [PATCH v6 08/22] perf stat: Move stat_config into config.c Ian Rogers
2024-11-09 6:17 ` [PATCH v6 09/22] perf script: Move script_spec code to trace-event-scripting.c Ian Rogers
2024-11-09 6:17 ` [PATCH v6 10/22] perf script: Move script_fetch_insn " Ian Rogers
2024-11-09 6:17 ` [PATCH v6 11/22] perf script: Move perf_sample__sprintf_flags " Ian Rogers
2024-11-09 6:17 ` [PATCH v6 12/22] perf x86: Define arch_fetch_insn in NO_AUXTRACE builds Ian Rogers
2024-11-09 6:18 ` [PATCH v6 13/22] perf intel-pt: Remove stale build comment Ian Rogers
2024-11-09 6:18 ` [PATCH v6 14/22] perf env: Move arch errno function to only use in env Ian Rogers
2024-11-09 6:18 ` [PATCH v6 15/22] perf lock: Move common lock contention code to new file Ian Rogers
2024-11-19 0:23 ` Namhyung Kim
2024-11-19 1:03 ` Ian Rogers
2024-11-19 17:00 ` Namhyung Kim
2024-11-19 17:21 ` Ian Rogers
2024-11-09 6:18 ` [PATCH v6 16/22] perf bench: Remove reference to cmd_inject Ian Rogers
2024-11-09 6:18 ` [PATCH v6 17/22] perf kwork: Make perf_kwork_add_work a callback Ian Rogers
2024-11-09 6:18 ` [PATCH v6 18/22] perf build: Remove test library from python shared object Ian Rogers
2024-11-09 6:18 ` [PATCH v6 19/22] perf python: Add parse_events function Ian Rogers
2024-11-09 6:18 ` [PATCH v6 20/22] perf python: Add __str__ and __repr__ functions to evlist Ian Rogers
2024-11-09 6:18 ` [PATCH v6 21/22] perf python: Add __str__ and __repr__ functions to evsel Ian Rogers
2024-11-09 6:18 ` [PATCH v6 22/22] perf python: Correctly throw IndexError Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109061809.811922-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=colin.i.king@gmail.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=howardchu95@gmail.com \
--cc=iii@linux.ibm.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
--cc=vmolnaro@redhat.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).