From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25ED986350; Tue, 10 Dec 2024 20:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733862005; cv=none; b=RbN7vPECj7yWfO6I0Xrf5kMs4vBMl8JTqWkCFAe74dN3JDnZNOUOLck6u9QlFd1lnHowoPukVrCnEpjukXmJR10vcUZ3ufrdHGb/COqwE7dLb9gWFLOFaEP0jwYCAu5uqq3qvGsQyqBuDQ4ijWwFnISzYsy+YCOnFqC9AhcNxRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733862005; c=relaxed/simple; bh=QuvlPEfuI08Zfl7OY+g6c4LJQzeO/J17GsTwpq4H5+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l2+1b9QHJTpwou7aNPQhFjpyPuM/1LaMphAzjWqZW+BlUal4cXba+SgP2WXhTjlJiMxBmTcsCbtBb8/C8HJdxmaRPBwIpfybuu8R/aKbzlekIpEoDET/S6ckldBrGthwO+2HnecL5LGljfpUHTwOmvqH9GY6yeYP70u5LBFCPxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04E7C1063; Tue, 10 Dec 2024 12:20:30 -0800 (PST) Received: from localhost (e132581.arm.com [10.2.76.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A6223F5A1; Tue, 10 Dec 2024 12:20:01 -0800 (PST) Date: Tue, 10 Dec 2024 20:19:59 +0000 From: Leo Yan To: Andrii Nakryiko Cc: Quentin Monnet , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Nick Terrell , bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Mahe Tardy Subject: Re: [PATCH] bpftool: Fix failure with static linkage Message-ID: <20241210201959.GA144421@e132581.arm.com> References: <20241204213059.2792453-1-leo.yan@arm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Andrii, On Tue, Dec 10, 2024 at 10:26:22AM -0800, Andrii Nakryiko wrote: [...] > > The tricky part is that static linkage works well without libzstd for > > older versions of elfutils [1], but newer versions now require this > > library. Which means that we don't want to link against libzstd > > unconditionally, or users trying to build bpftool may have to install > > unnecessary dependencies. Instead we should add a new probe under > > tools/build/feature (Note that we already have several combinations in > > there, libbfd, libbfd-liberty, libbfd-liberty-z, and I'm not sure what's > > the best approach in terms of new combinations). > > > > So what's the conclusion here? Do we apply this as a fix, or someone > needs to add more feature probing? I am working on a new build feature. Based on that, it will refine for perf build and bpftool build. Once get ready, I will send out for review. Thanks, Leo