public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Quentin Monnet <qmo@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Nick Terrell <terrelln@fb.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	James Clark <james.clark@linaro.org>,
	Guilherme Amadio <amadio@gentoo.org>,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	linux-perf-users@vger.kernel.org
Cc: Leo Yan <leo.yan@arm.com>
Subject: [PATCH v3 0/3] bpftool: Fix the static linkage failure
Date: Sun, 15 Dec 2024 22:12:20 +0000	[thread overview]
Message-ID: <20241215221223.293205-1-leo.yan@arm.com> (raw)

This series follows up on the discussion in [1] for fixing the static
linkage issue in bpftool.

Patch 01 introduces a new feature for libelf-zstd.  If this feature
is detected, it means the zstd lib is required by libelf.

Patch 02 is a minor improvement for linking the zstd lib in the perf.

Patch 03 fixes the static build failure by linking the zstd lib when
the feature-libelf-zstd is detected.

[1] https://lore.kernel.org/linux-perf-users/Z1H9-9xrWM4FBbNI@mini-arch/T/#m2300b127424e9e2ace7da497a20d88534eb6866f

Changes from v2:
- Refined commit log in patch 01 for recording info that from which
  libelf version it requires to link libzstd. (Quentin)
- Removed to display feature 'libelf-zstd' in bpftool. (Quentin)
- Added Test and Ack tags. Thanks all! (Quentin/Jiri/Namhyung/Andrii)


Leo Yan (3):
  tools build: Add feature test for libelf with ZSTD
  perf: build: Minor improvement for linking libzstd
  bpftool: Link zstd lib required by libelf

 tools/bpf/bpftool/Makefile             | 7 +++++++
 tools/build/Makefile.feature           | 1 +
 tools/build/feature/Makefile           | 4 ++++
 tools/build/feature/test-all.c         | 4 ++++
 tools/build/feature/test-libelf-zstd.c | 9 +++++++++
 tools/perf/Makefile.config             | 8 +++++++-
 6 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 tools/build/feature/test-libelf-zstd.c

-- 
2.34.1


             reply	other threads:[~2024-12-15 22:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-15 22:12 Leo Yan [this message]
2024-12-15 22:12 ` [PATCH v3 1/3] tools build: Add feature test for libelf with ZSTD Leo Yan
2024-12-15 22:12 ` [PATCH v3 2/3] perf: build: Minor improvement for linking libzstd Leo Yan
2024-12-15 22:12 ` [PATCH v3 3/3] bpftool: Link zstd lib required by libelf Leo Yan
2024-12-16 11:23   ` Quentin Monnet
2024-12-16 16:30     ` Leo Yan
2024-12-16 21:06       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241215221223.293205-1-leo.yan@arm.com \
    --to=leo.yan@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=amadio@gentoo.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=namhyung@kernel.org \
    --cc=qmo@kernel.org \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=terrelln@fb.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox