From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Sun Haiyong <sunhaiyong@loongson.cn>,
Yanteng Si <siyanteng@loongson.cn>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] perf record: Assert synthesized events are 8-byte aligned
Date: Sun, 15 Dec 2024 17:46:37 -0800 [thread overview]
Message-ID: <20241216014637.304761-5-irogers@google.com> (raw)
In-Reply-To: <20241216014637.304761-1-irogers@google.com>
Capture that events are 8-byte aligned and avoid later misaligned
event problems.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-record.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index adbaf80b398c..a5689d0e93ad 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -624,7 +624,10 @@ static int process_synthesized_event(const struct perf_tool *tool,
struct machine *machine __maybe_unused)
{
struct record *rec = container_of(tool, struct record, tool);
- return record__write(rec, NULL, event, event->header.size);
+ size_t size = event->header.size;
+
+ assert(PERF_ALIGN(size, sizeof(u64)) == size);
+ return record__write(rec, NULL, event, size);
}
static struct mutex synth_lock;
--
2.47.1.613.gc27f4b7a9f-goog
prev parent reply other threads:[~2024-12-16 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 1:46 [PATCH v2 0/4] perf file align features, avoid UB Ian Rogers
2024-12-16 1:46 ` [PATCH v2 1/4] perf header: Write out even empty die_cpus_list Ian Rogers
2024-12-16 16:56 ` Ian Rogers
2024-12-16 1:46 ` [PATCH v2 2/4] perf synthetic-events: Ensure features are aligned Ian Rogers
2024-12-16 1:46 ` [PATCH v2 3/4] perf machine: Avoid UB by delaying computing branch entries Ian Rogers
2024-12-16 1:46 ` Ian Rogers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216014637.304761-5-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=siyanteng@loongson.cn \
--cc=sunhaiyong@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox