From: James Clark <james.clark@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, irogers@google.com,
yeoreum.yun@arm.com, will@kernel.org, mark.rutland@arm.com,
namhyung@kernel.org, acme@kernel.org
Cc: robh@kernel.org, James Clark <james.clark@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Graham Woodward <graham.woodward@arm.com>,
Michael Petlan <mpetlan@redhat.com>,
Veronika Molnarova <vmolnaro@redhat.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH v3 0/5] perf: arm_spe: Add format option for discard mode
Date: Wed, 8 Jan 2025 14:28:55 +0000 [thread overview]
Message-ID: <20250108142904.401139-1-james.clark@linaro.org> (raw)
Discard mode (Armv8.6) is a way to enable SPE related PMU events without
the overhead of recording any data. Add a format option, tests and docs
for it.
In theory we could make the driver drop calls to allocate the aux buffer
when discard mode is enabled. This would give a small memory saving,
but I think there is potential to interfere with any tools that don't
expect this so I left the aux allocation untouched. Even old tools that
don't know about discard mode will be able to use it because we publish
the format option. Not allocating the aux buffer will have to be added
to tools which I've done in Perf.
Tested on the FVP with SAMPLE_FEED_OP (0x812D):
$ perf stat -e armv8_pmuv3/event=0x812D/ -- true
Performance counter stats for 'true':
0 armv8_pmuv3/event=0x812D/
$ perf record -e arm_spe/discard/ -a -N -B --no-bpf-event -o - > /dev/null &
$ perf stat -e armv8_pmuv3/event=0x812D/ -- true
Performance counter stats for 'true':
17350 armv8_pmuv3/event=0x812D/
Changes since v2:
* Use existing SPE_PMU_FEAT_* mechanism (Will)
Changes since v1:
* Add a new section and some clarifications about the PMU events to
the docs. (Ian)
Applies to v6.13-rc6
James Clark (5):
perf: arm_spe: Add format option for discard mode
perf docs: arm_spe: Document new discard mode
perf tool: arm-spe: Pull out functions for aux buffer and tracking
setup
perf tool: arm-spe: Don't allocate buffer or tracking event in discard
mode
perf test: arm_spe: Add test for discard mode
drivers/perf/arm_spe_pmu.c | 22 ++++++
tools/perf/Documentation/perf-arm-spe.txt | 26 +++++++
tools/perf/arch/arm64/util/arm-spe.c | 90 +++++++++++++++--------
tools/perf/tests/shell/test_arm_spe.sh | 30 ++++++++
4 files changed, 136 insertions(+), 32 deletions(-)
--
2.34.1
next reply other threads:[~2025-01-08 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:28 James Clark [this message]
2025-01-08 14:28 ` [PATCH v3 1/5] perf: arm_spe: Add format option for discard mode James Clark
2025-01-08 20:16 ` Yeo Reum Yun
2025-01-08 14:28 ` [PATCH v3 2/5] perf docs: arm_spe: Document new " James Clark
2025-01-08 14:28 ` [PATCH v3 3/5] perf tool: arm-spe: Pull out functions for aux buffer and tracking setup James Clark
2025-01-08 14:28 ` [PATCH v3 4/5] perf tool: arm-spe: Don't allocate buffer or tracking event in discard mode James Clark
2025-01-08 14:29 ` [PATCH v3 5/5] perf test: arm_spe: Add test for " James Clark
2025-01-10 16:22 ` [PATCH v3 0/5] perf: arm_spe: Add format option " Will Deacon
2025-01-13 14:33 ` James Clark
2025-01-13 14:45 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2025-01-08 14:27 James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108142904.401139-1-james.clark@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=graham.woodward@arm.com \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=tmricht@linux.ibm.com \
--cc=vmolnaro@redhat.com \
--cc=will@kernel.org \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox