From: Lucas De Marchi <lucas.demarchi@intel.com>
To: <intel-xe@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
Riana Tauro <riana.tauro@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-perf-users@vger.kernel.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: [PATCH v14 0/7] drm/xe/pmu: PMU interface for Xe
Date: Tue, 21 Jan 2025 22:23:34 -0800 [thread overview]
Message-ID: <20250122062341.1100173-1-lucas.demarchi@intel.com> (raw)
Previous versions: https://patchwork.freedesktop.org/series/139121/
For perf/core: first patch adds a new macro in include/linux/perf_event.h.
If it's ok, I'd like to merge it through the drm branch so we can add the
pmu implementation to the xe driver. I'm also Cc'ing linux-perf-users@vger.kernel.org
on the other patches to show its usage.
For "drm/xe/pmu: Enable PMU interface", previously from several authors,
I squashed several changes I suggested in the past to clean it up and
reduce boilerplate code that resulted from copy-paste from i915. More
detailed changes can be found at
https://gitlab.freedesktop.org/demarchi/xe/-/tags/tip-xe-pmu-v13
Compared to v12 this only has 1 event as Vinay said he will rebase the
frequency event on top. I tested this on Lunar Lake and ADL with and
without workload running and the gt-c6 residency seems reasonable.
v14 simplifies the gt-c6 event: no more estimate based on suspend time
since we can't take the spinlock. A simpler version is to get runtime pm
when initializing the event and putting it back when it's done. In
future we can come back with fancier things that don´t block the runtime
pm.
Lucas De Marchi (5):
perf/core: Add PMU_EVENT_ATTR_ID_STRING
drm/xe/pmu: Assert max gt
drm/xe/pmu: Extract xe_pmu_event_update()
drm/xe/pmu: Add attribute skeleton
drm/xe/pmu: Get/put runtime pm on event init
Vinay Belgaumkar (2):
drm/xe/pmu: Enable PMU interface
drm/xe/pmu: Add GT C6 events
drivers/gpu/drm/xe/Makefile | 2 +
drivers/gpu/drm/xe/xe_device.c | 3 +
drivers/gpu/drm/xe/xe_device_types.h | 4 +
drivers/gpu/drm/xe/xe_pmu.c | 360 +++++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_pmu.h | 20 ++
drivers/gpu/drm/xe/xe_pmu_types.h | 47 ++++
include/linux/perf_event.h | 7 +-
7 files changed, 441 insertions(+), 2 deletions(-)
create mode 100644 drivers/gpu/drm/xe/xe_pmu.c
create mode 100644 drivers/gpu/drm/xe/xe_pmu.h
create mode 100644 drivers/gpu/drm/xe/xe_pmu_types.h
--
2.48.0
next reply other threads:[~2025-01-22 6:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 6:23 Lucas De Marchi [this message]
2025-01-22 6:23 ` [PATCH v14 1/7] perf/core: Add PMU_EVENT_ATTR_ID_STRING Lucas De Marchi
2025-02-22 12:42 ` Ingo Molnar
2025-01-22 6:23 ` [PATCH v14 2/7] drm/xe/pmu: Enable PMU interface Lucas De Marchi
2025-01-22 10:51 ` Riana Tauro
2025-01-22 15:31 ` Lucas De Marchi
2025-01-22 6:23 ` [PATCH v14 3/7] drm/xe/pmu: Assert max gt Lucas De Marchi
2025-01-22 6:23 ` [PATCH v14 4/7] drm/xe/pmu: Extract xe_pmu_event_update() Lucas De Marchi
2025-01-22 6:23 ` [PATCH v14 5/7] drm/xe/pmu: Add attribute skeleton Lucas De Marchi
2025-01-22 6:23 ` [PATCH v14 6/7] drm/xe/pmu: Get/put runtime pm on event init Lucas De Marchi
2025-01-22 10:26 ` Rodrigo Vivi
2025-01-22 6:23 ` [PATCH v14 7/7] drm/xe/pmu: Add GT C6 events Lucas De Marchi
2025-01-22 10:23 ` Riana Tauro
2025-01-22 10:32 ` Rodrigo Vivi
2025-01-23 0:11 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122062341.1100173-1-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox