From: Thomas Richter <tmricht@linux.ibm.com>
To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
acme@kernel.org, namhyung@kernel.org
Cc: agordeev@linux.ibm.com, gor@linux.ibm.com,
sumanthk@linux.ibm.com, hca@linux.ibm.com,
Thomas Richter <tmricht@linux.ibm.com>,
James Clark <james.clark@linaro.org>
Subject: [PATCH 1/2 v2] perf test: Fix perf test 114 perf record test subtest precise_max for s390
Date: Wed, 29 Jan 2025 08:11:33 +0100 [thread overview]
Message-ID: <20250129071134.4024430-1-tmricht@linux.ibm.com> (raw)
On s390 the event instructions can not be used for recording.
This event is only supported by perf stat.
Change the event instruction to cycles for subtest test_precise_max
as suggested by James Clark.
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Suggested-by: James Clark <james.clark@linaro.org>
---
tools/perf/tests/shell/record.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 0fc7a909ae9b..957ee10aff44 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -287,9 +287,9 @@ test_precise_max() {
return
fi
# On AMD, cycles and instructions events are treated differently
- if ! perf record -o "${perfdata}" -e "instructions:P" true 2> /dev/null
+ if ! perf record -o "${perfdata}" -e "cycles:P" true 2> /dev/null
then
- echo "precise_max attribute [Failed instructions:P event]"
+ echo "precise_max attribute [Failed cycles:P event]"
err=1
return
fi
--
2.48.1
next reply other threads:[~2025-01-29 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 7:11 Thomas Richter [this message]
2025-01-29 7:11 ` [PATCH 2/2 v2] perf test: Skip perf test 114 perf record test subtest test_leader_sampling for s390 Thomas Richter
2025-01-29 11:25 ` James Clark
2025-01-29 9:57 ` [PATCH 1/2 v2] perf test: Fix perf test 114 perf record test subtest precise_max " James Clark
2025-01-29 11:11 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129071134.4024430-1-tmricht@linux.ibm.com \
--to=tmricht@linux.ibm.com \
--cc=acme@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=james.clark@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sumanthk@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox