From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>
Subject: [PATCH] perf/core: move all of the pmu devices into their own location
Date: Mon, 3 Feb 2025 20:25:05 +0100 [thread overview]
Message-ID: <2025020304-chip-trench-4e56@gregkh> (raw)
In sysfs, for some reason, all pmu devices seem to show up in the "root"
of /sys/devices/ making for a confusing mess as these devices are not
really at the root of the system at all.
Create a fake root devices, "pmu_bus" and place them all under there if
they do not already have a parent device set, cleaning up sysfs to look
more sane.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Note, if you all don't like "pmu_bus" for the name, that's fine, please
let me know and I can rename it to something else, but it should be
something to get these objects out of the root sysfs directory.
kernel/events/core.c | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index bcb09e011e9e..786537faed2c 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -11767,6 +11767,11 @@ static const struct attribute_group *pmu_dev_groups[] = {
};
static int pmu_bus_running;
+
+static struct device pmu_bus_root = {
+ .init_name = "pmu_bus",
+};
+
static struct bus_type pmu_bus = {
.name = "event_source",
.dev_groups = pmu_dev_groups,
@@ -11790,7 +11795,10 @@ static int pmu_dev_alloc(struct pmu *pmu)
dev_set_drvdata(pmu->dev, pmu);
pmu->dev->bus = &pmu_bus;
- pmu->dev->parent = pmu->parent;
+ if (pmu->parent)
+ pmu->dev->parent = pmu->parent;
+ else
+ pmu->dev->parent = &pmu_bus_root;
pmu->dev->release = pmu_dev_release;
ret = dev_set_name(pmu->dev, "%s", pmu->name);
@@ -14232,9 +14240,17 @@ static int __init perf_event_sysfs_init(void)
mutex_lock(&pmus_lock);
- ret = bus_register(&pmu_bus);
- if (ret)
+ ret = device_register(&pmu_bus_root);
+ if (ret) {
+ put_device(&pmu_bus_root);
goto unlock;
+ }
+
+ ret = bus_register(&pmu_bus);
+ if (ret) {
+ device_unregister(&pmu_bus_root);
+ goto unlock;
+ }
list_for_each_entry(pmu, &pmus, entry) {
if (pmu->dev)
--
2.48.1
next reply other threads:[~2025-02-03 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 19:25 Greg Kroah-Hartman [this message]
2025-02-03 19:44 ` [PATCH] perf/core: move all of the pmu devices into their own location Ian Rogers
2025-02-04 7:05 ` Greg Kroah-Hartman
2025-02-04 18:17 ` Ian Rogers
2025-02-05 5:41 ` Greg Kroah-Hartman
2025-02-05 16:48 ` Ian Rogers
2025-02-05 18:45 ` Greg Kroah-Hartman
2025-02-04 7:41 ` Alexander Shishkin
2025-02-04 10:16 ` Greg Kroah-Hartman
2025-02-04 14:06 ` Liang, Kan
2025-02-04 15:21 ` Greg Kroah-Hartman
2025-02-04 16:28 ` Greg Kroah-Hartman
2025-02-04 16:41 ` Vince Weaver
2025-02-04 17:12 ` Greg Kroah-Hartman
2025-02-04 17:49 ` Ian Rogers
2025-02-04 18:03 ` Greg Kroah-Hartman
2025-02-05 1:21 ` Vince Weaver
2025-02-05 5:45 ` Greg Kroah-Hartman
2025-02-05 15:06 ` Vince Weaver
2025-02-05 15:36 ` Greg Kroah-Hartman
2025-02-04 18:23 ` Liang, Kan
2025-02-05 16:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025020304-chip-trench-4e56@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).