From: Leo Yan <leo.yan@arm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Jonathan Corbet <corbet@lwn.net>, Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
James Clark <james.clark@linaro.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v19 11/11] perf: arm_pmuv3: Add support for the Branch Record Buffer Extension (BRBE)
Date: Wed, 12 Feb 2025 19:00:05 +0000 [thread overview]
Message-ID: <20250212190005.GD235556@e132581.arm.com> (raw)
In-Reply-To: <20250212185227.GC235556@e132581.arm.com>
On Wed, Feb 12, 2025 at 06:52:27PM +0000, Leo Yan wrote:
[...]
> > +static int brbinf_get_mispredict(u64 brbinf)
> > +{
> > + return FIELD_GET(BRBINFx_EL1_MPRED_MASK, brbinf);
> > +}
>
> I would expect the naming of brbinf_get_mispredict() will cause
> confusion. When the function returns 1, it means "Branch was
> incorrectly predicted".
>
> Maybe consider to use '!FIELD_GET(...)' for a reversed value?
Please ignore this comment. Sorry for my misreading and noise.
next prev parent reply other threads:[~2025-02-12 19:00 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 0:42 [PATCH v19 00/11] arm64/perf: Enable branch stack sampling Rob Herring (Arm)
2025-02-03 0:42 ` [PATCH v19 01/11] perf: arm_pmuv3: Call kvm_vcpu_pmu_resync_el0() before enabling counters Rob Herring (Arm)
2025-02-03 4:07 ` Anshuman Khandual
2025-02-03 0:42 ` [PATCH v19 02/11] perf: arm_pmu: Don't disable counter in armpmu_add() Rob Herring (Arm)
2025-02-03 6:04 ` Anshuman Khandual
2025-02-03 0:42 ` [PATCH v19 03/11] perf: arm_pmuv3: Don't disable counter in armv8pmu_enable_event() Rob Herring (Arm)
2025-02-03 6:38 ` Anshuman Khandual
2025-02-03 0:42 ` [PATCH v19 04/11] perf: arm_v7_pmu: Drop obvious comments for enabling/disabling counters and interrupts Rob Herring (Arm)
2025-02-03 4:09 ` Anshuman Khandual
2025-02-03 0:42 ` [PATCH v19 05/11] perf: arm_v7_pmu: Don't disable counter in (armv7|krait_|scorpion_)pmu_enable_event() Rob Herring (Arm)
2025-02-03 6:54 ` Anshuman Khandual
2025-02-03 0:43 ` [PATCH v19 06/11] perf: apple_m1: Don't disable counter in m1_pmu_enable_event() Rob Herring (Arm)
2025-02-03 8:10 ` Anshuman Khandual
2025-02-03 0:43 ` [PATCH v19 07/11] perf: arm_pmu: Move PMUv3-specific data Rob Herring (Arm)
2025-02-03 8:16 ` Anshuman Khandual
2025-02-03 0:43 ` [PATCH v19 08/11] arm64/sysreg: Add BRBE registers and fields Rob Herring (Arm)
2025-02-03 8:32 ` Anshuman Khandual
2025-02-03 0:43 ` [PATCH v19 09/11] arm64: Handle BRBE booting requirements Rob Herring (Arm)
2025-02-03 8:47 ` Anshuman Khandual
2025-02-12 12:10 ` Leo Yan
2025-02-12 21:21 ` Rob Herring
2025-02-13 12:27 ` Leo Yan
2025-02-03 0:43 ` [PATCH v19 10/11] KVM: arm64: nvhe: Disable branch generation in nVHE guests Rob Herring (Arm)
2025-02-03 9:16 ` Anshuman Khandual
2025-02-03 11:28 ` James Clark
2025-02-13 17:03 ` Leo Yan
2025-02-13 23:16 ` Rob Herring
2025-02-14 9:55 ` Leo Yan
2025-02-18 14:17 ` Rob Herring
2025-02-03 0:43 ` [PATCH v19 11/11] perf: arm_pmuv3: Add support for the Branch Record Buffer Extension (BRBE) Rob Herring (Arm)
2025-02-03 16:53 ` James Clark
2025-02-03 17:58 ` Rob Herring
2025-02-04 12:02 ` James Clark
2025-02-04 15:03 ` Rob Herring
2025-02-05 14:38 ` James Clark
2025-02-05 14:51 ` James Clark
2025-02-05 16:15 ` Rob Herring
2025-02-06 12:58 ` James Clark
2025-02-12 18:52 ` Leo Yan
2025-02-12 19:00 ` Leo Yan [this message]
2025-02-13 16:16 ` Leo Yan
2025-02-13 17:13 ` Rob Herring
2025-02-13 17:45 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212190005.GD235556@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=james.clark@linaro.org \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).