From: Howard Chu <howardchu95@gmail.com>
To: acme@kernel.org
Cc: namhyung@kernel.org, jolsa@kernel.org, irogers@google.com,
adrian.hunter@intel.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, Howard Chu <howardchu95@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
James Clark <james.clark@linaro.org>,
Kan Liang <kan.liang@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH v15 06/10] perf record --off-cpu: Disable perf_event's callchain collection
Date: Thu, 13 Feb 2025 15:00:05 -0800 [thread overview]
Message-ID: <20250213230009.1450907-7-howardchu95@gmail.com> (raw)
In-Reply-To: <20250213230009.1450907-1-howardchu95@gmail.com>
There is a check in evsel.c that does this:
if (evsel__is_offcpu_event(evsel))
evsel->core.attr.sample_type &= OFFCPU_SAMPLE_TYPES;
This along with:
#define OFFCPU_SAMPLE_TYPES (PERF_SAMPLE_IDENTIFIER | PERF_SAMPLE_IP | \
PERF_SAMPLE_TID | PERF_SAMPLE_TIME | \
PERF_SAMPLE_ID | PERF_SAMPLE_CPU | \
PERF_SAMPLE_PERIOD | PERF_SAMPLE_CALLCHAIN | \
PERF_SAMPLE_CGROUP)
will tell perf_event to collect callchain.
We don't need the callchain from perf_event when collecting off-cpu
samples, because it's prev's callchain, not next's callchain.
(perf_event) (task_storage) (needed)
prev next
| |
---sched_switch---->
Signed-off-by: Howard Chu <howardchu95@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20241108204137.2444151-8-howardchu95@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/off_cpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/off_cpu.h b/tools/perf/util/off_cpu.h
index 2dd67c60f211..2a4b7f9b2c4c 100644
--- a/tools/perf/util/off_cpu.h
+++ b/tools/perf/util/off_cpu.h
@@ -13,7 +13,7 @@ struct record_opts;
#define OFFCPU_SAMPLE_TYPES (PERF_SAMPLE_IDENTIFIER | PERF_SAMPLE_IP | \
PERF_SAMPLE_TID | PERF_SAMPLE_TIME | \
PERF_SAMPLE_ID | PERF_SAMPLE_CPU | \
- PERF_SAMPLE_PERIOD | PERF_SAMPLE_CALLCHAIN | \
+ PERF_SAMPLE_PERIOD | PERF_SAMPLE_RAW | \
PERF_SAMPLE_CGROUP)
--
2.45.2
next prev parent reply other threads:[~2025-02-13 23:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 22:59 [PATCH v15 00/10] perf record --off-cpu: Dump off-cpu samples directly Howard Chu
2025-02-13 23:00 ` [PATCH v15 01/10] perf evsel: Expose evsel__is_offcpu_event() for future use Howard Chu
2025-02-13 23:00 ` [PATCH v15 02/10] perf record --off-cpu: Parse off-cpu event Howard Chu
2025-02-13 23:00 ` [PATCH v15 03/10] perf record --off-cpu: Preparation of off-cpu BPF program Howard Chu
2025-02-13 23:00 ` [PATCH v15 04/10] perf record --off-cpu: Dump off-cpu samples in BPF Howard Chu
2025-02-13 23:00 ` [PATCH v15 05/10] perf evsel: Assemble offcpu samples Howard Chu
2025-02-13 23:00 ` Howard Chu [this message]
2025-02-13 23:00 ` [PATCH v15 07/10] perf script: Display off-cpu samples correctly Howard Chu
2025-02-13 23:00 ` [PATCH v15 08/10] perf record --off-cpu: Dump the remaining samples in BPF's stack trace map Howard Chu
2025-02-13 23:00 ` [PATCH v15 09/10] perf record --off-cpu: Add --off-cpu-thresh option Howard Chu
2025-02-13 23:00 ` [PATCH v15 10/10] perf test: Add direct off-cpu test Howard Chu
2025-02-13 23:04 ` Howard Chu
2025-02-18 19:32 ` Ian Rogers
2025-02-19 0:58 ` Howard Chu
2025-02-28 16:36 ` [PATCH v15 00/10] perf record --off-cpu: Dump off-cpu samples directly Gautam Menghani
2025-02-28 17:40 ` Howard Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213230009.1450907-7-howardchu95@gmail.com \
--to=howardchu95@gmail.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).