From: linux@treblig.org
To: irogers@google.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
adrian.hunter@intel.com, kan.liang@linux.intel.com,
namhyung@kernel.org
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 5/6] perf util: Remove unused perf_pmus__default_pmu_name
Date: Wed, 5 Mar 2025 02:31:19 +0000 [thread overview]
Message-ID: <20250305023120.155420-6-linux@treblig.org> (raw)
In-Reply-To: <20250305023120.155420-1-linux@treblig.org>
From: "Dr. David Alan Gilbert" <linux@treblig.org>
perf_pmus__default_pmu_name() last use was removed by 2023's
commit e3edd6cf6399 ("perf pmu-events: Reduce processed events by passing
PMU")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
tools/perf/util/pmus.c | 29 -----------------------------
tools/perf/util/pmus.h | 1 -
2 files changed, 30 deletions(-)
diff --git a/tools/perf/util/pmus.c b/tools/perf/util/pmus.c
index dd7c2ffdab38..9b5a63ecb249 100644
--- a/tools/perf/util/pmus.c
+++ b/tools/perf/util/pmus.c
@@ -714,35 +714,6 @@ bool perf_pmus__supports_extended_type(void)
return perf_pmus__do_support_extended_type;
}
-char *perf_pmus__default_pmu_name(void)
-{
- int fd;
- struct io_dir dir;
- struct io_dirent64 *dent;
- char *result = NULL;
-
- if (!list_empty(&core_pmus))
- return strdup(list_first_entry(&core_pmus, struct perf_pmu, list)->name);
-
- fd = perf_pmu__event_source_devices_fd();
- if (fd < 0)
- return strdup("cpu");
-
- io_dir__init(&dir, fd);
-
- while ((dent = io_dir__readdir(&dir)) != NULL) {
- if (!strcmp(dent->d_name, ".") || !strcmp(dent->d_name, ".."))
- continue;
- if (is_pmu_core(dent->d_name)) {
- result = strdup(dent->d_name);
- break;
- }
- }
-
- close(fd);
- return result ?: strdup("cpu");
-}
-
struct perf_pmu *evsel__find_pmu(const struct evsel *evsel)
{
struct perf_pmu *pmu = evsel->pmu;
diff --git a/tools/perf/util/pmus.h b/tools/perf/util/pmus.h
index a0cb0eb2ff97..8def20e615ad 100644
--- a/tools/perf/util/pmus.h
+++ b/tools/perf/util/pmus.h
@@ -27,7 +27,6 @@ void perf_pmus__print_raw_pmu_events(const struct print_callbacks *print_cb, voi
bool perf_pmus__have_event(const char *pname, const char *name);
int perf_pmus__num_core_pmus(void);
bool perf_pmus__supports_extended_type(void);
-char *perf_pmus__default_pmu_name(void);
struct perf_pmu *perf_pmus__add_test_pmu(int test_sysfs_dirfd, const char *name);
struct perf_pmu *perf_pmus__add_test_hwmon_pmu(int hwmon_dir,
--
2.48.1
next prev parent reply other threads:[~2025-03-05 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 2:31 [PATCH 0/6] perf: Deadcode - the P's linux
2025-03-05 2:31 ` [PATCH 1/6] perf core: Remove perf_event_attrs and perf_event_refresh linux
2025-03-05 2:31 ` [PATCH 2/6] perf util: Remove unused perf_color_default_config linux
2025-03-05 2:31 ` [PATCH 3/6] perf util: Remove unused pstack__pop linux
2025-03-05 2:31 ` [PATCH 4/6] perf util: Remove unused perf_data__update_dir linux
2025-03-05 2:31 ` linux [this message]
2025-03-05 2:31 ` [PATCH 6/6] perf util: Remove unused perf_config__refresh linux
2025-03-06 7:17 ` [PATCH 0/6] perf: Deadcode - the P's Ian Rogers
2025-03-06 13:13 ` Dr. David Alan Gilbert
2025-03-11 16:11 ` (subset) " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305023120.155420-6-linux@treblig.org \
--to=linux@treblig.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).