From: Leo Yan <leo.yan@arm.com>
To: Yujie Liu <yujie.liu@intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Graham Woodward <graham.woodward@arm.com>,
Paschalis.Mpeis@arm.com
Subject: Re: [PATCH] perf script: Fix typo in branch event mask
Date: Wed, 12 Mar 2025 09:56:57 +0000 [thread overview]
Message-ID: <20250312095657.GM9682@e132581.arm.com> (raw)
In-Reply-To: <20250312075636.429127-1-yujie.liu@intel.com>
On Wed, Mar 12, 2025 at 03:56:36PM +0800, Yujie Liu wrote:
> BRACH -> BRANCH
>
> Fixes: 88b1473135e4 ("perf script: Separate events from branch types")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
Reviewed-by: Leo Yan <leo.yan@arm.com>
> ---
> tools/perf/util/event.h | 2 +-
> tools/perf/util/trace-event-scripting.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
> index c7f4b4b841ca..664bf39567ce 100644
> --- a/tools/perf/util/event.h
> +++ b/tools/perf/util/event.h
> @@ -91,7 +91,7 @@ enum {
> PERF_IP_FLAG_VMENTRY |\
> PERF_IP_FLAG_VMEXIT)
>
> -#define PERF_IP_FLAG_BRACH_EVENT_MASK \
> +#define PERF_IP_FLAG_BRANCH_EVENT_MASK \
> (PERF_IP_FLAG_BRANCH_MISS | \
> PERF_IP_FLAG_NOT_TAKEN)
>
> diff --git a/tools/perf/util/trace-event-scripting.c b/tools/perf/util/trace-event-scripting.c
> index 29cc467be14a..72abb28b7b5a 100644
> --- a/tools/perf/util/trace-event-scripting.c
> +++ b/tools/perf/util/trace-event-scripting.c
> @@ -347,7 +347,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
>
> flags &= ~(PERF_IP_FLAG_TRACE_BEGIN | PERF_IP_FLAG_TRACE_END);
>
> - types = flags & ~PERF_IP_FLAG_BRACH_EVENT_MASK;
> + types = flags & ~PERF_IP_FLAG_BRANCH_EVENT_MASK;
> for (i = 0; sample_flags[i].name; i++) {
> if (sample_flags[i].flags != types)
> continue;
> @@ -359,7 +359,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
> break;
> }
>
> - events = flags & PERF_IP_FLAG_BRACH_EVENT_MASK;
> + events = flags & PERF_IP_FLAG_BRANCH_EVENT_MASK;
> for (i = 0; branch_events[i].name; i++) {
> if (!(branch_events[i].flags & events))
> continue;
>
> base-commit: b10f74308e1305275e69ddde711ec817cc69e306
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-03-12 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 7:56 [PATCH] perf script: Fix typo in branch event mask Yujie Liu
2025-03-12 9:56 ` Leo Yan [this message]
2025-03-12 10:02 ` James Clark
2025-03-14 17:43 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312095657.GM9682@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=Paschalis.Mpeis@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=graham.woodward@arm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).