From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Weilin Wang <weilin.wang@intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>,
John Garry <john.g.garry@oracle.com>,
Howard Chu <howardchu95@gmail.com>,
Levi Yun <yeoreum.yun@arm.com>,
Dominique Martinet <asmadeus@codewreck.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 05/14] perf intel-tpebs: Reduce scope of tpebs_events_size
Date: Mon, 24 Mar 2025 15:34:43 -0700 [thread overview]
Message-ID: <20250324223452.208081-6-irogers@google.com> (raw)
In-Reply-To: <20250324223452.208081-1-irogers@google.com>
Moved to record argument computation rather than being global.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/intel-tpebs.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c
index 13d70c6bd44b..e5ca58599b5f 100644
--- a/tools/perf/util/intel-tpebs.c
+++ b/tools/perf/util/intel-tpebs.c
@@ -28,7 +28,6 @@
#define PERF_DATA "-"
bool tpebs_recording;
-static size_t tpebs_event_size;
static LIST_HEAD(tpebs_results);
static pthread_t tpebs_reader_thread;
static struct child_process tpebs_cmd;
@@ -85,15 +84,20 @@ static int get_perf_record_args(const char **record_argv, char buf[],
static int evsel__tpebs_start_perf_record(struct evsel *evsel, int control_fd[], int ack_fd[])
{
const char **record_argv;
+ size_t tpebs_event_size = 0;
int ret;
char buf[32];
char cpumap_buf[50];
+ struct tpebs_retire_lat *t;
cpu_map__snprint(evsel->evlist->core.user_requested_cpus, cpumap_buf,
sizeof(cpumap_buf));
scnprintf(buf, sizeof(buf), "--control=fd:%d,%d", control_fd[0], ack_fd[1]);
+ list_for_each_entry(t, &tpebs_results, nd)
+ tpebs_event_size++;
+
record_argv = calloc(12 + 2 * tpebs_event_size, sizeof(char *));
if (!record_argv)
return -ENOMEM;
@@ -225,7 +229,6 @@ static struct tpebs_retire_lat *tpebs_retire_lat__new(struct evsel *evsel)
return NULL;
}
list_add_tail(&result->nd, &tpebs_results);
- tpebs_event_size++;
return result;
}
@@ -288,7 +291,7 @@ int evsel__tpebs_open(struct evsel *evsel)
if (ret)
return ret;
- if (tpebs_event_size > 0) {
+ if (!list_empty(&tpebs_results)) {
struct pollfd pollfd = { .events = POLLIN, };
int control_fd[2], ack_fd[2], len;
char ack_buf[8];
--
2.49.0.395.g12beb8f557-goog
next prev parent reply other threads:[~2025-03-24 22:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 22:34 [PATCH v1 00/14] Intel TPEBS min/max/mean/last support Ian Rogers
2025-03-24 22:34 ` [PATCH v1 01/14] perf intel-tpebs: Simplify tpebs_cmd Ian Rogers
2025-03-24 22:34 ` [PATCH v1 02/14] perf intel-tpebs: Rename tpebs_start to evsel__tpebs_open Ian Rogers
2025-03-24 22:34 ` [PATCH v1 03/14] perf intel-tpebs: Separate evsel__tpebs_prepare out of evsel__tpebs_open Ian Rogers
2025-03-24 22:34 ` [PATCH v1 04/14] perf intel-tpebs: Move cpumap_buf " Ian Rogers
2025-03-24 22:34 ` Ian Rogers [this message]
2025-03-24 22:34 ` [PATCH v1 06/14] perf intel-tpebs: Inline get_perf_record_args Ian Rogers
2025-03-24 22:34 ` [PATCH v1 07/14] perf intel-tpebs: Ensure events are opened, factor out finding Ian Rogers
2025-03-24 22:34 ` [PATCH v1 08/14] perf intel-tpebs: Refactor tpebs_results list Ian Rogers
2025-03-24 22:34 ` [PATCH v1 09/14] perf intel-tpebs: Add support for updating counts in evsel__tpebs_read Ian Rogers
2025-03-24 22:34 ` [PATCH v1 10/14] perf intel-tpebs: Add mutex for tpebs_results Ian Rogers
2025-03-24 22:34 ` [PATCH v1 11/14] perf intel-tpebs: Don't close record on read Ian Rogers
2025-03-24 22:34 ` [PATCH v1 12/14] perf intel-tpebs: Use stats for retirement latency statistics Ian Rogers
2025-03-24 22:34 ` [PATCH v1 13/14] perf stat: Add mean, min, max and last --tpebs-mode options Ian Rogers
2025-03-24 22:34 ` [PATCH v1 14/14] perf pmu-events: Add retirement latency to JSON events inside of perf Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324223452.208081-6-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).