From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 953C1220685 for ; Tue, 1 Apr 2025 18:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531919; cv=none; b=HVPqiDm0VQ0hf0a455iU38QohAZb6TUazuJeWWGYhy26W7bYNQkby2ZwEMs9H+KUoIvoXuYxsEqJcr6vsw/93a4vmFYRdAyzRWq5jrYnAPyk22OiHpQwu7qd23M3PsqTf0qM2pVWDkoYV6lFPWCARiCWyeWPL55SL+zJFIi80EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531919; c=relaxed/simple; bh=3ipXD9lA5krXojMgzTZJeNFbDoGDG3hIVLo9GFGHUwM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=QuCeStcn0Pr9Jp6koxc8m74QAw1Y/Tk8Y3JAZpHk4hj47EBIkLXBfLahdB5/as3NomaimLjxm2tcolYzP4dZc3Qlv9XJlHs3D17G5eHlegrb48i8ARSDNTG2Yi6+R/qn1cLA7osj20oCd/KkSjxNJNV+ZF9RP8DIPWgQ25H1vK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AVcGA6ZV; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AVcGA6ZV" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-30364fc706fso10157661a91.3 for ; Tue, 01 Apr 2025 11:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743531917; x=1744136717; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=qbFOgtsegWIP33hU2q1VfvbvAOcEKBmypAgL+fgEkks=; b=AVcGA6ZVORQ3ZCOyq2ThYmZfrRW33AvYDpM8Lq5jXeYMIiUtULtuREmCGtCjHtYKP0 kTSW/4SbRqKm42KRvB6ZKDG1dY1FAyikiMarp04ldKAsWXcjHmF1gIKqP2vb+b7H2Ws4 vzzomoqYT7+Oys5VmQ1DXXEmMjl3wihAfaxhUpMI9QflevBJX962stDv3AMq0t0oiTsJ ZsI2wWwpCq7iAd8SAe9e7qw35bzO5rLm4VUhOL6xw0PPIl8VkLztGhUpL6ShWxTw6qVt Rzxdex2fWoPlmH8yTvAb/1VzQrZJyzVFrrIkbM/GnDGRQ6gxT0+ByQxD0OF/8NYLX3HY D8kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743531917; x=1744136717; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qbFOgtsegWIP33hU2q1VfvbvAOcEKBmypAgL+fgEkks=; b=JSKYedH4aHx3gOgi6WNu3mcndaicN3orGNovmb5laRErlSfNdHzwWRj0kR/UvTCFdO U+z4kPYCqMURBxm19E4C4940ZaNhg/ygQvdbWqINtcH/xRxhuR35kwiwb8yoIIKv+q3L xPSJsQIBr+/tfRaJmVWUx1IgjF0Cb+juqXpy8VPVdOiQ6YsUZ+ZN3oZ9qeNdFeE1b3Ar /OyTmanID8MlrtxcgL7J1yL92jR1An9DRRKuozsw5560TiPUsEJQp3fT5aFFpsTITRwz Zg4hGllK6Ut8E4plzo50CZX30PJWVuQpewm08x56emqOVe4kUN8CSWwqCpmtKbji41xa YmVQ== X-Forwarded-Encrypted: i=1; AJvYcCUQPeQAFQqp4fnVMYc3FZcWzPtqLnDY2/hJlKPztVc/yKMYLoJ2oik14epSrKR8x6yWFc4mhfb7b2aELaw5+8nn@vger.kernel.org X-Gm-Message-State: AOJu0YzXeQR38Xg+lfK0sQi6+IoD8akcqIQaHh/ta/QwtUO4HTHHIt+P V27B582ipGRb6+T9g3H4hi4KdCTzUdbvmCmCtqxXUT2aIAWXuaNRl9f2UdPNVZMBxIPxfwJMWpW Vd9YXQg== X-Google-Smtp-Source: AGHT+IHS8CwqpCMF7HFeq4dKWZ9ly2piLbucMCbuAUmYD9n4d1+U+fgWdEeYJVD2NQ881z/O0fjUe65Qoc4e X-Received: from pjl14.prod.google.com ([2002:a17:90b:2f8e:b0:2fa:26f0:c221]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:264d:b0:305:5f55:899 with SMTP id 98e67ed59e1d1-305608774f4mr6510152a91.11.1743531916860; Tue, 01 Apr 2025 11:25:16 -0700 (PDT) Date: Tue, 1 Apr 2025 11:23:18 -0700 In-Reply-To: <20250401182347.3422199-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250401182347.3422199-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250401182347.3422199-21-irogers@google.com> Subject: [PATCH v1 20/48] perf dlfilter: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Yury Norov , Rasmus Villemoes , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/dlfilters/dlfilter-test-api-v0.c | 4 ++-- tools/perf/util/dlfilter.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/perf/dlfilters/dlfilter-test-api-v0.c b/tools/perf/dlfilters/dlfilter-test-api-v0.c index 4ca2d7b2ea6c..bf2a1a7b3c71 100644 --- a/tools/perf/dlfilters/dlfilter-test-api-v0.c +++ b/tools/perf/dlfilters/dlfilter-test-api-v0.c @@ -166,10 +166,10 @@ int start(void **data, void *ctx) CHECK(dlargc == 6); CHECK(!strcmp(dlargv[0], "first")); - verbose = strtol(dlargv[1], NULL, 0); + verbose = (int)strtol(dlargv[1], NULL, 0); d->ip = strtoull(dlargv[2], NULL, 0); d->addr = strtoull(dlargv[3], NULL, 0); - d->do_early = strtol(dlargv[4], NULL, 0); + d->do_early = (int)strtol(dlargv[4], NULL, 0); CHECK(!strcmp(dlargv[5], "last")); pr_debug("%s API\n", __func__); diff --git a/tools/perf/util/dlfilter.c b/tools/perf/util/dlfilter.c index ddacef881af2..0e513ac7feae 100644 --- a/tools/perf/util/dlfilter.c +++ b/tools/perf/util/dlfilter.c @@ -38,7 +38,7 @@ static void al_to_d_al(struct addr_location *al, struct perf_dlfilter_al *d_al) else d_al->dso = dso__name(dso); d_al->is_64_bit = dso__is_64_bit(dso); - d_al->buildid_size = dso__bid(dso)->size; + d_al->buildid_size = (__u32)dso__bid(dso)->size; d_al->buildid = dso__bid(dso)->data; } else { d_al->dso = NULL; @@ -51,9 +51,9 @@ static void al_to_d_al(struct addr_location *al, struct perf_dlfilter_al *d_al) d_al->sym_start = sym->start; d_al->sym_end = sym->end; if (al->addr < sym->end) - d_al->symoff = al->addr - sym->start; + d_al->symoff = (__u32)(al->addr - sym->start); else if (al->map) - d_al->symoff = al->addr - map__start(al->map) - sym->start; + d_al->symoff = (__u32)(al->addr - map__start(al->map) - sym->start); else d_al->symoff = 0; d_al->sym_binding = sym->binding; @@ -290,9 +290,9 @@ static __s32 code_read(__u64 ip, struct map *map, struct machine *machine, void u64 offset = map__map_ip(map, ip); if (ip + len >= map__end(map)) - len = map__end(map) - ip; + len = (__u32)(map__end(map) - ip); - return dso__data_read_offset(map__dso(map), machine, offset, buf, len); + return (__s32)dso__data_read_offset(map__dso(map), machine, offset, buf, len); } static __s32 dlfilter__object_code(void *ctx, __u64 ip, void *buf, __u32 len) -- 2.49.0.504.g3bcea36a83-goog