From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Howard Chu <howardchu95@gmail.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Levi Yun <yeoreum.yun@arm.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Andi Kleen <ak@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Weilin Wang <weilin.wang@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/5] NMI warning and debug improvements
Date: Wed, 2 Apr 2025 09:47:15 -0700 [thread overview]
Message-ID: <20250402164720.3847573-1-irogers@google.com> (raw)
The NMI warning wouldn't fire even if all the events were for one PMU
type. Remove a nearby, and no longer useful, mixed hardware event
group function. Improve the evlist to string function and dump it in
verbose mode after the reordered events warning.
As commonly happens legacy events like instructions will be uniquified
to hybrid events like cpu_core/instructions/, even though the
encodings differ. To make this correct either:
https://lore.kernel.org/lkml/20250312211623.2495798-1-irogers@google.com/
or:
https://lore.kernel.org/linux-perf-users/20250109222109.567031-1-irogers@google.com/
needs merging.
v2: Rename evlist__has_hybrid to evlist__has_hybrid_pmus and add a
max_length parameter to evlist__format_evsels as suggested by Kan
Liang.
Ian Rogers (5):
perf stat: Better hybrid support for the NMI watchdog warning
perf stat: Remove print_mixed_hw_group_error
perf evlist: Refactor evlist__scnprintf_evsels
perf evlist: Add groups to evlist__format_evsels
perf parse-events: Add debug dump of evlist if reordered
tools/perf/builtin-record.c | 9 ++++---
tools/perf/util/evlist.c | 34 ++++++++++++++++-------
tools/perf/util/evlist.h | 3 ++-
tools/perf/util/parse-events.c | 16 ++++++++---
tools/perf/util/stat-display.c | 49 +++++++++++-----------------------
tools/perf/util/stat.h | 1 -
6 files changed, 60 insertions(+), 52 deletions(-)
--
2.49.0.504.g3bcea36a83-goog
next reply other threads:[~2025-04-02 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 16:47 Ian Rogers [this message]
2025-04-02 16:47 ` [PATCH v2 1/5] perf stat: Better hybrid support for the NMI watchdog warning Ian Rogers
2025-04-02 16:47 ` [PATCH v2 2/5] perf stat: Remove print_mixed_hw_group_error Ian Rogers
2025-04-02 16:47 ` [PATCH v2 3/5] perf evlist: Refactor evlist__scnprintf_evsels Ian Rogers
2025-04-02 16:47 ` [PATCH v2 4/5] perf evlist: Add groups to evlist__format_evsels Ian Rogers
2025-04-02 16:47 ` [PATCH v2 5/5] perf parse-events: Add debug dump of evlist if reordered Ian Rogers
2025-04-02 17:52 ` Liang, Kan
2025-04-02 18:15 ` Ian Rogers
2025-04-02 18:28 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402164720.3847573-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=weilin.wang@intel.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox