From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C69AB293B42 for ; Thu, 24 Apr 2025 19:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745524721; cv=none; b=G23WmVyfCc0CP2Ex5p7AVie1WdJd2wmK1i4NgMDTAXj/Xy1cxY2cK/TiDc3Mn9hHAeG9jWNPwMGiRfFXKgOKnnfTTFyZ8BfkJwh5/dG4yDqGs/eTInFRkIX4jd7PZgfkVGUaATX1bTPotnG/KUpGT3QvsGhlmKwE7iyefmhdKgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745524721; c=relaxed/simple; bh=V/+YIeqXyWe+VtI2AkO9avaTu+8PfbklD7Z5gyGY4Uw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=H0ewCyYJK28UkArvcB+WJ8FgPrcDrbvU4pMZs26bHHZyiSY+gfDnvv4g7uV1uLppN5nG+pWum8oZ9K7VRCQQAO6IujXXXvfA21G+haVo2+HfNYUNHhG0noO1xleiiNz3AuGPPMLklFFBzPzPIcbHaS1sfrKjWXnDWKTjjzVfiqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ee5m52VV; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ee5m52VV" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2ff4b130bb2so1490321a91.0 for ; Thu, 24 Apr 2025 12:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745524719; x=1746129519; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=DIKGPOJtNTYeYYPtYxV7HNqMQQDAOFZ9Hntv87mu0iI=; b=Ee5m52VV4vdlbSeryeq2ihHrqGZNj8soB0jRLmUwWjoWdP3hJp1gg5en2nv8nmdNIF Doo7vId/eMBhE2Auvsjtzb4ka9ciPMfECzm3DxcTLEqRC02lcqFRWh8iaadSrI+W9l/K 06z4vnvbi7H2cDQV+20ZVZOnniF96O3mlDEzFaSzQbsPEST53+W42addKjOE/FhbUiAS ysd1n4XhZX2PQ8O+Lkl6ZoDO3H9GDrpQlem7trtzo9AWvjv1GThN9FJizWN8SXEM9DJ5 fPRPfVzR/g7Jg1Ks5mysKCRfnJLtUlmf5zgTRj3bVgvE1iCGp/6x335IYCnoIiN3rfF1 h9kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745524719; x=1746129519; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DIKGPOJtNTYeYYPtYxV7HNqMQQDAOFZ9Hntv87mu0iI=; b=AQBfugsMn6LIP4ZYPa++KZhIeE0pdJ+a1NzSOLN9gy/5xi3CCUkVPU7ryI/EGYB6ln 88Qm5eb657lGyuFi5LBGHxCHn+8a+6WM1tmffxPTqpMX3arslfTz7yLCKz9etdHID725 NIRzj+PKz+V8BQ3pHb2INZG4kG1rqC0VrCPZijxyUTKljBA5xD9H4bN6I0ZhHIyPjhNs X7VZBf8ZkrVOjXTEv8Uzvzthp8WVBWlxor0iAQj0zQ6RJ/tIUh59VHp0VEFYuZpaUxrw O836Pye+0WmTVS0F7x7zf1E9ZxYsubm0aYVDItRJiiWV/C2Wu20GQBruQSMMxiKPTJC4 KW1g== X-Forwarded-Encrypted: i=1; AJvYcCUzSz2DG1CPX/Xj459wAUffUtV5S07tRJ+mcfWWsxmANjji4tS85T5ruITwry/RDTSr4mFZaYi2aN7mjKVvAzIN@vger.kernel.org X-Gm-Message-State: AOJu0YwLQxxBFmMSpXrU/oiMR2r2/rLKSZlVqQ7ShGpvBPcdMxs7yOQf 5GaFsPF2USF3YZG+i04YKQ2T3VZV4pd1C7uFuqntv5MJYN6BFhba9TeIAEnGLhMLJ1xJ0RUZvs9 n/IpjCQ== X-Google-Smtp-Source: AGHT+IHpI6N+hwPdiWTusoFuXWW6V5bErVcbyPVk7quV9c2Ci3OtmV1wT+h5SXqQ734pFr5OlPEeRufAxah9 X-Received: from pjbsf8.prod.google.com ([2002:a17:90b:51c8:b0:2ef:9b30:69d3]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:50cf:b0:2ff:6e72:b8e9 with SMTP id 98e67ed59e1d1-309f56b55cfmr1220579a91.25.1745524719071; Thu, 24 Apr 2025 12:58:39 -0700 (PDT) Date: Thu, 24 Apr 2025 12:58:25 -0700 In-Reply-To: <20250424195831.1767457-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250424195831.1767457-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.850.g28803427d3-goog Message-ID: <20250424195831.1767457-3-irogers@google.com> Subject: [PATCH v2 2/8] perf jitdump: Directly mark the jitdump DSO From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Athira Rajeev , Kajol Jain , Li Huafei , "Steinar H. Gunderson" , James Clark , Stephen Brennan , Andi Kleen , Dmitry Vyukov , Zhongqiu Han , Yicong Yang , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Zixian Cai , Steve Clevenger , Thomas Falcon , Martin Liska , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Song Liu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" The DSO being generated was being accessed through a thread's maps, this is unnecessary as the dso can just be directly found. This avoids problems with passing a NULL evsel which may be inspected to determine properties of a callchain when using the buildid DSO marking code. Signed-off-by: Ian Rogers --- tools/perf/util/jitdump.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/jitdump.c b/tools/perf/util/jitdump.c index 624964f01b5f..b062b1f234b6 100644 --- a/tools/perf/util/jitdump.c +++ b/tools/perf/util/jitdump.c @@ -14,9 +14,9 @@ #include #include -#include "build-id.h" #include "event.h" #include "debug.h" +#include "dso.h" #include "evlist.h" #include "namespaces.h" #include "symbol.h" @@ -531,9 +531,22 @@ static int jit_repipe_code_load(struct jit_buf_desc *jd, union jr_entry *jr) /* * mark dso as use to generate buildid in the header */ - if (!ret) - build_id__mark_dso_hit(tool, event, &sample, NULL, jd->machine); - + if (!ret) { + struct dso_id dso_id = { + { + .maj = event->mmap2.maj, + .min = event->mmap2.min, + .ino = event->mmap2.ino, + .ino_generation = event->mmap2.ino_generation, + }, + .mmap2_valid = true, + .mmap2_ino_generation_valid = true, + }; + struct dso *dso = machine__findnew_dso_id(jd->machine, filename, &dso_id); + + if (dso) + dso__set_hit(dso); + } out: perf_sample__exit(&sample); free(event); -- 2.49.0.850.g28803427d3-goog