From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1404294A11 for ; Thu, 24 Apr 2025 19:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745524725; cv=none; b=QK/owBXlk01+hnHFF34mxithtAs3uaEqHX+Y2y8xdXOrzzbTJJXI/eMANb0k8VQPshKtZsUGQwqZ35ydCBNMNCUXj7BueSnBke8G2NuA5VMb4DOFDqK6oc5JTgkD0veB2eil6I6tk/tPXSE+uDcz9gSM4L/0y0/CN15/XHdmW/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745524725; c=relaxed/simple; bh=Qa7/NWnNAbbvspFXvntiqb8JE6R610NDMEjZ2+RCtsI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=n2mCC0ygJwpz7va3XdQv5YRXx4OSa+8dtYizdgRGCnPoZc0CFNMUdsNbM1uLbBnCAXbYY4qgYR/URWpvxuWdPKUBw7cagenLMsFPcEeRqb3l1DsUBmzWf8MFy31NXwx9AKwosOKjssnKmJdukFa6UUt1zXt3tjG0QEpsIYIfXKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hTttOamX; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hTttOamX" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b0e0c573531so842853a12.3 for ; Thu, 24 Apr 2025 12:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745524723; x=1746129523; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=J+5lHcPlqDn1PtKKI7aRSOFbGSO3/XuDLrZF/cxUnH8=; b=hTttOamXBM7orBVyAfxZi+GeA1GBGY8R0Z1TuJKblUN38HTkGNry9lyBv0JEH3JoPF Z2TAFDRzoyLlc1WpQeRzYYPDLjrBytrYASzJLapznN10I+eoi4RHqyQD1ov5x+4V4Pzi iVEASMoBZk6ar5dxJksJm0SUlaw7lAZM+LbVkAftGhr62xseuZnT/I9k3yIai53jG4oj HLPbUwGiPHvo0qCiRvHc6i1r/QSZ37C/N+cjVN+ZWyG/y8UE6bHoguWp7pBpuG1SLp03 rtofTTZmm1ce0wPI8HdU8NJkG/OrU6GusqYofx53XvQ/mpVxhCQzwZBAb4rgnuE/V2+b w5tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745524723; x=1746129523; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J+5lHcPlqDn1PtKKI7aRSOFbGSO3/XuDLrZF/cxUnH8=; b=e8W+TINbjb6grkYyIrmqgkZUwQDYrujkB9VH9TZFxNM40REgDWqn8mjx4ct/AWQohX l9eGR8uIoviRbYWAqGC3i0w/maPVp4kihsN/yscDOww8z6jp8PWDwJkY6c7qw9KMRSj0 xfGVAfXdNGKsARlsvFUjkbC9MNJsZqkuNWEyv/Oi8NagW+ngxwIO9I1/lHCpEx1yaK0G kYzOy+tbbgd/UG1O56EQnEe1td0Jw6KbMb1S0d6vFTVLOv+pmodO+mH+fawtAtMZBg/q wRoEIJ7c0NdzXo59H/2/u8f6ioiy70Y/DnQ4LRTrzXNR7DRmRXsbu9h6LMhrI8fC5Ano +kiw== X-Forwarded-Encrypted: i=1; AJvYcCXsnzHcJlX/jxc0NzH8YTnfKXns33qlKLPVGbjcokzg9JIk+pTVIrk1ehRF2CVr/C+bxrBQuDgIlvcEuXuZHFlO@vger.kernel.org X-Gm-Message-State: AOJu0Yz+zatn5s3LsX9XrrCZJNxgzvR4saUa67bkBch1ETGk55xUd6KV SguYFJOY3+d0kE+R/F7T6ZHdHFxbM7OLo6t9NzkrpZNbAEKb9S+snIdwgnDj/cGx4Wa6i6oRQpc 881rnUA== X-Google-Smtp-Source: AGHT+IHbY+skXPkqzN4tXonepKOsEquu2RdmRcb5i3vEvMDiDPwT/zO4+SFRTK7fVeGl+4ZG6qcfy5nHPoJ2 X-Received: from pgbee14.prod.google.com ([2002:a05:6a02:458e:b0:af2:681:e27a]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:ce44:b0:1fe:6bbf:af22 with SMTP id adf61e73a8af0-20444e6925dmr5081834637.1.1745524723187; Thu, 24 Apr 2025 12:58:43 -0700 (PDT) Date: Thu, 24 Apr 2025 12:58:27 -0700 In-Reply-To: <20250424195831.1767457-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250424195831.1767457-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.850.g28803427d3-goog Message-ID: <20250424195831.1767457-5-irogers@google.com> Subject: [PATCH v2 4/8] perf build-id: Truncate to avoid overflowing the build_id data From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Athira Rajeev , Kajol Jain , Li Huafei , "Steinar H. Gunderson" , James Clark , Stephen Brennan , Andi Kleen , Dmitry Vyukov , Zhongqiu Han , Yicong Yang , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Zixian Cai , Steve Clevenger , Thomas Falcon , Martin Liska , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Song Liu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Warning when the build_id data would be overflowed would lead to memory corruption, switch to truncation. Signed-off-by: Ian Rogers --- tools/perf/util/build-id.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index e763e8d99a43..5bc2040bdd0d 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -951,7 +951,10 @@ bool perf_session__read_build_ids(struct perf_session *session, bool with_hits) void build_id__init(struct build_id *bid, const u8 *data, size_t size) { - WARN_ON(size > BUILD_ID_SIZE); + if (size > BUILD_ID_SIZE) { + pr_debug("Truncating build_id size from %zd\n", size); + size = BUILD_ID_SIZE; + } memcpy(bid->data, data, size); bid->size = size; } -- 2.49.0.850.g28803427d3-goog