From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20202951C9 for ; Thu, 24 Apr 2025 19:58:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745524729; cv=none; b=DtNOMiSffe2v0DAZAY2yMLMCUxTmJlWTyVNvZ+NSXSObSHPy7QY+T1GPyRG5THLTp5VfAjiPOMFf9rIPjdBmDwqcyQBvapkrqiFulvcJ4t1UWSL3P3+e4SRByt7rpcZgqTo7uqstewHmlZXlEDfbhQSPE2LbqcwcOU/3ifXLqwQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745524729; c=relaxed/simple; bh=OaLxK4NLbXyEfAebTw11HHE5mdZMWIyyvPjgkEfRWm8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=vFCrdbPcf6TPUtbXC9Wkv4COupFzck4YiKo42BQ/rOaqrtNMAfeuHuEHbiIcRqds54CpGqAHq8lkWiNd0abUj+KGEq5XkQDMivWuKjpI++FZtAtRM3EWvwati+Uq3G7KxHVxQLfjgddjv2G9wzn1IHdHxphlMu3YxVoPdMYJsgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uCVx8LHu; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uCVx8LHu" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2ff52e1c56fso1999896a91.2 for ; Thu, 24 Apr 2025 12:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745524727; x=1746129527; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=f6EGtFLa98WxK5zCboj+6ZTniMk5Dl/euWdE2ssUAQs=; b=uCVx8LHuOC3ACf9c8vDjdsQUONB/SMsQEc7WZRlvOI5r5Kvd/UrKuG1gbolFkl9uMa C7EPNTCKoTLSb3nj4T49qdNKxvoR6bQ/7m+VGfvWLgxDWnxj1s/HqNqWO0o4fuhlsO5+ DDgwEak7WALozpJNz9m/s2UrST8yfg+ZrUHHQoVCVNldECYmtT4Avs4Pf7q218+2KM3d 5Kfq56nKfRDiiYo2kGi9o4jZk1kfzVbiUdEhBKmYKG4mkPvTPV7LTDd7B92j6BkhjmnH fEztFw6679UOuXpKXq5M7i3Tm8UhsIJYzkbX6mTUPHxaSu51phNN6vv5U2J3GnWJB3rX jwnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745524727; x=1746129527; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f6EGtFLa98WxK5zCboj+6ZTniMk5Dl/euWdE2ssUAQs=; b=CZaY5vaPZwOVbAGsgHFnE/4wBPHb41rmvBUAnFAnao3Uj9ymhUqXQCBokANwHIoyfo dMbTa2uR/9bKL2YG2Hr4jLLyfh1/rk+9TS6iQGKN5tL3fQxsblZeWIOFadX1iwBAz6hJ YhQ8NpsHsv4BqbWhGTMXwbwz5nY7ZHXBzAOUm4i7K6+elx0sPeJKY2xBxwFsRRyKtm// 4wYjQ0yfc1+bOu5tAG3ZYFVuQ+fAPTeKr/GzYTVIi7kJAYVBCv+GV9M3455MAchbcLhJ nxJgyySjy+c19ixkenma6PupFwKj2JvmZQvC680N5gKKbatfljmBWkY2EjIFIr7jUAhA EFvQ== X-Forwarded-Encrypted: i=1; AJvYcCX2Bn1fpilrSZtDAApLD/0sPjAvuXGiJeEBoyz4BO8X8LXISBXlhFJgMbWy4B+eLohYNz7rzzoNkfyCd62cvo7k@vger.kernel.org X-Gm-Message-State: AOJu0YxJziyWX0dMqiYdBxK1yYixmy3tfSUS/Xo7zEQgzU2NZ65FYyTQ 7GedjPlD1Q+h0G0LF04qpmFfzyv028jSyI6v6j9gCitWfPyQodIo4vxOeWlHLDMM1M8MVFzBTMQ yCcBQ7g== X-Google-Smtp-Source: AGHT+IErnjW8J+G6I95oLXzVEkKCdON5M0MwKECmLZsiPhxu3n6KAp9BtXdppA02RaXscM/Sq/sPrm4dIg3F X-Received: from pjbqn3.prod.google.com ([2002:a17:90b:3d43:b0:308:64af:7bb9]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2c8e:b0:306:b65e:13a8 with SMTP id 98e67ed59e1d1-309ed26dbaemr5523150a91.8.1745524727133; Thu, 24 Apr 2025 12:58:47 -0700 (PDT) Date: Thu, 24 Apr 2025 12:58:29 -0700 In-Reply-To: <20250424195831.1767457-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250424195831.1767457-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.850.g28803427d3-goog Message-ID: <20250424195831.1767457-7-irogers@google.com> Subject: [PATCH v2 6/8] perf build-id: Mark DSO in sample callchains From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Athira Rajeev , Kajol Jain , Li Huafei , "Steinar H. Gunderson" , James Clark , Stephen Brennan , Andi Kleen , Dmitry Vyukov , Zhongqiu Han , Yicong Yang , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Zixian Cai , Steve Clevenger , Thomas Falcon , Martin Liska , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Song Liu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Previously only the sample IP's map DSO would be marked hit for the purposes of populating the build ID cache. Walk the call chain to mark all IPs and DSOs. Signed-off-by: Ian Rogers --- tools/perf/util/build-id.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index aa35dceace90..3386fa8e1e7e 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -42,10 +42,20 @@ static bool no_buildid_cache; +static int mark_dso_hit_callback(struct callchain_cursor_node *node, void *data __maybe_unused) +{ + struct map *map = node->ms.map; + + if (map) + dso__set_hit(map__dso(map)); + + return 0; +} + int build_id__mark_dso_hit(const struct perf_tool *tool __maybe_unused, union perf_event *event, struct perf_sample *sample, - struct evsel *evsel __maybe_unused, + struct evsel *evsel, struct machine *machine) { struct addr_location al; @@ -63,6 +73,11 @@ int build_id__mark_dso_hit(const struct perf_tool *tool __maybe_unused, dso__set_hit(map__dso(al.map)); addr_location__exit(&al); + + sample__for_each_callchain_node(thread, evsel, sample, PERF_MAX_STACK_DEPTH, + /*symbols=*/false, mark_dso_hit_callback, /*data=*/NULL); + + thread__put(thread); return 0; } -- 2.49.0.850.g28803427d3-goog