From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Indu Bhagat <indu.bhagat@oracle.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-toolchains@vger.kernel.org, Jordan Rome <jordalgo@meta.com>,
Sam James <sam@gentoo.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jens Remus <jremus@linux.ibm.com>,
Florian Weimer <fweimer@redhat.com>,
Andy Lutomirski <luto@kernel.org>, Weinan Liu <wnliu@google.com>,
Blake Jones <blakejones@google.com>,
Beau Belgrave <beaub@linux.microsoft.com>,
"Jose E. Marchesi" <jemarch@gnu.org>,
Alexander Aring <aahringo@redhat.com>
Subject: [PATCH v5 09/12] unwind_user/sframe: Remove .sframe section on detected corruption
Date: Thu, 24 Apr 2025 16:15:20 -0400 [thread overview]
Message-ID: <20250424201824.978358670@goodmis.org> (raw)
In-Reply-To: 20250424201511.921245242@goodmis.org
From: Josh Poimboeuf <jpoimboe@kernel.org>
To avoid continued attempted use of a bad .sframe section, remove it
on demand when the first sign of corruption is detected.
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/unwind/sframe.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/unwind/sframe.c b/kernel/unwind/sframe.c
index 1a35615a361e..66b920441692 100644
--- a/kernel/unwind/sframe.c
+++ b/kernel/unwind/sframe.c
@@ -294,6 +294,10 @@ int sframe_find(unsigned long ip, struct unwind_user_frame *frame)
ret = __find_fre(sec, &fde, ip, frame);
end:
user_read_access_end();
+
+ if (ret == -EFAULT)
+ WARN_ON_ONCE(sframe_remove_section(sec->sframe_start));
+
return ret;
}
--
2.47.2
next prev parent reply other threads:[~2025-04-24 20:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 20:15 [PATCH v5 00/12] unwind_deferred: Implement sframe handling Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 01/12] unwind_user/sframe: Add support for reading .sframe headers Steven Rostedt
2025-05-28 10:26 ` [PATCH] fixup! unwind_user/sframe: Add support for reading .sframe contents Jens Remus
2025-04-24 20:15 ` [PATCH v5 02/12] unwind_user/sframe: Store sframe section data in per-mm maple tree Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 03/12] x86/uaccess: Add unsafe_copy_from_user() implementation Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 04/12] unwind_user/sframe: Add support for reading .sframe contents Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 05/12] unwind_user/sframe: Detect .sframe sections in executables Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 06/12] unwind_user/sframe: Add prctl() interface for registering .sframe sections Steven Rostedt
2025-04-28 9:00 ` Jens Remus
2025-04-24 20:15 ` [PATCH v5 07/12] unwind_user/sframe: Wire up unwind_user to sframe Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 08/12] unwind_user/sframe/x86: Enable sframe unwinding on x86 Steven Rostedt
2025-04-24 20:15 ` Steven Rostedt [this message]
2025-04-24 20:15 ` [PATCH v5 10/12] unwind_user/sframe: Show file name in debug output Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 11/12] unwind_user/sframe: Enable debugging in uaccess regions Steven Rostedt
2025-04-24 20:15 ` [PATCH v5 12/12] unwind_user/sframe: Add .sframe validation option Steven Rostedt
2025-04-24 20:28 ` [PATCH v5 00/12] unwind_deferred: Implement sframe handling Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424201824.978358670@goodmis.org \
--to=rostedt@goodmis.org \
--cc=aahringo@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=beaub@linux.microsoft.com \
--cc=blakejones@google.com \
--cc=broonie@kernel.org \
--cc=fweimer@redhat.com \
--cc=indu.bhagat@oracle.com \
--cc=irogers@google.com \
--cc=jemarch@gnu.org \
--cc=jolsa@kernel.org \
--cc=jordalgo@meta.com \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sam@gentoo.org \
--cc=wnliu@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).