From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B84A23CEE5 for ; Tue, 29 Apr 2025 06:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745909524; cv=none; b=kITqmMW+7agbD2OVNQ7Z1p2pbkSsqCXTYezXxZW9g13LJIR6bDYOuTyb0Mw/VLtDPX7b6HRReDGwE4gGvqr8K1opwFiFRFGHhdj3TFeBUdWA+BXuFpI8QBV3asyIQl3Gvwi6DzXQFol3U175F61N1harILpWgg2aU407aT1S7K8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745909524; c=relaxed/simple; bh=OsbRCUKtS1g6kdeWUlqCgkrSl6P+6YFFCidGZt74u/I=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=XWytje3VEZDuE+NZgTSYJ8TomuyZKxajLll24S3djGgcQscdsT6L2BFF50varNIP73E3xddgpWP0XitlKV+w8P3ico8JldHmjijTp/v4M+hpMh1FrjwctRkLjpouM3aEf35zRamXyLXoWp2IoAnxpbZEZsgh2Q+pdhyeJjXqGfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=sKCjb2sL; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="sKCjb2sL" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53T4EYD1026454; Tue, 29 Apr 2025 06:52:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=BYTDnf2YueOeH3kEBJ4kRqkQ7iJYqEC8S1noYwpjg n0=; b=sKCjb2sLtGK15xH9tFYfVuzx+rx/l8VS1TYcH6d6qw0Y3QldISq5W5O+x drEwv5EBC8IDtQwshX5GT+vHbt9A5aOzVzKteTX4+Tg2jxhnplEd0FGY5xOFBvUc NKRHUzURCZ4/dZujff2Wq9SrA+tB3VZrTxjv14oYsOvtnhG4IVSoaHlrce/0rMC2 tr8iR//2taOhyB+2YNzwUcIIszpvzqG/v5SIG5Qy2x6RLFbZDqtxPt52AQnL4tfX hQE8rgqS1Inw7Q1NU1z2HfRYtnhWCZHTTEf+0HauUd3EEhfRJYIaiZURId2aGg5g O4Dwv3qHFIAhmttnk2LFqFKsABjXw== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46ahtwhjfm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 06:51:59 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53T6Q5hD008490; Tue, 29 Apr 2025 06:51:58 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 469ch31qhx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 06:51:58 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53T6prPR29884758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Apr 2025 06:51:53 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E62B02004E; Tue, 29 Apr 2025 06:51:52 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0E5720040; Tue, 29 Apr 2025 06:51:51 +0000 (GMT) Received: from localhost.localdomain (unknown [9.109.199.221]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 29 Apr 2025 06:51:51 +0000 (GMT) From: Aditya Bodkhe To: linux-perf-users@vger.kernel.org Cc: Aditya Bodkhe , Disha Goel , Adrian Hunter Subject: [PATCH v3] perf script: perf script tests fails with segfault Date: Tue, 29 Apr 2025 12:21:32 +0530 Message-Id: <20250429065132.36839-1-adityab1@linux.ibm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI5MDA0OSBTYWx0ZWRfX0D/kShOsjzA8 vd8Vbx0Ms38Lq/uuQTc3Gd21nFwPBwHmJbrqXXGMv9EJYuf+YTYdNEM4fvt0wWUMI76NrEcyBXu BtR1wmuZoUvqat0q/L/S/LYuV0sv3FTnAHTNtmB7WhEgwf6s7EZwTso6IAHjw2DjG4UQuhLPrKW IfuOc3l+bgI9JnWWFI82vAzd8TBK17FgNEpCxFglm7g1kenmJLnawTQwsBvQD9+bKYLuK9OjrB8 r4BZkV9iytQIgQ/JnHXyG1TsDGmb+WD+Y598kQ7k2srAUygAS+1zwb20YOaGw5DrfRuGsI5yn4o wDrOhIrwdXUZyw2I8DE25PImClVWsi+glFylou1i/FUmkrFgHvpz/4M3eS8EhBE1xy/EMgJekgB 8U4+1VzWVxyXuvrPWUj5qd8UhjukBakD0qxkJGtF4HpYDw+1tZWuwayY2W+lFdUrZ4mEoXma X-Proofpoint-GUID: Qps3RGWya02JCDIqc0ejB_Dlah3_GcpJ X-Authority-Analysis: v=2.4 cv=KtxN2XWN c=1 sm=1 tr=0 ts=6810770f cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=QyXUC8HyAAAA:8 a=bfOIhj56j9TKDZiLBowA:9 X-Proofpoint-ORIG-GUID: Qps3RGWya02JCDIqc0ejB_Dlah3_GcpJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-29_02,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504290049 From: Aditya Bodkhe perf script: pert script tests fails with segmentation fault as below: 92: perf script tests: --- start --- test child forked, pid 103769 DB test [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.012 MB /tmp/perf-test-script.7rbftEpOzX/perf.data (9 samples) ] /usr/libexec/perf-core/tests/shell/script.sh: line 35: 103780 Segmentation fault (core dumped) perf script -i "${perfdatafile}" -s "${db_test}" --- Cleaning up --- ---- end(-1) ---- 92: perf script tests : FAILED! Backtrace pointed to : #0 0x0000000010247dd0 in maps.machine () #1 0x00000000101d178c in db_export.sample () #2 0x00000000103412c8 in python_process_event () #3 0x000000001004eb28 in process_sample_event () #4 0x000000001024fcd0 in machines.deliver_event () #5 0x000000001025005c in perf_session.deliver_event () #6 0x00000000102568b0 in __ordered_events__flush.part.0 () #7 0x0000000010251618 in perf_session.process_events () #8 0x0000000010053620 in cmd_script () #9 0x00000000100b5a28 in run_builtin () #10 0x00000000100b5f94 in handle_internal_command () #11 0x0000000010011114 in main () Further investigation reveals that this occurs in the `perf script tests`, because it uses `db_test.py` script. This script sets `perf_db_export_mode = True`. With `perf_db_export_mode` enabled, if a sample originates from a hypervisor, perf doesn't set maps for "[H]" sample in the code. Consequently, `al->maps` remains NULL when `maps__machine(al->maps)` is called from `db_export__sample`. As al->maps can be NULL in case of Hypervisor samples , use thread->maps because even for Hypervisor sample, machine should exist. If we don't have machine for some reason, return -1 to avoid segmentation fault. Reported-by: Disha Goel Signed-off-by: Aditya Bodkhe Suggested-by: Adrian Hunter --- Changelog: v2 -> v3: This patch contains changes suggested by Adrian Hunter to add extra spaces before ---start--- and ---end--- to be able to apply patch without any issues v1 -> v2: The below patch contains changes suggested by Adrian Hunter to handle the segmentation fault , as well as initialisation of al.thread tools/perf/util/db-export.c | 11 ++++++++--- .../perf/util/scripting-engines/trace-event-python.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c index 50f916374d87..8f52e8cefcf3 100644 --- a/tools/perf/util/db-export.c +++ b/tools/perf/util/db-export.c @@ -181,7 +181,7 @@ static int db_ids_from_al(struct db_export *dbe, struct addr_location *al, if (al->map) { struct dso *dso = map__dso(al->map); - err = db_export__dso(dbe, dso, maps__machine(al->maps)); + err = db_export__dso(dbe, dso, maps__machine(thread__maps(al->thread))); if (err) return err; *dso_db_id = dso__db_id(dso); @@ -256,6 +256,7 @@ static struct call_path *call_path_from_sample(struct db_export *dbe, al.map = map__get(node->ms.map); al.maps = maps__get(thread__maps(thread)); al.addr = node->ip; + al.thread = thread__get(thread); if (al.map && !al.sym) al.sym = dso__find_symbol(map__dso(al.map), al.addr); @@ -358,14 +359,18 @@ int db_export__sample(struct db_export *dbe, union perf_event *event, }; struct thread *main_thread; struct comm *comm = NULL; - struct machine *machine; + struct machine *machine = NULL; int err; + if (thread__maps(thread)) + machine = maps__machine(thread__maps(thread)); + if (!machine) + return -1; + err = db_export__evsel(dbe, evsel); if (err) return err; - machine = maps__machine(al->maps); err = db_export__machine(dbe, machine); if (err) return err; diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c index 520729e78965..00f2c6c5114d 100644 --- a/tools/perf/util/scripting-engines/trace-event-python.c +++ b/tools/perf/util/scripting-engines/trace-event-python.c @@ -1306,7 +1306,7 @@ static void python_export_sample_table(struct db_export *dbe, tuple_set_d64(t, 0, es->db_id); tuple_set_d64(t, 1, es->evsel->db_id); - tuple_set_d64(t, 2, maps__machine(es->al->maps)->db_id); + tuple_set_d64(t, 2, maps__machine(thread__maps(es->al->thread))->db_id); tuple_set_d64(t, 3, thread__db_id(es->al->thread)); tuple_set_d64(t, 4, es->comm_db_id); tuple_set_d64(t, 5, es->dso_db_id); -- 2.43.0