From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9EF2882D5 for ; Wed, 30 Apr 2025 17:51:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035501; cv=none; b=g1vuxF079LgY17VvMVrdH9IhGLUU3h7vyb70/KFrahYh7dVR9O1WQkZzwqvjaY+2+7Tp+FFGDcTojieiYk/wH8Ez3xhjxHYm+wyw9HjGmXLHJiw8mqVDuh8NCHaIsetIbdja7mErhV3uYDqyuWCzIlENKo2iG3b8+vssbADPGGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035501; c=relaxed/simple; bh=71Fh1qtXfJOLrXvEBj1LTswa/5CQQRqQLFx8XbFD85k=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=H5Lc29z+wQh9L5G9dXA10Oz4/DxaxeM4EZ0Ta9hgWCj3UJv1v8OqF5G1y7FBPU1zmHu/9/AWojcZFva8cphY5+iJ1vFJvU8JaJ9P0UL+tLksNH8n7VsxgH0LOWiNutCcVJzE9WxFT4WfGCVf/sJ+L4nkbeoMqHIjxPOOHzgbUSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FFTsgMcC; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FFTsgMcC" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-b1b2fa98c39so92179a12.2 for ; Wed, 30 Apr 2025 10:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746035499; x=1746640299; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vzdcyVDs5KmZFcO+KePSm4+Ud/p9n76j0KYupv7ixbU=; b=FFTsgMcCBMz2M9DBe9g1jYrFNIaLrvOLAYWhBxBr5HBWg3YmC/8i5CeURSjPGnMCfL j9neb7wWVhxMcbHnsAuGChfkHu3p6eWN6jIlJcmaSqUFyDoc/W4t1OVq7zXQS4/KpLrz Ixw2FNLTcK//ZiDOKB4zwKLVjTGQwT4UQcfuwbj2yugGjzjnBqEY18zWrbep5IjUDSem sGWf+AFlgrSxEKTplqfWVeXZntXYcbCj9TcX4JHFsJ8+gJgv/xIx/0joLhfQxC43mcfj WV1W5yKL3jUl7DQT+Y1p1bCTG6hdzrYkaJ7iUVyMu11bgKW6G+Rt2tMaz84fvjvZxkbi ZxJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746035499; x=1746640299; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vzdcyVDs5KmZFcO+KePSm4+Ud/p9n76j0KYupv7ixbU=; b=jGPaqn23P7JlVJL1ymTArwRKG5t2Nsro7lGw+xpWNvuVY5SdHvRbdv/tESREqF6H1L KWDWZeZePUXUXPNIxIc+ObmTR27HVNn7xsnEdMH783cW4AFDBT1Ygb3uss3hOkt6rPK3 lcfq2uiBRvo2P7G0h/M+3xtE1oQMio01ZUhLEZF6PlQtSDaKUlQK2wx4oFM2O8Dpv3Ud TTW5G9F/DNJWfjgo3CD0LR42G42R2UcYELQ7I/VTTqu6Gv6wUbYuf96P++G4LcCBxRdP Zli/iC5Iz00vhRQHUMEjolDLM22pq5DkjZ37o25KY3G4nHwzjP4Y14zlEeGYdbaBHJOw 8Fww== X-Forwarded-Encrypted: i=1; AJvYcCVZa7GLW1iFPvOUG1WMAGS4Ele+Td7/GgsQlry9LKBKJT1WaOHTTw+mz4LYSztB1VVW4H1awxJkkjbk3UWHNZEM@vger.kernel.org X-Gm-Message-State: AOJu0YxGACt9vEsW4yRGV3NeFR/GvmJ/VeXOnTE/lmREuvLqgyAfctmE mYpEXvPnKLDroWVBrjYJgo88kim03nY++MysuGU4m9kiVFkmq0jE+iwcyslM7ih5D2zY2KFdhRz GgWNfBQ== X-Google-Smtp-Source: AGHT+IFOPGbRFAxJkE+dEQP10DpVFZBKzSu9vIFxGxZ8r+laJ8avCeQVWaEft4PQXwRDgfVw41yAmv4ZGYUC X-Received: from pgbdp2.prod.google.com ([2002:a05:6a02:f02:b0:b14:9a53:2226]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:394f:b0:1f5:8622:5ed5 with SMTP id adf61e73a8af0-20ba6a18194mr167216637.3.1746035499179; Wed, 30 Apr 2025 10:51:39 -0700 (PDT) Date: Wed, 30 Apr 2025 10:50:09 -0700 In-Reply-To: <20250430175036.184610-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250430175036.184610-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.906.g1f30a19c02-goog Message-ID: <20250430175036.184610-22-irogers@google.com> Subject: [PATCH v2 21/47] perf demangle: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Yury Norov , Rasmus Villemoes , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/util/demangle-java.c | 4 ++-- tools/perf/util/demangle-ocaml.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/demangle-java.c b/tools/perf/util/demangle-java.c index ddf33d58bcd3..ee20f4d08765 100644 --- a/tools/perf/util/demangle-java.c +++ b/tools/perf/util/demangle-java.c @@ -42,9 +42,9 @@ static const char *base_types['Z' - 'A' + 1] = { * error : NULL */ static char * -__demangle_java_sym(const char *str, const char *end, char *buf, int maxlen, int mode) +__demangle_java_sym(const char *str, const char *end, char *buf, size_t maxlen, int mode) { - int rlen = 0; + size_t rlen = 0; int array = 0; int narg = 0; const char *q; diff --git a/tools/perf/util/demangle-ocaml.c b/tools/perf/util/demangle-ocaml.c index 9d707bb60b4b..25fe755df5ab 100644 --- a/tools/perf/util/demangle-ocaml.c +++ b/tools/perf/util/demangle-ocaml.c @@ -30,8 +30,7 @@ ocaml_demangle_sym(const char *sym) { char *result; int j = 0; - int i; - int len; + size_t i, len; if (!ocaml_is_mangled(sym)) { return NULL; -- 2.49.0.906.g1f30a19c02-goog