From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F4D2957D0 for ; Wed, 30 Apr 2025 17:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035526; cv=none; b=iRwPIULpjn4xCAa7tFVOo+LjMMLM3MDJGL4lBWWPQZ1CbYyNQC6ti/Z4tJI5kDdVwy0g2bAL3y/i1JThnGgdI7zfiSoyFclyI03XTf1bRpyZAatt89099Cyf8qw0nfkREyMAW2gE5Y8KbpLAR8jHxUaP83hTfVRHjo/18v6KYWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746035526; c=relaxed/simple; bh=NA6JF+5T8PMFE786WZ9is+NQYJJhQbzJSB67SJH2UIM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=thcNSuEeub61GfB2LPJ4V+wFkio2t/I6aR7Iu9DzgXCPQaxh4NDTIFVighIfSowXcWgC8Er2TnRm0ZPpcpBh+RWKQvMUVuZ322UpeLsJDA29lJDCsb4ElTcuQ5C6wKTvD3P6DR1tEzbM1sJqXw9r1juFcIS0MGr4rTC+TYXaTM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WF9u59W1; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WF9u59W1" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2ff798e8c3bso157025a91.2 for ; Wed, 30 Apr 2025 10:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746035524; x=1746640324; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5qLcbceIaYVHwJQzlzAjBxnjnjaX/IxjWID9LpXlzn8=; b=WF9u59W1PArtgpXGJxPItDfUa6YhPkylR+BAc0aRljH5l4OFZC6aQFRDXLn6Gf9IWD II6e+qt4jvfQO0BZIszRUN6sB3rU13yVi3iMULgRlglyQ/VJwTsv+aBo8dUaiBsALi81 Tsx5CWybUIXsxYtjsJWr8LoKhIKq6J3NunCbzG1PtF5gK2FrnGNE2pbder6nUGXB+e+4 VV225ZmuVKGIKn/O8u8RcEmwOwm8OKZh8lOnykWY5ziBm+LjtkGYzElKDIHP3XH0Y7Z4 TCVTxLri/RUleMPLfnMRtEcQUHOCms1x9tI540I2V20QiVocr0s/XZ0cHb3eYSWK3n9B UJMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746035524; x=1746640324; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5qLcbceIaYVHwJQzlzAjBxnjnjaX/IxjWID9LpXlzn8=; b=n/3o65g7tMIQ5KG07I5BbQgHNxa+Pjv9+uPBdTdHnrdEs5+/EwpnM1ttCtQHYDvJdZ +O64WkngpS2Zv1W6y+hoo4qhP3GDfs8OpR8KJiQV3JWQ05swQf3S2+OYbANU8knrF3dv 2D91C2U1nZg3WNzqJiYROTlUlNVQ083qQnFAT5wwIO4pNJIYoKHwep11pRoaeaRe6p3l vAf4l4MPvwbL7F5M9gtRVLDcm5pIZnypMXgPzwRwIxC30HJjMuImI2Z3kXNUR5dj9UO1 FQkpT9kUtyUFmDmRQ3oM2/re2pzzngNTaHTR5BC2vb28iuov1JFGXr7OnTpRxiB9Bwi7 FGVw== X-Forwarded-Encrypted: i=1; AJvYcCVeDnpGp2NZcD0TzwiLCdzZFbuXvT2yntfthxTo5dd0Fjqh9DUXRt6IUErmrlY9GznNPqcJCFduwZkNb19QQLgq@vger.kernel.org X-Gm-Message-State: AOJu0YzC6Rpr0TX2t/hRVMgIB2o10AJZD5eyoXRrIDhCJDJBZOF+w5kf nfigQOybMeVFe2V8CNQWcGjOM6nU+5liCn64JidNYQgCFTGwnBfcqMYCYknxs8wJOsRLqZvxxB/ aOrw7fA== X-Google-Smtp-Source: AGHT+IG0fzje+t2hW+hPy3K7I9jJjIAnkr6OhXzLc0jx8cpHraftxXNs9MU4ybMwEqBJuYkZAVaH6/yEYMns X-Received: from pjbst3.prod.google.com ([2002:a17:90b:1fc3:b0:301:4260:4d23]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2e4d:b0:2ee:b875:6d30 with SMTP id 98e67ed59e1d1-30a332e9067mr6048776a91.9.1746035524221; Wed, 30 Apr 2025 10:52:04 -0700 (PDT) Date: Wed, 30 Apr 2025 10:50:21 -0700 In-Reply-To: <20250430175036.184610-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250430175036.184610-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.906.g1f30a19c02-goog Message-ID: <20250430175036.184610-34-irogers@google.com> Subject: [PATCH v2 33/47] perf bpf_counter: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Yury Norov , Rasmus Villemoes , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/util/bpf_counter.c | 6 +++--- tools/perf/util/bpf_counter_cgroup.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_counter.c index 73fcafbffc6a..3b1dbf1f5f66 100644 --- a/tools/perf/util/bpf_counter.c +++ b/tools/perf/util/bpf_counter.c @@ -177,7 +177,7 @@ static int bpf_program_profiler__load(struct evsel *evsel, struct target *target return -1; while ((tok = strtok_r(bpf_str, ",", &saveptr)) != NULL) { - prog_id = strtoul(tok, &p, 10); + prog_id = (unsigned int)strtoul(tok, &p, 10); if (prog_id == 0 || prog_id == UINT_MAX || (*p != '\0' && *p != ',')) { pr_err("Failed to parse bpf prog ids %s\n", @@ -418,7 +418,7 @@ static int bperf_reload_leader_program(struct evsel *evsel, int attr_map_fd, link = bpf_program__attach(skel->progs.on_switch); if (IS_ERR(link)) { pr_err("Failed to attach leader program\n"); - err = PTR_ERR(link); + err = (int)PTR_ERR(link); goto out; } @@ -459,7 +459,7 @@ static int bperf_attach_follower_program(struct bperf_follower_bpf *skel, else { link = bpf_program__attach(skel->progs.fexit_XXX); if (IS_ERR(link)) - err = PTR_ERR(link); + err = (int)PTR_ERR(link); } return err; diff --git a/tools/perf/util/bpf_counter_cgroup.c b/tools/perf/util/bpf_counter_cgroup.c index 6ff42619de12..35d1b950e803 100644 --- a/tools/perf/util/bpf_counter_cgroup.c +++ b/tools/perf/util/bpf_counter_cgroup.c @@ -98,7 +98,7 @@ static int bperf_load_program(struct evlist *evlist) FD(cgrp_switch, i)); if (IS_ERR(link)) { pr_err("Failed to attach cgroup program\n"); - err = PTR_ERR(link); + err = (int)PTR_ERR(link); goto out; } } -- 2.49.0.906.g1f30a19c02-goog