From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 14E5414A639; Fri, 16 May 2025 15:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747409526; cv=none; b=PkQSFqrIbWsGjyJ13Hq41mCp0nM1Ij8fiE9wwYXPd92aDhu0hBpmRZnsyJ/e19TlPjvXDCROMaa7V2upavVJBq18W10m5d5t+qRbix+M50RXyXz/Ygh2QIgYH1wE1Q07jyG2Bu9EURDR8eknGdMucRZNvTtRqjEIclw1DDXYI34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747409526; c=relaxed/simple; bh=UGQd2vpEGtZoNWxqSs0iTpV6XWH9Pxv+t8tsGF8k1Ug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p2gvZgtte6QaSrnJ4zHVZCfhIOYTUGYjJxYYZz36telj7MPIrhXcOiGhkpdEkTdCHNZfNo4yWeyKxVqKigrZ+DG7My6OzsZ7J3muh/L70Bz5g7NBOAB9wJHtvUU0AAWKi3CDnmqVCvpUYs9/ECoSbPFRhF2L1SXB9VlqqY859uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 338B6169C; Fri, 16 May 2025 08:31:51 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C36823F673; Fri, 16 May 2025 08:32:02 -0700 (PDT) Date: Fri, 16 May 2025 16:31:58 +0100 From: Leo Yan To: Ian Rogers , Namhyung Kim Cc: Arnaldo Carvalho de Melo , Namhyung Kim , Adrian Hunter , "Liang, Kan" , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tests switch-tracking: Fix timestamp comparison Message-ID: <20250516153158.GH412060@e132581.arm.com> References: <20250331172759.115604-1-leo.yan@arm.com> <20250401091422.GA115840@e132581.arm.com> <20250402090516.GG115840@e132581.arm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250402090516.GG115840@e132581.arm.com> Hi Ian, Namhyung, [ - Mailing list ] On Wed, Apr 02, 2025 at 10:05:16AM +0100, Leo Yan wrote: > On Tue, Apr 01, 2025 at 12:54:12PM -0700, Ian Rogers wrote: > > On Tue, Apr 1, 2025 at 2:14 AM Leo Yan wrote: > > > > > > On Mon, Mar 31, 2025 at 01:18:31PM -0700, Ian Rogers wrote: > > > > > > [...] > > > > > > > I'm reminded of a Java check I wrote for this: > > > > > > Nice short article. > > > > > > > In clang -Wshorten-64-to-32 looks to cover this. I'll see if we can > > > > clean those warnings up a bit. > > > > > > I checked a bit and seems GCC has no this flag, but it makes sense for > > > me to enable the flag for Clang. > > > > > > > Reviewed-by: Ian Rogers > > > > > > Thanks a lot, Ian. > > > > I made a small variation to the change in: > > https://lore.kernel.org/lkml/20250401182347.3422199-10-irogers@google.com/ > > to avoid a subtract and just directly compare the values. Do you mind to pick up my this patch? :) Our internal CI reports the test case 109_Track_with_sched_switch failure daily, I am just wandering if we could apply the fix quickly. Ian is working on a patch series for resolving the Clang warning which also includes a fix [1], if Ian could extract the fix for the compar() function in switch-tracking.c, this either would be fine for me. Thanks a lot for your helping! Leo [1] https://lore.kernel.org/linux-perf-users/20250401182347.3422199-10-irogers@google.com/