From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Ravi Bangoria <ravi.bangoria@amd.com>, Leo Yan <leo.yan@arm.com>,
Yujie Liu <yujie.liu@intel.com>,
Graham Woodward <graham.woodward@arm.com>,
Howard Chu <howardchu95@gmail.com>,
Weilin Wang <weilin.wang@intel.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andi Kleen <ak@linux.intel.com>,
Thomas Falcon <thomas.falcon@intel.com>,
Matt Fleming <matt@readmodwrite.com>,
Chun-Tse Shao <ctshao@google.com>,
Ben Gainey <ben.gainey@arm.com>, Song Liu <song@kernel.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v2 0/3] Generic weight struct, use env for sort key and header
Date: Wed, 21 May 2025 06:54:56 -0700 [thread overview]
Message-ID: <20250521135500.677508-1-irogers@google.com> (raw)
The arch directory is a barrier to cross-platform development as files
and behaviors within it are inherently platform specific. Sample
parsing should be generic but the PERF_SAMPLE_WEIGHT_STRUCT handling
was only present if building for x86 or powerpc. The sort key and
headers should be specific to the session that is being executed and
not to the machine perf is being run upon. These patches clean this
and associated code up.
v2: Avoid changes to include/perf/perf_dlfilter.h as suggested by
Adrian Hunter.
Ian Rogers (3):
perf sample: Remove arch notion of sample parsing
perf test: Move PERF_SAMPLE_WEIGHT_STRUCT parsing to common test
perf sort: Use perf_env to set arch sort keys and header
tools/perf/arch/powerpc/util/Build | 1 -
tools/perf/arch/powerpc/util/event.c | 60 ----------
tools/perf/arch/x86/include/arch-tests.h | 1 -
tools/perf/arch/x86/tests/Build | 1 -
tools/perf/arch/x86/tests/arch-tests.c | 2 -
tools/perf/arch/x86/tests/sample-parsing.c | 125 ---------------------
tools/perf/arch/x86/util/event.c | 46 --------
tools/perf/builtin-annotate.c | 2 +-
tools/perf/builtin-c2c.c | 53 +++++----
tools/perf/builtin-diff.c | 2 +-
tools/perf/builtin-report.c | 2 +-
tools/perf/builtin-script.c | 2 +-
tools/perf/builtin-top.c | 16 +--
tools/perf/tests/hists_cumulate.c | 8 +-
tools/perf/tests/hists_filter.c | 8 +-
tools/perf/tests/hists_link.c | 8 +-
tools/perf/tests/hists_output.c | 10 +-
tools/perf/tests/sample-parsing.c | 14 +++
tools/perf/util/dlfilter.c | 2 +-
tools/perf/util/event.h | 5 -
tools/perf/util/evsel.c | 17 ++-
tools/perf/util/hist.c | 4 +-
tools/perf/util/hist.h | 2 +-
tools/perf/util/intel-tpebs.c | 4 +-
tools/perf/util/sample.h | 5 +-
tools/perf/util/session.c | 2 +-
tools/perf/util/sort.c | 67 +++++++----
tools/perf/util/sort.h | 5 +-
tools/perf/util/synthetic-events.c | 10 +-
29 files changed, 150 insertions(+), 334 deletions(-)
delete mode 100644 tools/perf/arch/powerpc/util/event.c
delete mode 100644 tools/perf/arch/x86/tests/sample-parsing.c
--
2.49.0.1112.g889b7c5bd8-goog
next reply other threads:[~2025-05-21 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 13:54 Ian Rogers [this message]
2025-05-21 13:54 ` [PATCH v2 1/3] perf sample: Remove arch notion of sample parsing Ian Rogers
2025-05-21 15:42 ` Liang, Kan
2025-05-21 15:57 ` Ian Rogers
2025-05-21 13:54 ` [PATCH v2 2/3] perf test: Move PERF_SAMPLE_WEIGHT_STRUCT parsing to common test Ian Rogers
2025-05-21 13:54 ` [PATCH v2 3/3] perf sort: Use perf_env to set arch sort keys and header Ian Rogers
2025-05-21 15:50 ` Liang, Kan
2025-05-21 16:16 ` Ian Rogers
2025-05-21 18:13 ` Liang, Kan
2025-05-21 19:19 ` Ian Rogers
2025-05-23 14:50 ` Liang, Kan
2025-05-23 15:51 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521135500.677508-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben.gainey@arm.com \
--cc=ctshao@google.com \
--cc=dvyukov@google.com \
--cc=graham.woodward@arm.com \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@readmodwrite.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=song@kernel.org \
--cc=thomas.falcon@intel.com \
--cc=weilin.wang@intel.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).