From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"John Garry" <john.g.garry@oracle.com>,
"Will Deacon" <will@kernel.org>,
"James Clark" <james.clark@linaro.org>,
"Mike Leach" <mike.leach@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>,
"Charlie Jenkins" <charlie@rivosinc.com>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Graham Woodward" <graham.woodward@arm.com>,
"Ilkka Koskinen" <ilkka@os.amperecomputing.com>,
"Zhongqiu Han" <quic_zhonhan@quicinc.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Howard Chu" <howardchu95@gmail.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
"Levi Yun" <yeoreum.yun@arm.com>,
"Weilin Wang" <weilin.wang@intel.com>,
"Michael Petlan" <mpetlan@redhat.com>,
"Krzysztof Łopatowski" <krzysztof.m.lopatowski@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
"Chun-Tse Shao" <ctshao@google.com>,
"Ben Gainey" <ben.gainey@arm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 00/11] Remove global perf_env
Date: Mon, 26 May 2025 23:41:42 -0700 [thread overview]
Message-ID: <20250527064153.149939-1-irogers@google.com> (raw)
The global perf_env is used to hold host information, but it is also
used as a fallback in a number of cases where the information may be
bogus. Restructure the code so that the perf_env of the session is
accessed. When necessary a locally scoped host perf_env is created and
used.
Cleaning up the inconsistency was requested by Kan Liang in:
https://lore.kernel.org/lkml/c56c9e23-cf6e-4040-aee8-da13d5157dcf@linux.intel.com/
Ian Rogers (11):
perf session: Add accessor for session->header.env
perf session: Add an env pointer for the current perf_env
perf evlist: Change env variable to session
perf header: Clean up use of perf_env
perf test: Avoid use perf_env
perf top: Make perf_env locally scoped
perf session: Add host_env argument to perf_session__new
perf bench synthesize: Avoid use of global perf_env
perf machine: Explicitly pass in host perf_env
perf auxtrace: Pass perf_env from session through to mmap read
perf env: Remove global perf_env
tools/perf/bench/synthesize.c | 30 +++--
tools/perf/builtin-annotate.c | 4 +-
tools/perf/builtin-buildid-cache.c | 2 +-
tools/perf/builtin-buildid-list.c | 5 +-
tools/perf/builtin-c2c.c | 16 ++-
tools/perf/builtin-inject.c | 5 +-
tools/perf/builtin-kallsyms.c | 21 ++-
tools/perf/builtin-kmem.c | 2 +-
tools/perf/builtin-kvm.c | 4 +-
tools/perf/builtin-kwork.c | 2 +-
tools/perf/builtin-lock.c | 4 +-
tools/perf/builtin-mem.c | 2 +-
tools/perf/builtin-record.c | 30 +++--
tools/perf/builtin-report.c | 14 +-
tools/perf/builtin-sched.c | 8 +-
tools/perf/builtin-script.c | 16 ++-
tools/perf/builtin-stat.c | 23 ++--
tools/perf/builtin-timechart.c | 2 +-
tools/perf/builtin-top.c | 40 ++++--
tools/perf/builtin-trace.c | 26 ++--
tools/perf/perf.c | 3 -
tools/perf/tests/code-reading.c | 6 +-
tools/perf/tests/dlfilter-test.c | 51 ++++----
tools/perf/tests/dwarf-unwind.c | 10 +-
tools/perf/tests/mmap-thread-lookup.c | 6 +-
tools/perf/tests/symbols.c | 8 +-
tools/perf/tests/topology.c | 39 +++---
tools/perf/ui/browser.h | 4 +-
tools/perf/ui/browsers/header.c | 4 +-
tools/perf/ui/browsers/hists.c | 2 +-
tools/perf/util/amd-sample-raw.c | 2 +-
tools/perf/util/arm-spe.c | 2 +-
tools/perf/util/auxtrace.c | 13 +-
tools/perf/util/auxtrace.h | 6 +-
tools/perf/util/bpf-event.c | 2 +-
tools/perf/util/branch.c | 2 +-
tools/perf/util/data-convert-bt.c | 16 +--
tools/perf/util/data-convert-json.c | 36 +++---
tools/perf/util/env.c | 3 +-
tools/perf/util/env.h | 2 -
tools/perf/util/evlist.h | 2 +-
tools/perf/util/evsel.c | 12 +-
tools/perf/util/evsel.h | 1 +
tools/perf/util/header.c | 180 +++++++++++++++-----------
tools/perf/util/machine.c | 8 +-
tools/perf/util/machine.h | 4 +-
tools/perf/util/probe-event.c | 5 +-
tools/perf/util/s390-cpumsf.c | 2 +-
tools/perf/util/sample-raw.c | 7 +-
tools/perf/util/sample-raw.h | 2 +-
tools/perf/util/session.c | 17 ++-
tools/perf/util/session.h | 9 +-
tools/perf/util/tool.c | 2 +-
53 files changed, 424 insertions(+), 300 deletions(-)
--
2.49.0.1151.ga128411c76-goog
next reply other threads:[~2025-05-27 6:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 6:41 Ian Rogers [this message]
2025-05-27 6:41 ` [PATCH v1 01/11] perf session: Add accessor for session->header.env Ian Rogers
2025-05-27 6:41 ` [PATCH v1 02/11] perf session: Add an env pointer for the current perf_env Ian Rogers
2025-05-27 6:41 ` [PATCH v1 03/11] perf evlist: Change env variable to session Ian Rogers
2025-05-27 6:41 ` [PATCH v1 04/11] perf header: Clean up use of perf_env Ian Rogers
2025-05-27 6:41 ` [PATCH v1 05/11] perf test: Avoid use perf_env Ian Rogers
2025-05-27 6:41 ` [PATCH v1 06/11] perf top: Make perf_env locally scoped Ian Rogers
2025-05-27 6:41 ` [PATCH v1 07/11] perf session: Add host_env argument to perf_session__new Ian Rogers
2025-05-27 6:41 ` [PATCH v1 08/11] perf bench synthesize: Avoid use of global perf_env Ian Rogers
2025-05-27 6:41 ` [PATCH v1 09/11] perf machine: Explicitly pass in host perf_env Ian Rogers
2025-05-27 6:41 ` [PATCH v1 10/11] perf auxtrace: Pass perf_env from session through to mmap read Ian Rogers
2025-05-27 6:41 ` [PATCH v1 11/11] perf env: Remove global perf_env Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527064153.149939-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben.gainey@arm.com \
--cc=charlie@rivosinc.com \
--cc=christophe.leroy@csgroup.eu \
--cc=colin.i.king@gmail.com \
--cc=ctshao@google.com \
--cc=dvyukov@google.com \
--cc=graham.woodward@arm.com \
--cc=howardchu95@gmail.com \
--cc=ilkka@os.amperecomputing.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=krzysztof.m.lopatowski@gmail.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=quic_zhonhan@quicinc.com \
--cc=ravi.bangoria@amd.com \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).