From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B71B74420; Wed, 28 May 2025 15:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748447684; cv=none; b=ed9YB+ya4CZEApNJ8fpFyURuSOaBfCROJ9fovHOxg30UizWPvEx4ictFiqIZeMAtAgFWa4tbOGIILOMMPAfrWl6yHYKCeCvl3lQqMY0uveAKwdE4+ypwO98QfPQSN9Nu0M0enGnn3ovR7+4FC+zc8H0kw/5YfQj/pCG55cz7++8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748447684; c=relaxed/simple; bh=Dw/g/lE1rQzkBlq4qZ/qURcgH6xjlgUmtkzi7h8i4P8=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CpR48DMOaLLuiglhPaXw8C5Ko0bwH3NZDIoDisjaKsUDg255VyHxQ0tg7GgIawlfzG8GLIXAsmeFFMasw/SmGfJ9TwQOfX6bzl8gN38pV4dICGEM2OmXuJoVb89XjZwGBuveolR9OJhl4O1O7GsmQfIQ1320gUIZr85euZKISv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b6v9Z09hfz6H6py; Wed, 28 May 2025 23:50:58 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id E14461400CA; Wed, 28 May 2025 23:54:31 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 May 2025 17:54:31 +0200 Date: Wed, 28 May 2025 16:54:29 +0100 From: Jonathan Cameron To: Alireza Sanaee CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 1/7] of: add infra for finding CPU id from phandle Message-ID: <20250528165429.00000d4d@huawei.com> In-Reply-To: <20250512080715.82-2-alireza.sanaee@huawei.com> References: <20250512080715.82-1-alireza.sanaee@huawei.com> <20250512080715.82-2-alireza.sanaee@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500012.china.huawei.com (7.191.174.4) To frapeml500008.china.huawei.com (7.182.85.71) On Mon, 12 May 2025 09:07:09 +0100 Alireza Sanaee wrote: > Get CPU id from phandle. Many drivers get do this by getting hold of CPU > node first through a phandle and then find the CPU ID using the relevant > function. This commit encapsulates cpu node finding and improves > readability. > > The API interface requires two parameters, 1) node, 2) pointer to CPU > node. API sets the pointer to the CPU node and allows the driver to play > with the CPU itself, for logging purposes for instance. > > Signed-off-by: Alireza Sanaee > --- > drivers/of/cpu.c | 29 +++++++++++++++++++++++++++++ > include/linux/of.h | 9 +++++++++ > 2 files changed, 38 insertions(+) > > diff --git a/drivers/of/cpu.c b/drivers/of/cpu.c > index 5214dc3d05ae..fba17994fc20 100644 > --- a/drivers/of/cpu.c > +++ b/drivers/of/cpu.c > @@ -173,6 +173,35 @@ int of_cpu_node_to_id(struct device_node *cpu_node) > } > EXPORT_SYMBOL(of_cpu_node_to_id); > > +/** > + * of_cpu_phandle_to_id: Get the logical CPU number for a given device_node > + * > + * @node: Pointer to the device_node containing CPU phandle. > + * @cpu_np: Pointer to the device_node for CPU. > + * @cpu_idx: The index of the CPU in the list of CPUs. > + * > + * Return: The logical CPU number of the given CPU device_node or -ENODEV if > + * the CPU is not found, or if the node is NULL, it returns -1. On success, > + * cpu_np will always point to the retrieved CPU device_node with refcount > + * incremented, use of_node_put() on it when done. > + */ > +int of_cpu_phandle_to_id(const struct device_node *node, > + struct device_node **cpu_np, > + uint8_t cpu_idx) > +{ > + if (!node) > + return -1; > + > + *cpu_np = of_parse_phandle(node, "cpu", 0); > + if (!*cpu_np) > + *cpu_np = of_parse_phandle(node, "cpus", cpu_idx); > + if (!*cpu_np) > + return -ENODEV; Indent has gone a bit crazy here. > + > + return of_cpu_node_to_id(*cpu_np); > +} > +EXPORT_SYMBOL(of_cpu_phandle_to_id); > + > /** > * of_get_cpu_state_node - Get CPU's idle state node at the given index > * > diff --git a/include/linux/of.h b/include/linux/of.h > index eaf0e2a2b75c..194f1cb0f6c6 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -360,6 +360,8 @@ extern const void *of_get_property(const struct device_node *node, > extern struct device_node *of_get_cpu_node(int cpu, unsigned int *thread); > extern struct device_node *of_cpu_device_node_get(int cpu); > extern int of_cpu_node_to_id(struct device_node *np); > +extern int of_cpu_phandle_to_id(const struct device_node *np, > + struct device_node **cpu_np, uint8_t cpu_idx); > extern struct device_node *of_get_next_cpu_node(struct device_node *prev); > extern struct device_node *of_get_cpu_state_node(const struct device_node *cpu_node, > int index); > @@ -662,6 +664,13 @@ static inline int of_cpu_node_to_id(struct device_node *np) > return -ENODEV; > } > > +static inline int of_cpu_phandle_to_id(const struct device_node *np, > + struct device_node **cpu_np, > + uint8_t cpu_idx) > +{ > + return -ENODEV; > +} > + > static inline struct device_node *of_get_next_cpu_node(struct device_node *prev) > { > return NULL;