From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: [PATCHSET v2 0/7] perf annotate: Support --code-with-type on TUI
Date: Sat, 7 Jun 2025 16:25:33 -0700 [thread overview]
Message-ID: <20250607232540.89488-1-namhyung@kernel.org> (raw)
Hello,
The --code-with-type option is to show normal annotate output with type
information. It was supported only on --stdio, but this change adds it
to TUI as well.
v2 changes)
* use 'T' key to toggle data type display (Arnaldo)
* display '[Type]' in the title line when it's enabled (Arnaldo)
* show warning when debug info is not available (Arnaldo)
* fix a typo (Arnaldo)
Actually the command line option sets the default behavior and users can
change it by pressing 'T' key in the TUI annotate browser.
The code is also available at 'perf/annotate-code-type-tui-v2' branch at
https://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (7):
perf annotate: Rename to __hist_entry__tui_annotate()
perf annotate: Remove __annotation_line__write()
perf annotate: Pass annotation_print_data to annotation_line__write()
perf annotate: Simplify width calculation in annotation_line__write()
perf annotate: Add --code-with-type support for TUI
perf annotate: Add 'T' hot key to toggle data type display
perf annotate: Show warning when debuginfo is not available
tools/perf/Documentation/perf-annotate.txt | 1 -
tools/perf/builtin-annotate.c | 5 -
tools/perf/ui/browsers/annotate.c | 66 +++++++---
tools/perf/ui/browsers/hists.c | 2 +-
tools/perf/util/annotate.c | 146 ++++++++++++++-------
tools/perf/util/annotate.h | 27 ++--
tools/perf/util/dso.h | 11 ++
tools/perf/util/hist.h | 12 +-
8 files changed, 180 insertions(+), 90 deletions(-)
--
2.49.0
next reply other threads:[~2025-06-07 23:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 23:25 Namhyung Kim [this message]
2025-06-07 23:25 ` [PATCH v2 1/7] perf annotate: Rename to __hist_entry__tui_annotate() Namhyung Kim
2025-06-07 23:25 ` [PATCH v2 2/7] perf annotate: Remove __annotation_line__write() Namhyung Kim
2025-06-07 23:25 ` [PATCH v2 3/7] perf annotate: Pass annotation_print_data to annotation_line__write() Namhyung Kim
2025-06-07 23:25 ` [PATCH v2 4/7] perf annotate: Simplify width calculation in annotation_line__write() Namhyung Kim
2025-06-07 23:25 ` [PATCH v2 5/7] perf annotate: Add --code-with-type support for TUI Namhyung Kim
2025-06-07 23:25 ` [PATCH v2 6/7] perf annotate: Add 'T' hot key to toggle data type display Namhyung Kim
2025-06-07 23:25 ` [PATCH v2 7/7] perf annotate: Show warning when debuginfo is not available Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250607232540.89488-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).