From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A09321E08D for ; Sat, 28 Jun 2025 04:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751086238; cv=none; b=GmCazAShtoZMGV7ihxSc78KbuXHiIFTdbySHifAwC6BcYnMyCbZebKJg3BXl/6D6Bt8Db8x619g487SVNp3v8xeuqLTbzgsKlPVLKAaAD2EbDwtsONRoVWIiAQMSdY9YXcyBx50yQc7lngCtBw7ECd9cWUHRp7FoqVukjcoFH7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751086238; c=relaxed/simple; bh=6Kaw3YeDSjFMbgSGwOQqcOiX76bLmOxHdfk84Y2TCRw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=ATMalwyQXRaput7mVS1fVut5mAnO6uy/Op9ErLjJxJVwLPHXSpsAfpAWX/gJagvOHEfEAjb3cNiI7b3QQYr/9SWzOnn4XW1Hnp8LJExrIq3QNGSLJx93OnYHpvuRq35xkFYuxPNyzL985mgrtd8qrgSM7DEquOBqGuDOq3AcYoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PJ9QizWo; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PJ9QizWo" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b34ca003f1cso443480a12.2 for ; Fri, 27 Jun 2025 21:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1751086237; x=1751691037; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=gpJDjPIAX11d0UZM38x2TXJLxVO8GJl81BGUasQciyA=; b=PJ9QizWoHEea7/SLX01bTZEjA5opFbGf1aPXoKFtYdxpvyjG4NrVM2r8jOUJTyeU7/ XAKRb3k29NBgOdP6bHDO/RYyK0JY27xAIpbqL6QY7q7QpNipmElW72qQOXqrR9W3eMVU uTQ7nTpEyMMZtlb8ecRMFaKhSZwF0IoE4eRMpI4nuDYZvgYhrpmvtCQI+rmL+AheoAF7 UzQtQk1KPMqfvtpVrUU5mM6O9Y8GqRySfG8VzPH348n3ZcnVVv0CGgrFsKuwvkqKG0dN 2bL2Ew/yk+u/mechpMPMJ2uM1fLUBhqD2kZNXtftTM54wwDbBVjVSwIqXwJHihxkTt6z /dQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751086237; x=1751691037; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gpJDjPIAX11d0UZM38x2TXJLxVO8GJl81BGUasQciyA=; b=Z5s0UWaQty4UatcGszYmGGHX2fyKSu/FLfg7sqJzqy67qKPc5zwDuYT6L4yA2ifPke sNZ9qfJbH49EIvLk6MJjuEF2UXrF6ehgWcVLZBQzklSeZ0ZCwDB5NCJYbozu9Yn3q+46 A81D+1H9JRpKH4HxDxlg9k0wQlY3XbBhvujVb1uapMcadfy0r4QZaIO95bI2tt6INnl2 gkJ6t2hAT2HP1eWYelcOm0049Ec76+xWVmPjO9Zn6z6dLuAp7WJFui3HbZXaLaXguwWy 71QucE4DGRuMHO/jBOKbkdzo5kBc64LAaGFkMdFnwtapAuhy6oeZuhzpVvuuOKZWEHbz ZgBA== X-Forwarded-Encrypted: i=1; AJvYcCXUcGP19aDYPVh5HwpFmlDaX7DqUPDlr4YM5KGgylH1X+vihoTCcoZ6KvGqNvZ5GEdm1Ojpsje6EhxyiNnLEqR1@vger.kernel.org X-Gm-Message-State: AOJu0YwZZkhICwCYaIwl2T//pH3nngd+zYsoRonKIsCP5qgFTASOkHqO GjG/8vB22S28L7cMH5GeTALCT0A5kN0QTEb56Q70Ng+DODnmx6DIr5rVOX6RKWXdQBZ+cIChK1n NTifWNEElgA== X-Google-Smtp-Source: AGHT+IGWtvZQ+GufKNFStPxwXpoFd5BmjC4KaSWX/cbvB1fYzET22HcvfVJhQ9LyAFveIqQN1HBBPDZ8vvQd X-Received: from pge19.prod.google.com ([2002:a05:6a02:2d13:b0:b31:c9e0:b48]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:3387:b0:21f:5c9d:498b with SMTP id adf61e73a8af0-220a16e3a86mr8856736637.28.1751086234602; Fri, 27 Jun 2025 21:50:34 -0700 (PDT) Date: Fri, 27 Jun 2025 21:49:56 -0700 In-Reply-To: <20250628045017.1361563-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250628045017.1361563-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250628045017.1361563-3-irogers@google.com> Subject: [PATCH v5 02/23] perf build-id: Truncate to avoid overflowing the build_id data From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , "Masami Hiramatsu (Google)" , Ravi Bangoria , Charlie Jenkins , Colin Ian King , Andi Kleen , Dmitry Vyukov , Graham Woodward , Ilkka Koskinen , Zhongqiu Han , Yicong Yang , Athira Rajeev , Kajol Jain , Li Huafei , "Steinar H. Gunderson" , Stephen Brennan , Chun-Tse Shao , Yujie Liu , "Dr. David Alan Gilbert" , Levi Yun , Howard Chu , Weilin Wang , Thomas Falcon , Matt Fleming , Veronika Molnarova , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Zixian Cai , Steve Clevenger , Ben Gainey , Chaitanya S Prakash , Martin Liska , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Song Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Warning when the build_id data would be overflowed would lead to memory corruption, switch to truncation. Signed-off-by: Ian Rogers --- tools/perf/util/build-id.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index e763e8d99a43..5bc2040bdd0d 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -951,7 +951,10 @@ bool perf_session__read_build_ids(struct perf_session *session, bool with_hits) void build_id__init(struct build_id *bid, const u8 *data, size_t size) { - WARN_ON(size > BUILD_ID_SIZE); + if (size > BUILD_ID_SIZE) { + pr_debug("Truncating build_id size from %zd\n", size); + size = BUILD_ID_SIZE; + } memcpy(bid->data, data, size); bid->size = size; } -- 2.50.0.727.gbf7dc18ff4-goog