From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 163D92206BF for ; Sat, 28 Jun 2025 04:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751086244; cv=none; b=kGm/6R4EhpSCsnTE+6viJ3DLz83T7vFfgy/p+ZNkF10Cyzo/raFkXJDKcmLQZCEDjfgzf4gjaWf29aVCJMW5PO7lUFXJs/Hg7INZTGJwvIAJTobg8iY+BXxRPo0gc93B+P6OXeeQ1VLpyu/dPMST+rMv262+VRF3x5JM6dqRMWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751086244; c=relaxed/simple; bh=i87jvX210l24c7RqxS+bUYqmgL8+oZvqMbe8qDfav9Y=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=dVkjRl4dlIIEd8HlT3w7ViR8q/1cXW/dgSkHShLB5pOzq4SzKUmuOp/Up6COlN2WHPgb0bDs7ybX7Vsz6DVujf/omzarIZLFl8QvJbVPE3u6V36yLAYIeml3HBuAWhi0t5Qg3V4k37XISuuNFvT2LBS1y/qefyIi1qEmqhwd5Ok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aJ+jm1rN; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aJ+jm1rN" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-74880a02689so2412754b3a.0 for ; Fri, 27 Jun 2025 21:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1751086242; x=1751691042; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=62dSX49aFLikEjIUMEVRlCmIJbHK4eeNScGSo/Mzprs=; b=aJ+jm1rNOBubjVU9ObHed7zV966+EE3F08U9Iq11pfrqyPe/kZtiLrt9kIE1RVEreD kgWGX8AEe0HqLDZ038FEkXCzIkdnHjc8kM0Xd6NroJv7eTwuU29u7mgp+Gzg0+9pr3du c4+pH+hxuuVrnGW+ZMAkRAIwA6CMDqnVFrEvB5j//hc35DKUtRgorTnJTPEtmpQbPEvD hoMmVE1oRPRlzTGwLKA5C+8EAb2y/M4GI7+GkrJoWyeKd1PMKSNotvInJv++jBY/DwpX LMkfJzxOn5GBhW96Rq71vpnvoac9GdxXVP3M8xpLiZ6gXgTLW4Cyk2WkUEkn8ANYPZK5 mSdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751086242; x=1751691042; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=62dSX49aFLikEjIUMEVRlCmIJbHK4eeNScGSo/Mzprs=; b=mD4gOabS/3Yllw4chw2dylP0z1XnjYZdm2ZJVkz3jhNEXPME3XuEHJSlnuuADfy08M 15oIa6iDr3tdYvQL5A69c7V3z1Y69kjxwUkAluNcCb1CHmzlwdspuAKIwJYO1xZHaTbR 4J2/3n0wjOmK5kX19h8gN9NWbEXP3QMhfglzzPzeKmTLadU+dfLP0RywqkQfDBKNh4Qo a7nVaWdEW8A5cqV3rsHJ4BdPCdsa/AQAMO75c49SV7MtzSfabfF2sfeUBaKbUYygDYEs lbI1bOFXgSfNZeUbrYK9gUP4O/BobzBhK21f693Z9KwXMv86n3kB+AMtIRlhYmNxHFuf 7/xA== X-Forwarded-Encrypted: i=1; AJvYcCUoSHLQyU1rd7QH7ppugYn04pD8tLr1Qry8cBtYnnpa8XHo5hdsC+o1o9864rRgh2Wfvzh6nF9Vfa6lyCYch0Pu@vger.kernel.org X-Gm-Message-State: AOJu0YzNIJlZsiE5APHZcBDB/gU1moWb4YT8JpC/g5jLGzK/8Dpf+6VZ fLouNZfe6M4p++/IoBWRZne7WQauo0bi7nQ7Yjgn1yiJmRVjEx+IKqDeYxWgo2N8gIivFCqWCPj PZNP115pODQ== X-Google-Smtp-Source: AGHT+IG99HEcqbVp6hJeqxokNAhzYk5D92KArJfEufqUq/84mgt0/AFPB7xsfDOz0Rde1yeTQ+0ZMo1csF9L X-Received: from pfbfb10.prod.google.com ([2002:a05:6a00:2d8a:b0:747:af58:72ca]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:3d55:b0:740:9d7c:aeb9 with SMTP id d2e1a72fcca58-74af6fd703bmr7302327b3a.21.1751086240144; Fri, 27 Jun 2025 21:50:40 -0700 (PDT) Date: Fri, 27 Jun 2025 21:49:58 -0700 In-Reply-To: <20250628045017.1361563-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250628045017.1361563-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250628045017.1361563-5-irogers@google.com> Subject: [PATCH v5 04/23] perf build-id: Mark DSO in sample callchains From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , "Masami Hiramatsu (Google)" , Ravi Bangoria , Charlie Jenkins , Colin Ian King , Andi Kleen , Dmitry Vyukov , Graham Woodward , Ilkka Koskinen , Zhongqiu Han , Yicong Yang , Athira Rajeev , Kajol Jain , Li Huafei , "Steinar H. Gunderson" , Stephen Brennan , Chun-Tse Shao , Yujie Liu , "Dr. David Alan Gilbert" , Levi Yun , Howard Chu , Weilin Wang , Thomas Falcon , Matt Fleming , Veronika Molnarova , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Zixian Cai , Steve Clevenger , Ben Gainey , Chaitanya S Prakash , Martin Liska , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Song Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Previously only the sample IP's map DSO would be marked hit for the purposes of populating the build ID cache. Walk the call chain to mark all IPs and DSOs. Signed-off-by: Ian Rogers --- tools/perf/util/build-id.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index aa35dceace90..3386fa8e1e7e 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -42,10 +42,20 @@ static bool no_buildid_cache; +static int mark_dso_hit_callback(struct callchain_cursor_node *node, void *data __maybe_unused) +{ + struct map *map = node->ms.map; + + if (map) + dso__set_hit(map__dso(map)); + + return 0; +} + int build_id__mark_dso_hit(const struct perf_tool *tool __maybe_unused, union perf_event *event, struct perf_sample *sample, - struct evsel *evsel __maybe_unused, + struct evsel *evsel, struct machine *machine) { struct addr_location al; @@ -63,6 +73,11 @@ int build_id__mark_dso_hit(const struct perf_tool *tool __maybe_unused, dso__set_hit(map__dso(al.map)); addr_location__exit(&al); + + sample__for_each_callchain_node(thread, evsel, sample, PERF_MAX_STACK_DEPTH, + /*symbols=*/false, mark_dso_hit_callback, /*data=*/NULL); + + thread__put(thread); return 0; } -- 2.50.0.727.gbf7dc18ff4-goog