From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>, Howard Chu <howardchu95@gmail.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Levi Yun <yeoreum.yun@arm.com>, Andi Kleen <ak@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Weilin Wang <weilin.wang@intel.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Gautam Menghani <gautam@linux.ibm.com>,
Thomas Falcon <thomas.falcon@intel.com>,
Chun-Tse Shao <ctshao@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 10/13] perf python: Fix thread check in pyrf_evsel__read
Date: Thu, 10 Jul 2025 16:51:23 -0700 [thread overview]
Message-ID: <20250710235126.1086011-11-irogers@google.com> (raw)
In-Reply-To: <20250710235126.1086011-1-irogers@google.com>
The CPU index is incorrectly checked rather than the thread index.
Fixes: 739621f65702 ("perf python: Add evsel read method")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/python.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
index 0821205b1aaa..4a3c2b4dd79f 100644
--- a/tools/perf/util/python.c
+++ b/tools/perf/util/python.c
@@ -910,7 +910,7 @@ static PyObject *pyrf_evsel__read(struct pyrf_evsel *pevsel,
return NULL;
}
thread_idx = perf_thread_map__idx(evsel->core.threads, thread);
- if (cpu_idx < 0) {
+ if (thread_idx < 0) {
PyErr_Format(PyExc_TypeError, "Thread %d is not part of evsel's threads",
thread);
return NULL;
--
2.50.0.727.gbf7dc18ff4-goog
next prev parent reply other threads:[~2025-07-10 23:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 23:51 [PATCH v2 00/13] Python motivated fixes and cleanup Ian Rogers
2025-07-10 23:51 ` [PATCH v2 01/13] perf hwmon_pmu: Avoid shortening hwmon PMU name Ian Rogers
2025-07-10 23:51 ` [PATCH v2 02/13] perf parse-events: Minor tidy up of event_type helper Ian Rogers
2025-07-10 23:51 ` [PATCH v2 03/13] perf spark: Fix includes and add SPDX Ian Rogers
2025-07-10 23:51 ` [PATCH v2 04/13] perf pmu: Tolerate failure to read the type for wellknown PMUs Ian Rogers
2025-07-10 23:51 ` [PATCH v2 05/13] perf metricgroup: Factor out for-each function and move out printing Ian Rogers
2025-07-10 23:51 ` [PATCH v2 06/13] perf stat: Move metric list from config to evlist Ian Rogers
2025-07-10 23:51 ` [PATCH v2 07/13] perf expr: Accumulate rather than replace in the context counts Ian Rogers
2025-07-10 23:51 ` [PATCH v2 08/13] perf jevents: If the long_desc and desc are identical then drop the long_desc Ian Rogers
2025-07-10 23:51 ` [PATCH v2 09/13] perf python: In str(evsel) use the evsel__pmu_name helper Ian Rogers
2025-07-10 23:51 ` Ian Rogers [this message]
2025-07-10 23:51 ` [PATCH v2 11/13] perf python: Correct pyrf_evsel__read for tool PMUs Ian Rogers
2025-07-10 23:51 ` [PATCH v2 12/13] perf python: Improve leader copying from evlist Ian Rogers
2025-07-10 23:51 ` [PATCH v2 13/13] perf python: Set index error for invalid thread/cpu map items Ian Rogers
2025-07-14 5:15 ` [PATCH v2 00/13] Python motivated fixes and cleanup Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710235126.1086011-11-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ctshao@google.com \
--cc=gautam@linux.ibm.com \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
--cc=tmricht@linux.ibm.com \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
--cc=yangtiezhu@loongson.cn \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).