From: Suchit Karunakaran <suchitkarunakaran@gmail.com>
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com
Cc: linux-perf-users@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
Suchit Karunakaran <suchitkarunakaran@gmail.com>
Subject: [PATCH v2] perf stat: Fix JSON output formatting in iostat_prefix()
Date: Sun, 13 Jul 2025 20:42:24 +0530 [thread overview]
Message-ID: <20250713151224.43764-1-suchitkarunakaran@gmail.com> (raw)
The iostat_prefix() function previously included a TODO noting that its output
format was incorrect in JSON mode. This patch corrects that by conditionally
formatting the prefix string based on the output mode specified in
perf_stat_config. Note, I didn't test it since my system doesn't support
it.
Signed-off-by: Suchit Karunakaran <suchitkarunakaran@gmail.com>
---
tools/perf/arch/x86/util/iostat.c | 40 +++++++++++++++++++++----------
1 file changed, 28 insertions(+), 12 deletions(-)
Changes since v1:
- Fix issues in formatting
diff --git a/tools/perf/arch/x86/util/iostat.c b/tools/perf/arch/x86/util/iostat.c
index 7442a2cd87ed..d7ae19fb83e5 100644
--- a/tools/perf/arch/x86/util/iostat.c
+++ b/tools/perf/arch/x86/util/iostat.c
@@ -403,18 +403,34 @@ void iostat_prefix(struct evlist *evlist,
struct iio_root_port *rp = evlist->selected->priv;
if (rp) {
- /*
- * TODO: This is the incorrect format in JSON mode.
- * See prepare_timestamp()
- */
- if (ts)
- sprintf(prefix, "%6lu.%09lu%s%04x:%02x%s",
- ts->tv_sec, ts->tv_nsec,
- config->csv_sep, rp->domain, rp->bus,
- config->csv_sep);
- else
- sprintf(prefix, "%04x:%02x%s", rp->domain, rp->bus,
- config->csv_sep);
+ if (config->json_output) {
+ if (ts) {
+ double timestamp = ts->tv_sec + (double)ts->tv_nsec / 1e9;
+ sprintf(prefix, "{\"interval\": %.6f, \"device\": \"%04x:%02x\", ",
+ timestamp, rp->domain, rp->bus);
+ } else {
+ sprintf(prefix, "{\"device\": \"%04x:%02x\", ",
+ rp->domain, rp->bus);
+ }
+ } else if (config->csv_output) {
+ if (ts) {
+ sprintf(prefix, "%lu.%09lu%s%04x:%02x%s",
+ (unsigned long)ts->tv_sec, ts->tv_nsec,
+ config->csv_sep, rp->domain, rp->bus, config->csv_sep);
+ } else {
+ sprintf(prefix, "%04x:%02x%s",
+ rp->domain, rp->bus, config->csv_sep);
+ }
+ } else {
+ if (ts) {
+ sprintf(prefix, "%6lu.%09lu %04x:%02x ",
+ (unsigned long)ts->tv_sec, ts->tv_nsec,
+ rp->domain, rp->bus);
+ } else {
+ sprintf(prefix, "%04x:%02x ",
+ rp->domain, rp->bus);
+ }
+ }
}
}
--
2.50.1
next reply other threads:[~2025-07-13 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-13 15:12 Suchit Karunakaran [this message]
2025-07-18 18:03 ` [PATCH v2] perf stat: Fix JSON output formatting in iostat_prefix() Namhyung Kim
2025-07-22 16:09 ` Suchit K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250713151224.43764-1-suchitkarunakaran@gmail.com \
--to=suchitkarunakaran@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).