From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Alireza Sanaee <alireza.sanaee@huawei.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<coresight@lists.linaro.org>, <dianders@chromium.org>,
<james.clark@linaro.org>, <krzk@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-perf-users@vger.kernel.org>, <linuxarm@huawei.com>,
<mark.rutland@arm.com>, <mike.leach@linaro.org>,
<robh@kernel.org>, <ruanjinjie@huawei.com>,
<saravanak@google.com>, <shameerali.kolothum.thodi@huawei.com>,
<suzuki.poulose@arm.com>
Subject: Re: [PATCH v3 6/6] perf/arm-dsu: refactor cpu id retrieval via new API of_cpu_phandle_to_id
Date: Fri, 18 Jul 2025 12:15:40 +0100 [thread overview]
Message-ID: <20250718121540.000008d4@huawei.com> (raw)
In-Reply-To: <20250718094848.587-7-alireza.sanaee@huawei.com>
On Fri, 18 Jul 2025 10:48:48 +0100
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> Update arm-dsu to use the new API (of_cpu_phandle_to_id).
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> drivers/perf/arm_dsu_pmu.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c
> index cb4fb59fe04b..8f76bd94349c 100644
> --- a/drivers/perf/arm_dsu_pmu.c
> +++ b/drivers/perf/arm_dsu_pmu.c
> @@ -591,17 +591,12 @@ static struct dsu_pmu *dsu_pmu_alloc(struct platform_device *pdev)
> static int dsu_pmu_dt_get_cpus(struct device *dev, cpumask_t *mask)
> {
> int i = 0, n, cpu;
> - struct device_node *cpu_node;
>
> n = of_count_phandle_with_args(dev->of_node, "cpus", NULL);
> if (n <= 0)
> return -ENODEV;
> for (; i < n; i++) {
> - cpu_node = of_parse_phandle(dev->of_node, "cpus", i);
> - if (!cpu_node)
> - break;
> - cpu = of_cpu_node_to_id(cpu_node);
> - of_node_put(cpu_node);
> + cpu = of_cpu_phandle_to_id(dev->of_node, NULL, i);
> /*
> * We have to ignore the failures here and continue scanning
> * the list to handle cases where the nr_cpus could be capped
prev parent reply other threads:[~2025-07-18 11:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 9:48 [PATCH v3 0/6] Refactoring finding CPU phandles in DT Alireza Sanaee
2025-07-18 9:48 ` [PATCH v3 1/6] of: add infra for finding CPU id from phandle Alireza Sanaee
2025-07-18 11:10 ` Jonathan Cameron
2025-07-21 0:30 ` Rob Herring (Arm)
2025-07-18 9:48 ` [PATCH v3 2/6] arch_topology: drop the use of cpu_node in the pr_info Alireza Sanaee
2025-07-18 11:12 ` Jonathan Cameron
2025-07-18 9:48 ` [PATCH v3 3/6] arch_topology: update CPU map to use of_cpu_phandle_to_id Alireza Sanaee
2025-07-18 11:14 ` Jonathan Cameron
2025-07-18 9:48 ` [PATCH v3 4/6] coresight: cti: Use of_cpu_phandle_to_id for grabbing CPU id Alireza Sanaee
2025-07-18 11:14 ` Jonathan Cameron
2025-07-18 9:48 ` [PATCH v3 5/6] coresight: Use of_cpu_phandle_to_id for grabbing CPU ID Alireza Sanaee
2025-07-18 12:59 ` Mike Leach
2025-07-18 9:48 ` [PATCH v3 6/6] perf/arm-dsu: refactor cpu id retrieval via new API of_cpu_phandle_to_id Alireza Sanaee
2025-07-18 11:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718121540.000008d4@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alireza.sanaee@huawei.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=james.clark@linaro.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=saravanak@google.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).