* [PATCH] perf/core: Replace memset(0) + strscpy() with strscpy_pad()
@ 2025-08-11 9:16 Thorsten Blum
0 siblings, 0 replies; only message in thread
From: Thorsten Blum @ 2025-08-11 9:16 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Liang, Kan
Cc: Thorsten Blum, linux-perf-users, linux-kernel
Replace memset(0) followed by strscpy() with strscpy_pad() to improve
perf_event_comm_event(). This avoids zeroing the memory before copying
the string and ensures the destination buffer is only written to once,
simplifying the code and improving efficiency.
Use the return value of strscpy_pad() instead of calling strlen() again.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
kernel/events/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 22fdf0c187cd..69b4a32befec 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8961,9 +8961,8 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event)
char comm[TASK_COMM_LEN];
unsigned int size;
- memset(comm, 0, sizeof(comm));
- strscpy(comm, comm_event->task->comm);
- size = ALIGN(strlen(comm)+1, sizeof(u64));
+ size = strscpy_pad(comm, comm_event->task->comm);
+ size = ALIGN(size + 1, sizeof(u64));
comm_event->comm = comm;
comm_event->comm_size = size;
--
2.50.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-08-11 9:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-11 9:16 [PATCH] perf/core: Replace memset(0) + strscpy() with strscpy_pad() Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).