From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28C624414 for ; Mon, 11 Aug 2025 09:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754903833; cv=none; b=He5ci4au6Q8EtS1NYsepmvcyPLCg9sQfiZxNugyyHWXZbmq0zw5Mr7xOeoJQeBJ0NtoM7l4sz1z9AEeMFBLySUwdo+8eI/Y1n3D5PJwWIdjf2S2Pq8dTUIZKCDQQmorPU3WFFzRpY7hlZ8XTIERnDnEdiwk3Bh8S3pAJ1Jq+fIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754903833; c=relaxed/simple; bh=bKwsoygsR7tMhkIbEETxfhvbjHfKfeVCH0s5cCKy17o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bRNcmEEhSBPaH+6UbRmNqp5m5LfMiACkAiFGv+Y3wKfpgfSaMON8vixaSsRUmHlHFwSXok3aTVCYVT3IXNDOtWjVLZzdd7XqD0tki6rnKtKtCckBc8RxfCXhO3ocS+zh1L1ImkYWDCab/FlUsUoXludpx77GpztwSkLspgbPnUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=U2BGN5aV; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="U2BGN5aV" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1754903819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MNy7VvpanJVKEDboZ1rxz1ziHdpr9LUy0BLz2oY1q+U=; b=U2BGN5aVeWInjpQ0gkcC9om2fNYwxGBNi50sQ9z2X1blz2TLABSjljT0Am1riD6W4nquaV 03Nps5q5t/Pf5zWzfGvlYxp/h52J6zov/nvB7h0s8WeVV4eEx+mvOUMSfv4P9lHFsbMJfO VXZfLpziPb6T65c9pxuOIx9GUfF3EDw= From: Thorsten Blum To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" Cc: Thorsten Blum , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] perf/core: Replace memset(0) + strscpy() with strscpy_pad() Date: Mon, 11 Aug 2025 11:16:38 +0200 Message-ID: <20250811091637.4492-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Replace memset(0) followed by strscpy() with strscpy_pad() to improve perf_event_comm_event(). This avoids zeroing the memory before copying the string and ensures the destination buffer is only written to once, simplifying the code and improving efficiency. Use the return value of strscpy_pad() instead of calling strlen() again. Signed-off-by: Thorsten Blum --- kernel/events/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 22fdf0c187cd..69b4a32befec 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8961,9 +8961,8 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event) char comm[TASK_COMM_LEN]; unsigned int size; - memset(comm, 0, sizeof(comm)); - strscpy(comm, comm_event->task->comm); - size = ALIGN(strlen(comm)+1, sizeof(u64)); + size = strscpy_pad(comm, comm_event->task->comm); + size = ALIGN(size + 1, sizeof(u64)); comm_event->comm = comm; comm_event->comm_size = size; -- 2.50.1