From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 462ED2E040E for ; Thu, 21 Aug 2025 22:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755814724; cv=none; b=r9wxrYBQsBSrVT30PkIYYKcng0MhkcSc8+DSAChfUzKYQ6vD9gQ+sEOp9nNnIyJV2q1UlBrK9Ktu8w9epHhfN84L2zDcKpPkXKamhB947AfL39iWaXXsl8AKBhF/TW6ocu0fhjj4EiaXrMOCQuwHKiCSjQIraFEJShYwvsZvnIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755814724; c=relaxed/simple; bh=J7ChrngqpcfMVz2fjEKux0G9mXXIk8ji2VlMy8Zpuqs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=Gnmp2NVnBh/RZTXhdHRDI7l3I37lIYovnxXk7X05L43s7AkSvKXyjE8Gmt+6TQXCYOEoLtqxBURFAx5C+ftbmVDGdifu4K8WegxoTJnD8CU0adbfP5aVJ7TfXREzeqj/PS9pxq5mbfbRve88lvuIpjLXVTVIaCYk+XCVo0/T+8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kaUGfGV7; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kaUGfGV7" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3251d634cdbso153755a91.1 for ; Thu, 21 Aug 2025 15:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755814722; x=1756419522; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=1+LcGUNRQ5RMIFxRYxYFNAWt5Jv3NM5GtSeI5RVke4w=; b=kaUGfGV7wGherh3zcrd2gLDql1rMqFWRGoVB9r7jrc8rguNkx3hPkOKIGiyLlPvSzp H+nFBnofdoAe34N0mPWz9FBCz6SVX4sBQShtKB0BYZoJKWOU5hdRzG/XlIS45ma+wS1M UqM5lBymgx6n6l6VvPTNP/nFg13j+KR4O414YCA6316a0AHwemqeGfL+BYQc+61FgXlN aZmZaOUP3o5RMQ38i3jALaK4mv2yn4ZBkQNSJkpBAaxzSbBOZ/vw7eYvwlRyuHVNs1Rd 2Xs1B3Xbz/PNzTbJabZahP5ONWUZuKnoJGMkDB8BY971XczuAsXhVOFw3qALMFcY+6bd qCDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755814722; x=1756419522; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1+LcGUNRQ5RMIFxRYxYFNAWt5Jv3NM5GtSeI5RVke4w=; b=RHEZpfACG6dm6nO9frblJsgaDUHTNv3RzwNAG5F7XsEqxUXZDXSBD0I48uqgZTGHMe t5Im2xB13KgT/RZxvAMkp0fSDGfl9hFW+USQlNlmIhUPB7QmXemOnnmazf8cNjlRbLT+ SBbaAmDada7+YChKRLMD5pawz15Ek1Xa4b5uuE4F/9MuhgsD/taaQzrkN95SYcHsI2hb 21LqaEvfjBmMv/2+PMv++DU10XWlWcIACNYCjsl1zLzWU/YXoqEj+TW7Zi5TPV9c9Bx9 1lFK2sILFWwl8St/POHzFOm3+OHwUmt9IMWh0sur5mTAjVy3nyoXSlF/YVYo7SDqk8vu p9Wg== X-Forwarded-Encrypted: i=1; AJvYcCW0rqmvN5onEQhe999TAECwspGQkAUtLF9PO+a5tUqLsfZDJxQ5c5tOzw4vBZvq4SX0STEUnwbQ6WhLy8zkeg/2@vger.kernel.org X-Gm-Message-State: AOJu0YwutatFcMqtX1sKcomcxSZMc3GqKn0yLNcZSDv57dI7z8iA7szM nNW6IDYN4toRBe/++A6guUD5j3MW0U5Gfpkv025vRx+Pt8ik1lhOki3rBbroVjelgJKHV2mnaj+ UnWN4Ka5S5g== X-Google-Smtp-Source: AGHT+IFRjX/YkmMOyRzOeSEN3Qyl0b3TIZqfvF6f2Y1S8hBFFf5SoflTeJWXoMaNozCBAlu/0mWo3kcVYOG3 X-Received: from pjyp4.prod.google.com ([2002:a17:90a:e704:b0:321:6924:af9a]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1d06:b0:324:e03a:662e with SMTP id 98e67ed59e1d1-32515eaeeecmr1419681a91.23.1755814722551; Thu, 21 Aug 2025 15:18:42 -0700 (PDT) Date: Thu, 21 Aug 2025 15:18:31 -0700 In-Reply-To: <20250821221834.1312002-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250821221834.1312002-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog Message-ID: <20250821221834.1312002-2-irogers@google.com> Subject: [PATCH v1 1/4] perf test shell lbr: Avoid failures with perf event paranoia From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Chun-Tse Shao , James Clark , Howard Chu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" When not running as root and with higher perf event paranoia values the perf record LBR tests could fail rather than skipping the problematic tests. Add the sensitivity to the test and confirm it passes with paranoia values from -1 to 2. Fixes: 32559b99e0f5 ("perf test: Add set of perf record LBR tests") Signed-off-by: Ian Rogers --- tools/perf/tests/shell/record_lbr.sh | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/tools/perf/tests/shell/record_lbr.sh b/tools/perf/tests/shell/record_lbr.sh index 6fcb5e52b9b4..78a02e90ece1 100755 --- a/tools/perf/tests/shell/record_lbr.sh +++ b/tools/perf/tests/shell/record_lbr.sh @@ -4,6 +4,10 @@ set -e +ParanoidAndNotRoot() { + [ "$(id -u)" != 0 ] && [ "$(cat /proc/sys/kernel/perf_event_paranoid)" -gt $1 ] +} + if [ ! -f /sys/bus/event_source/devices/cpu/caps/branches ] && [ ! -f /sys/bus/event_source/devices/cpu_core/caps/branches ] then @@ -23,6 +27,7 @@ cleanup() { } trap_cleanup() { + echo "Unexpected signal in ${FUNCNAME[1]}" cleanup exit 1 } @@ -123,8 +128,11 @@ lbr_test "-j ind_call" "any indirect call" 2 lbr_test "-j ind_jmp" "any indirect jump" 100 lbr_test "-j call" "direct calls" 2 lbr_test "-j ind_call,u" "any indirect user call" 100 -lbr_test "-a -b" "system wide any branch" 2 -lbr_test "-a -j any_call" "system wide any call" 2 +if ! ParanoidAndNotRoot 1 +then + lbr_test "-a -b" "system wide any branch" 2 + lbr_test "-a -j any_call" "system wide any call" 2 +fi # Parallel parallel_lbr_test "-b" "parallel any branch" 100 & @@ -141,10 +149,16 @@ parallel_lbr_test "-j call" "parallel direct calls" 100 & pid6=$! parallel_lbr_test "-j ind_call,u" "parallel any indirect user call" 100 & pid7=$! -parallel_lbr_test "-a -b" "parallel system wide any branch" 100 & -pid8=$! -parallel_lbr_test "-a -j any_call" "parallel system wide any call" 100 & -pid9=$! +if ParanoidAndNotRoot 1 +then + pid8= + pid9= +else + parallel_lbr_test "-a -b" "parallel system wide any branch" 100 & + pid8=$! + parallel_lbr_test "-a -j any_call" "parallel system wide any call" 100 & + pid9=$! +fi for pid in $pid1 $pid2 $pid3 $pid4 $pid5 $pid6 $pid7 $pid8 $pid9 do -- 2.51.0.rc2.233.g662b1ed5c5-goog