From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BE261DFDAB; Mon, 1 Sep 2025 13:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756734054; cv=none; b=JmYXUa4lX56z7trJ2PKAYjY9yMDmIDrQo2ZnxcDb9lwErhlssTuUudW83KJlstdwo9YBPhzD0vkkybffAOItw8ZVBl4DGRxuVXA0Oxvm+/voUDEhBiphZpAsAZunc1E+kPyy88Cf5qvsfrBDtG7Jqz94a1MMwSlo1gYQj1s3XxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756734054; c=relaxed/simple; bh=Vu1T9oeflFwwseH4UwYLoCDw2rg5tyF7d+uoYsIwX14=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oGPXpolACKGEImyGEpjiN+JpGnp6SHOeax9t7su7JBX23XHco0DrMz8t3zZ9JrVGmtJKr0s12WurnncebI2v94IosMe2XLU6k9Jqui4p2KeyEnoflho8YKi4mfADYWbAtLqLAD9ojnt5HmsQsDYmz49K3/KyWfXz4488DR3lNck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XWheIfvn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XWheIfvn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C596BC4CEF0; Mon, 1 Sep 2025 13:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756734053; bh=Vu1T9oeflFwwseH4UwYLoCDw2rg5tyF7d+uoYsIwX14=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XWheIfvndLQvsXjP9U9awyBD8J03c71fo0eZYwRkAVaSegGnB6M8yAG84hKFTZ6pZ WXUaILTjS2ome/lQZpmjWti4uXFiuyVUrpb9MBiadk9IDgWiqsTu18BgRH0di+kN+h LhDkQjUzZNb6xENCZSOEF3wUqwM8kDc47n+sPCWgnRb4uQtSbYTCcKsSPLQDxajL6l 8PCIX1xJqXAxtHfu/yVArx49jdplr7KtB0xl0XPUm7rKpZaxJekitWoIygF9KUi4LH 2uqg/WgQVetTvdXYGzfVDRG1BiHpS1CgspIql52DpnP1dj2X6wrwoCXbq5RLo6BYf+ T+aIQ2gltLbOg== Date: Mon, 1 Sep 2025 15:40:26 +0200 From: Christian Brauner To: schuster.simon@siemens-energy.com Cc: Dinh Nguyen , Arnd Bergmann , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Guo Ren , Oleg Nesterov , Jens Axboe , Alexander Viro , Jan Kara , Tejun Heo , Johannes Weiner , Michal =?utf-8?Q?Koutn=C3=BD?= , Paul Moore , Serge Hallyn , James Morris , "Serge E. Hallyn" , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Masami Hiramatsu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , John Johansen , Stephen Smalley , Ondrej Mosnacek , Kentaro Takeda , Tetsuo Handa , Richard Henderson , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, apparmor@lists.ubuntu.com, selinux@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/4] nios2: Add architecture support for clone3 Message-ID: <20250901-lammfell-kaninchen-c160a69e6b36@brauner> References: <20250901-nios2-implement-clone3-v2-0-53fcf5577d57@siemens-energy.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250901-nios2-implement-clone3-v2-0-53fcf5577d57@siemens-energy.com> On Mon, Sep 01, 2025 at 03:09:49PM +0200, Simon Schuster via B4 Relay wrote: > This series adds support for the clone3 system call to the nios2 > architecture. This addresses the build-time warning "warning: clone3() I did not expect that to happen or matter but fine. > entry point is missing, please fix" introduced in 505d66d1abfb9 > ("clone3: drop __ARCH_WANT_SYS_CLONE3 macro"). The implementation passes > the relevant clone3 tests of kselftest when applied on top of > next-20250815: > > ./run_kselftest.sh > TAP version 13 > 1..4 > # selftests: clone3: clone3 > ok 1 selftests: clone3: clone3 > # selftests: clone3: clone3_clear_sighand > ok 2 selftests: clone3: clone3_clear_sighand > # selftests: clone3: clone3_set_tid > ok 3 selftests: clone3: clone3_set_tid > # selftests: clone3: clone3_cap_checkpoint_restore > ok 4 selftests: clone3: clone3_cap_checkpoint_restore > > The series also includes a small patch to kernel/fork.c that ensures > that clone_flags are passed correctly on architectures where unsigned > long is insufficient to store the u64 clone_flags. It is marked as a fix > for stable backporting. > > As requested, in v2, this series now further tries to correct this type > error throughout the whole code base. Thus, it now touches a larger > number of subsystems and all architectures. I've reworked copy_thread()/copy_thread_tls() a few years ago but I don't remember why I didn't switch to a u64 for them. Probably because only CLONE_VM and CLONE_SETTLS mattered. Thanks for doing that. > Therefore, another test was performed for ARCH=x86_64 (as a > representative for 64-bit architectures). Here, the series builds cleanly > without warnings on defconfig with CONFIG_SECURITY_APPARMOR=y and > CONFIG_SECURITY_TOMOYO=y (to compile-check the LSM-related changes). > The build further successfully passes testing/selftests/clone3 (with the > patch from 20241105062948.1037011-1-zhouyuhang1010@163.com to prepare > clone3_cap_checkpoint_restore for compatibility with the newer libcap > version on my system). > > Is there any option to further preflight check this patch series via > lkp/KernelCI/etc. for a broader test across architectures, or is this > degree of testing sufficient to eventually get the series merged? > > N.B.: The series is not checkpatch clean right now: > - include/linux/cred.h, include/linux/mnt_namespace.h: > function definition arguments without identifier name > - include/trace/events/task.h: > space prohibited after that open parenthesis > > I did not fix these warnings to keep my changes minimal and reviewable, > as the issues persist throughout the files and they were not introduced > by me; I only followed the existing code style and just replaced the > types. If desired, I'd be happy to make the changes in a potential v3, > though. > > Signed-off-by: Simon Schuster > --- > Changes in v2: > - Introduce "Fixes:" and "Cc: stable@vger.kernel.org" where necessary > - Factor out "Fixes:" when adapting the datatype of clone_flags for > easier backports > - Fix additional instances where `unsigned long` clone_flags is used > - Reword commit message to make it clearer that any 32-bit arch is > affected by this bug > - Link to v1: https://lore.kernel.org/r/20250821-nios2-implement-clone3-v1-0-1bb24017376a@siemens-energy.com > > --- > Simon Schuster (4): > copy_sighand: Handle architectures where sizeof(unsigned long) < sizeof(u64) > copy_process: pass clone_flags as u64 across calltree > arch: copy_thread: pass clone_flags as u64 > nios2: implement architecture-specific portion of sys_clone3 > > arch/alpha/kernel/process.c | 2 +- > arch/arc/kernel/process.c | 2 +- > arch/arm/kernel/process.c | 2 +- > arch/arm64/kernel/process.c | 2 +- > arch/csky/kernel/process.c | 2 +- > arch/hexagon/kernel/process.c | 2 +- > arch/loongarch/kernel/process.c | 2 +- > arch/m68k/kernel/process.c | 2 +- > arch/microblaze/kernel/process.c | 2 +- > arch/mips/kernel/process.c | 2 +- > arch/nios2/include/asm/syscalls.h | 1 + > arch/nios2/include/asm/unistd.h | 2 -- > arch/nios2/kernel/entry.S | 6 ++++++ > arch/nios2/kernel/process.c | 2 +- > arch/nios2/kernel/syscall_table.c | 1 + > arch/openrisc/kernel/process.c | 2 +- > arch/parisc/kernel/process.c | 2 +- > arch/powerpc/kernel/process.c | 2 +- > arch/riscv/kernel/process.c | 2 +- > arch/s390/kernel/process.c | 2 +- > arch/sh/kernel/process_32.c | 2 +- > arch/sparc/kernel/process_32.c | 2 +- > arch/sparc/kernel/process_64.c | 2 +- > arch/um/kernel/process.c | 2 +- > arch/x86/include/asm/fpu/sched.h | 2 +- > arch/x86/include/asm/shstk.h | 4 ++-- > arch/x86/kernel/fpu/core.c | 2 +- > arch/x86/kernel/process.c | 2 +- > arch/x86/kernel/shstk.c | 2 +- > arch/xtensa/kernel/process.c | 2 +- > block/blk-ioc.c | 2 +- > fs/namespace.c | 2 +- > include/linux/cgroup.h | 4 ++-- > include/linux/cred.h | 2 +- > include/linux/iocontext.h | 6 +++--- > include/linux/ipc_namespace.h | 4 ++-- > include/linux/lsm_hook_defs.h | 2 +- > include/linux/mnt_namespace.h | 2 +- > include/linux/nsproxy.h | 2 +- > include/linux/pid_namespace.h | 4 ++-- > include/linux/rseq.h | 4 ++-- > include/linux/sched/task.h | 2 +- > include/linux/security.h | 4 ++-- > include/linux/sem.h | 4 ++-- > include/linux/time_namespace.h | 4 ++-- > include/linux/uprobes.h | 4 ++-- > include/linux/user_events.h | 4 ++-- > include/linux/utsname.h | 4 ++-- > include/net/net_namespace.h | 4 ++-- > include/trace/events/task.h | 6 +++--- > ipc/namespace.c | 2 +- > ipc/sem.c | 2 +- > kernel/cgroup/namespace.c | 2 +- > kernel/cred.c | 2 +- > kernel/events/uprobes.c | 2 +- > kernel/fork.c | 10 +++++----- > kernel/nsproxy.c | 4 ++-- > kernel/pid_namespace.c | 2 +- > kernel/sched/core.c | 4 ++-- > kernel/sched/fair.c | 2 +- > kernel/sched/sched.h | 4 ++-- > kernel/time/namespace.c | 2 +- > kernel/utsname.c | 2 +- > net/core/net_namespace.c | 2 +- > security/apparmor/lsm.c | 2 +- > security/security.c | 2 +- > security/selinux/hooks.c | 2 +- > security/tomoyo/tomoyo.c | 2 +- > 68 files changed, 95 insertions(+), 89 deletions(-) > --- > base-commit: 1357b2649c026b51353c84ddd32bc963e8999603 > change-id: 20250818-nios2-implement-clone3-7f252c20860b > > Best regards, > -- > Simon Schuster > >