From: Jinchao Wang <wangjinchao600@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Naveen N . Rao" <naveen@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-perf-users@vger.kernel.org, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jinchao Wang <wangjinchao600@gmail.com>
Subject: [PATCH v2 08/18] mm/ksw: add stack probe support
Date: Thu, 4 Sep 2025 08:21:05 +0800 [thread overview]
Message-ID: <20250904002126.1514566-9-wangjinchao600@gmail.com> (raw)
In-Reply-To: <20250904002126.1514566-1-wangjinchao600@gmail.com>
Introduce stack management for KStackWatch using kprobes and fprobes to
enable dynamic watch switching:
- Entry: prepare target address/length and enable watch
- Exit: disable watch
Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
---
mm/kstackwatch/kstackwatch.h | 4 ++
mm/kstackwatch/stack.c | 91 ++++++++++++++++++++++++++++++++++++
2 files changed, 95 insertions(+)
diff --git a/mm/kstackwatch/kstackwatch.h b/mm/kstackwatch/kstackwatch.h
index 13ef8c79f855..bc8664af4fa6 100644
--- a/mm/kstackwatch/kstackwatch.h
+++ b/mm/kstackwatch/kstackwatch.h
@@ -38,6 +38,10 @@ struct ksw_config {
extern bool panic_on_catch;
+/* stack management */
+int ksw_stack_init(struct ksw_config *config);
+void ksw_stack_exit(void);
+
/* watch management */
int ksw_watch_init(struct ksw_config *config);
void ksw_watch_exit(void);
diff --git a/mm/kstackwatch/stack.c b/mm/kstackwatch/stack.c
index cec594032515..3b72177315cc 100644
--- a/mm/kstackwatch/stack.c
+++ b/mm/kstackwatch/stack.c
@@ -1 +1,92 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include <linux/fprobe.h>
+#include <linux/kprobes.h>
+#include <linux/sched.h>
+#include <linux/spinlock.h>
+
+#include "kstackwatch.h"
+
+struct ksw_config *probe_config;
+
+/* prepare watch_addr and watch_len for watch */
+static int ksw_stack_prepare_watch(struct pt_regs *regs,
+ struct ksw_config *config, u64 *watch_addr,
+ u64 *watch_len)
+{
+ /* TODO: implement logic */
+ *watch_addr = 0;
+ *watch_len = 0;
+ return 0;
+}
+
+static struct kprobe entry_probe;
+static struct fprobe exit_probe_fprobe;
+
+static void ksw_stack_entry_handler(struct kprobe *p, struct pt_regs *regs,
+ unsigned long flags)
+{
+ int ret;
+ u64 watch_addr;
+ u64 watch_len;
+
+ ret = ksw_stack_prepare_watch(regs, probe_config, &watch_addr,
+ &watch_len);
+ if (ret) {
+ pr_err("KSW: failed to prepare watch target: %d\n", ret);
+ return;
+ }
+
+ ret = ksw_watch_on(watch_addr, watch_len);
+ if (ret) {
+ pr_err("KSW: failed to watch on addr:0x%llx len:%llx %d\n",
+ watch_addr, watch_len, ret);
+ return;
+ }
+}
+
+static void ksw_stack_exit_handler(struct fprobe *fp, unsigned long ip,
+ unsigned long ret_ip,
+ struct ftrace_regs *regs, void *data)
+{
+ ksw_watch_off();
+}
+
+int ksw_stack_init(struct ksw_config *config)
+{
+ int ret;
+ char *symbuf = NULL;
+
+ /* Setup entry probe */
+ memset(&entry_probe, 0, sizeof(entry_probe));
+ entry_probe.symbol_name = config->function;
+ entry_probe.offset = config->ip_offset;
+ entry_probe.post_handler = ksw_stack_entry_handler;
+ probe_config = config;
+ ret = register_kprobe(&entry_probe);
+ if (ret < 0) {
+ pr_err("KSW: Failed to register kprobe ret %d\n", ret);
+ return ret;
+ }
+
+ /* Setup exit probe */
+ memset(&exit_probe_fprobe, 0, sizeof(exit_probe_fprobe));
+ exit_probe_fprobe.exit_handler = ksw_stack_exit_handler;
+ symbuf = probe_config->function;
+
+ ret = register_fprobe_syms(&exit_probe_fprobe, (const char **)&symbuf,
+ 1);
+ if (ret < 0) {
+ pr_err("KSW: register_fprobe_syms fail %d\n", ret);
+ unregister_kprobe(&entry_probe);
+ return ret;
+ }
+
+ return 0;
+}
+
+void ksw_stack_exit(void)
+{
+ unregister_fprobe(&exit_probe_fprobe);
+ unregister_kprobe(&entry_probe);
+}
--
2.43.0
next prev parent reply other threads:[~2025-09-04 0:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 0:20 [PATCH v2 00/18] mm/ksw: Introduce real-time Kernel Stack Watch debugging tool Jinchao Wang
2025-09-04 0:20 ` [PATCH v2 01/18] mm/ksw: add build system support Jinchao Wang
2025-09-04 7:46 ` Mike Rapoport
2025-09-04 0:20 ` [PATCH v2 02/18] mm/ksw: add ksw_config struct and parser Jinchao Wang
2025-09-04 7:47 ` Mike Rapoport
2025-09-04 0:21 ` [PATCH v2 03/18] mm/ksw: add /proc/kstackwatch interface Jinchao Wang
2025-09-04 7:51 ` Mike Rapoport
2025-09-04 0:21 ` [PATCH v2 04/18] mm/ksw: add HWBP pre-allocation support Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 05/18] x86/hw_breakpoint: introduce arch_reinstall_hw_breakpoint() for atomic context Jinchao Wang
2025-09-04 6:38 ` Peter Zijlstra
2025-09-04 0:21 ` [PATCH v2 06/18] perf/hw_breakpoint: add arch-independent hw_breakpoint_modify_local() Jinchao Wang
2025-09-04 6:44 ` Peter Zijlstra
2025-09-05 16:18 ` kernel test robot
2025-09-05 17:31 ` kernel test robot
2025-09-04 0:21 ` [PATCH v2 07/18] mm/ksw: add atomic watch on/off operations Jinchao Wang
2025-09-04 6:46 ` Peter Zijlstra
2025-09-04 0:21 ` Jinchao Wang [this message]
2025-09-04 0:21 ` [PATCH v2 09/18] mm/ksw: implement stack canary and local var resolution logic Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 10/18] mm/ksw: add per-task recursion depth tracking Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 11/18] mm/ksw: coordinate watch and stack for full functionality Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 12/18] mm/ksw: add self-debug functions for kstackwatch watch Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 13/18] mm/ksw: add test module Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 14/18] mm/ksw: add stack overflow test Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 15/18] mm/ksw: add simplified silent corruption test Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 16/18] mm/ksw: add recursive " Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 17/18] tools/kstackwatch: add interactive test script for KStackWatch Jinchao Wang
2025-09-04 0:21 ` [PATCH v2 18/18] MAINTAINERS: add entry for KStackWatch (Kernel Stack Watch) Jinchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904002126.1514566-9-wangjinchao600@gmail.com \
--to=wangjinchao600@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).