From: Dapeng Mi <dapeng1.mi@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Dapeng Mi <dapeng1.mi@intel.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: [Patch v3 0/6] Perf kvm commands bug fix
Date: Fri, 19 Sep 2025 10:16:53 +0800 [thread overview]
Message-ID: <20250919021659.1263351-1-dapeng1.mi@linux.intel.com> (raw)
This patch-set fixes perf kvm commands issues, like missed memory
allocation check/free, out of range memory access and especially the
issue that fails to sample guest with "perf kvm record/top" commands on
Intel platforms.
Since the change "KVM: x86/pmu: Add basic support to enable guest PEBS
via DS"[1] starts, host loses the capability to sample guest with PEBS
since all PEBS related MSRs are switched to guest value after vm-entry,
like IA32_DS_AREA MSR is switched to guest GVA at vm-entry. This leads
to PEBS events can't be used to sample guest by host, otherwise no guest
PEBS records can be really sampled. The patches 5-6/6 fix this issue by
using "cycles" event instead of PEBS event "cycles:P" to sample guest on
Intel platforms.
Changes:
v2 -> v3:
* Correct the fixes tag in patch 5-6/6.
* Add "acked-by" tag from Namhyung.
v1 -> v2:
* Free memory allocated by strdup().
* Check "--pfm-events" in kvm_add_default_arch_event() as well.
* Opportunistically fix the missed memory allocation and free issue in
builtin-kwork.
* Comments refine.
Tests:
* Run command "perf kvm record -a && perf kvm report" and "perf kvm
top" on Intel Sapphire Rapids platform, guest records can be
captured successfully.
* Since no powerpc platforms on hand, doesn't check the patches on
powerpc. Any test on powerpc is appreciated.
Ref:
[1] https://lore.kernel.org/all/20220411101946.20262-1-likexu@tencent.com/
Dapeng Mi (6):
perf tools kvm: Add missed memory allocation check and free
perf tools kwork: Add missed memory allocation check and free
perf tools kvm: Fix the potential out of range memory access issue
perf tools: Add helper x86__is_intel_cpu()
perf tools kvm: Use "cycles" to sample guest for "kvm record" on Intel
perf tools kvm: Use "cycles" to sample guest for "kvm top" on Intel
tools/perf/arch/x86/util/kvm-stat.c | 51 +++++++++++
tools/perf/builtin-kvm.c | 130 ++++++++++++++++++++--------
tools/perf/builtin-kwork.c | 27 ++++--
tools/perf/util/env.c | 22 +++++
tools/perf/util/env.h | 2 +
tools/perf/util/kvm-stat.h | 10 +++
6 files changed, 203 insertions(+), 39 deletions(-)
base-commit: 576bd7a8c90c48e9e93a18de0bcc0fa1e0a5433b
--
2.34.1
next reply other threads:[~2025-09-19 2:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 2:16 Dapeng Mi [this message]
2025-09-19 2:16 ` [Patch v3 1/6] perf tools kvm: Add missed memory allocation check and free Dapeng Mi
2025-09-19 2:16 ` [Patch v3 2/6] perf tools kwork: " Dapeng Mi
2025-09-19 2:16 ` [Patch v3 3/6] perf tools kvm: Fix the potential out of range memory access issue Dapeng Mi
2025-09-19 2:16 ` [Patch v3 4/6] perf tools: Add helper x86__is_intel_cpu() Dapeng Mi
2025-09-19 2:16 ` [Patch v3 5/6] perf tools kvm: Use "cycles" to sample guest for "kvm record" on Intel Dapeng Mi
2025-09-19 19:21 ` Arnaldo Carvalho de Melo
2025-09-22 6:47 ` Mi, Dapeng
2025-09-19 2:16 ` [Patch v3 6/6] perf tools kvm: Use "cycles" to sample guest for "kvm top" " Dapeng Mi
2025-10-02 18:30 ` [Patch v3 0/6] Perf kvm commands bug fix Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250919021659.1263351-1-dapeng1.mi@linux.intel.com \
--to=dapeng1.mi@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@intel.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).