From: Leo Yan <leo.yan@arm.com>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Quentin Monnet <qmo@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
James Clark <james.clark@linaro.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
llvm@lists.linux.dev, bpf@vger.kernel.org
Subject: Re: [PATCH 4/8] perf test coresight: Dismiss clang warning for memcpy thread
Date: Fri, 26 Sep 2025 17:19:41 +0100 [thread overview]
Message-ID: <20250926161941.GG7985@e132581.arm.com> (raw)
In-Reply-To: <CAP-5=fWGKgXV52_9E7n9yDX1uNLF8qWT9XTFK8eKtc_LRCW5wg@mail.gmail.com>
On Thu, Sep 25, 2025 at 12:38:36PM -0700, Ian Rogers wrote:
> On Thu, Sep 25, 2025 at 3:26 AM Leo Yan <leo.yan@arm.com> wrote:
> >
> > clang-18.1.3 on Ubuntu 24.04.2 reports warning:
> >
> > memcpy_thread.c:30:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]
> > 30 | }
> > | ^
> >
> > Dismiss the warning with returning NULL from the thread function.
> >
> > Signed-off-by: Leo Yan <leo.yan@arm.com>
>
> lgtm, should this be moved into being a perf test workload as in
> tools/perf/tests/workloads/ ?
Now we have four programs under shell folder:
$ cd linux/tools/perf/tests/shell
$ find ./ -name *.c -o -name *.S
./coresight/unroll_loop_thread/unroll_loop_thread.c
./coresight/asm_pure_loop/asm_pure_loop.S
./coresight/thread_loop/thread_loop.c
./coresight/memcpy_thread/memcpy_thread.c
If really do this, can move all programs into folders?
tools/perf/tests/workloads/ - Common programs
tools/perf/tests/workloads/arm64 - Arch specific programs
Anyway, this should be a separate series to avoid complexity for
enabling Clang build.
Thanks,
Leo
next prev parent reply other threads:[~2025-09-26 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 10:26 [PATCH 0/8] perf build: Support building with Clang Leo Yan
2025-09-25 10:26 ` [PATCH 1/8] tools build: Align warning options with perf Leo Yan
2025-09-25 10:26 ` [PATCH 2/8] perf python: split Clang options when invoking Popen Leo Yan
2025-09-25 10:26 ` [PATCH 3/8] bpftool: Conditionally add -Wformat-signedness flag Leo Yan
2025-09-25 10:42 ` Quentin Monnet
2025-09-25 12:43 ` Leo Yan
2025-09-25 10:26 ` [PATCH 4/8] perf test coresight: Dismiss clang warning for memcpy thread Leo Yan
2025-09-25 19:38 ` Ian Rogers
2025-09-26 16:19 ` Leo Yan [this message]
2025-09-25 10:26 ` [PATCH 5/8] perf test coresight: Dismiss clang warning for thread loop Leo Yan
2025-09-25 10:26 ` [PATCH 6/8] perf test coresight: Dismiss clang warning for unroll loop thread Leo Yan
2025-09-25 10:26 ` [PATCH 7/8] perf build: Support build with clang Leo Yan
2025-09-25 10:26 ` [PATCH 8/8] perf docs: Document building with Clang Leo Yan
2025-09-25 19:43 ` Ian Rogers
2025-09-26 15:41 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926161941.GG7985@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=qmo@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).